morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #5905] [MERGED] fix: preserve unknown JSON omission counts #7104

New issue

Closed

opened 2026-11-01 21:45:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:45:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5905
Author: @tiggachris
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto

Base: main ← Head: fix/json-unknown-omitted-keys

📝 Commits (3)

c9ac658 fix: preserve unknown JSON omission counts
6d4fc84 fix: preserve unknown counts for unselected JSON
ceae89a fix: preserve unknown counts for uppercase JSON

📊 Changes

2 files changed (+134 additions, -1 deletions)

View changed files

📝 src/application/javascript/JavaScriptArtifactGraphStructure.ts (+6 -1)
📝 tests/boundary/filesystem/javascriptArtifactGraphObservationLookup.test.ts (+128 -0)

📄 Description

Summary

Fixes #5881.

Preserves the unknown omitted JSON top-level key count when JSON content has not been analyzed or decoded.

Changes

Preserve null for unavailable JSON observations instead of incorrectly reporting zero omitted keys.
Use the file's inventory kind to preserve unknown counts for unselected JSON files, including uppercase .JSON extensions.
Add regression tests for invalid UTF-8 JSON, unselected JSON, and unselected uppercase .JSON files.

Verification

Focused Vitest tests: passed (4 tests).
npm run check:fast: passed.
git diff --check: passed.
npm run check: passed (6 tasks successful).
Architecture guards: passed across 1,701 source files.

Author readiness

Human owner: @tiggachris

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5905 **Author:** [@tiggachris](https://github.com/tiggachris) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/22/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/json-unknown-omitted-keys` --- ### 📝 Commits (3) - [`c9ac658`](https://github.com/morluto/rea/commit/c9ac6585611b4089e29b37d46ed398f5068b58d1) fix: preserve unknown JSON omission counts - [`6d4fc84`](https://github.com/morluto/rea/commit/6d4fc8435e447ac162ffeca909a7094faca6d28f) fix: preserve unknown counts for unselected JSON - [`ceae89a`](https://github.com/morluto/rea/commit/ceae89a59e578e4135cbf820d51080a85a5ff633) fix: preserve unknown counts for uppercase JSON ### 📊 Changes **2 files changed** (+134 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/application/javascript/JavaScriptArtifactGraphStructure.ts` (+6 -1) 📝 `tests/boundary/filesystem/javascriptArtifactGraphObservationLookup.test.ts` (+128 -0) </details> ### 📄 Description ## Summary Fixes #5881. Preserves the unknown omitted JSON top-level key count when JSON content has not been analyzed or decoded. ## Changes - Preserve `null` for unavailable JSON observations instead of incorrectly reporting zero omitted keys. - Use the file's inventory kind to preserve unknown counts for unselected JSON files, including uppercase `.JSON` extensions. - Add regression tests for invalid UTF-8 JSON, unselected JSON, and unselected uppercase `.JSON` files. ## Verification - Focused Vitest tests: passed (4 tests). - `npm run check:fast`: passed. - `git diff --check`: passed. - `npm run check`: passed (6 tasks successful). - Architecture guards: passed across 1,701 source files. ## Author readiness Human owner: @tiggachris - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:45:24 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-03 13:39:20 +00:00

[PR #7104] chore(main): release rea-agents 6.9.0 #7645

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7104

No description provided.

Rows
Columns