morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #5975] [MERGED] perf(mcp)!: default to compact input schema advertisements #7113

New issue

Closed

opened 2026-11-01 21:45:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:45:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5975
Author: @gensokyo-dev
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @gensokyo-dev

Base: main ← Head: perf/5861-mcp-input-catalog

📝 Commits (9)

1759bf7 perf(mcp)!: default to compact input schema advertisements
df68294 fix(mcp): distinguish default and full catalog identities
2cb0a73 test(mcp): exercise full and compact workflow contracts
38c7295 fix(experiments): preserve catalog task receipt paths
c5cd352 test(mcp): make full schema conformance profiles explicit
0145a3a test(mcp): verify PCK inventory in both input profiles
2a6a081 fix(cli): report the selected MCP catalog identity
2608ec5 test(mcp): qualify full path schemas on current main
3ce7945 test(mcp): preserve canonical refusals in compact workflows

📊 Changes

45 files changed (+3887 additions, -331 deletions)

View changed files

📝 README.md (+6 -0)
📝 docs/client-verification.md (+2 -2)
📝 docs/mcp-contracts.md (+6 -5)
➕ experiments/analysis-efficiency/mcp-input-catalog-costs.py (+90 -0)
➕ experiments/analysis-efficiency/mcp-input-catalog-oracle.py (+54 -0)
➕ experiments/analysis-efficiency/mcp-input-catalog.json (+2794 -0)
➕ experiments/analysis-efficiency/mcp-input-catalog.md (+228 -0)
➕ experiments/analysis-efficiency/mcp-input-catalog.mjs (+176 -0)
📝 scripts/generate-skill-metadata.mjs (+2 -2)
📝 scripts/lib/catalog-builders.mjs (+2 -1)
📝 scripts/lib/product-catalog.mjs (+1 -1)
📝 scripts/lib/release-package-canary.mjs (+2 -2)
📝 scripts/verify-claude-client.mjs (+19 -3)
📝 scripts/verify-package-pack.mjs (+2 -2)
📝 scripts/verify-reconstruction-readiness.mjs (+15 -2)
📝 src/application/DirectAnalysisStatus.ts (+8 -0)
📝 src/application/Doctor.fixture.ts (+2 -2)
📝 src/application/Doctor.ts (+6 -5)
📝 src/application/Setup.fixture.ts (+2 -2)
📝 src/catalogIdentity.ts (+10 -4)

...and 25 more files

📄 Description

Behavior

Refs #5861. Omitted REA_MCP_INPUT_SCHEMA_PROFILE now selects the existing compact advertisement. Explicit full retains complete input guidance and nested advertised constraints. All 213 tools, canonical input validation, output contracts and complete Evidence remain available. This changes the default advertisement and is marked breaking.

Catalog ownership distinguishes canonical full from default identity. Runtime identity requires an explicit catalog; CLI status honors parsed input/output profiles and readiness records the live server identity.

Evidence and validation

Twelve completed SDK tasks on unmodified Alpine ripgrep/Zellij, three alternating pairs each: whole-task estimates ~204.3k → ~51.7k tokens including input catalog, every argument and text reply. Independent ELF/zlib/JSON oracle; complete parent Evidence agrees. No stable wall/CPU/memory gain.
Six actual Codex questions answered correctly. Actual Codex token savings are not established; compact required an extra call for the broad question.
Latest-main integration on 8e3bf56e1 preserved complete Zellij Evidence and input catalog. Production CLI/MCP profile parity, full/compact workflows, canonical negative cases, static and documentation checks passed. Earlier incomplete or failed local attempts and unchanged-limit retries remain recorded.
Native Claude 2.1.296 persisted its ~55KB status; the existing inline-only verifier also fails on untouched baseline. Persisted statuses validate and match selected identities; full Claude end-to-end success is not claimed.

CI passed. Codex reviewed the final head with no findings; Greptile 5/5; all actionable threads resolved.

Reproduction, receipts and remaining limits.

Author readiness

Human owner: @gensokyo-dev

The following owner declarations are transcribed at the human owner's explicit standing instruction in this session. This records that instruction, not an independently witnessed human review by the agent.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

Concrete problem, focused outcome and related issue identified.
Existing advertisement profiles and validation ownership reused; no new provider or target authority.
Contracts, caller overrides, complete Evidence and selected catalog identity checked.
Required CI and actionable automated review findings completed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5975 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Base:** `main` ← **Head:** `perf/5861-mcp-input-catalog` --- ### 📝 Commits (9) - [`1759bf7`](https://github.com/morluto/rea/commit/1759bf7e5425f9e0e2de3b2abaac830b7d4f147a) perf(mcp)!: default to compact input schema advertisements - [`df68294`](https://github.com/morluto/rea/commit/df682941b897fa76d4f550092da96341cb89e200) fix(mcp): distinguish default and full catalog identities - [`2cb0a73`](https://github.com/morluto/rea/commit/2cb0a73a71bec586d941b8f25dee54dd6f25bed0) test(mcp): exercise full and compact workflow contracts - [`38c7295`](https://github.com/morluto/rea/commit/38c72950883d6d6c9232dbe02a999a28d6134e75) fix(experiments): preserve catalog task receipt paths - [`c5cd352`](https://github.com/morluto/rea/commit/c5cd35276ffe47a81c5602cd212718296a1c1cf4) test(mcp): make full schema conformance profiles explicit - [`0145a3a`](https://github.com/morluto/rea/commit/0145a3aa3ff04eb28b92e6251890c4267744fc1c) test(mcp): verify PCK inventory in both input profiles - [`2a6a081`](https://github.com/morluto/rea/commit/2a6a0812886e1a4e022042947a59575bed1bc954) fix(cli): report the selected MCP catalog identity - [`2608ec5`](https://github.com/morluto/rea/commit/2608ec54505d246543669d11bc153f47dec43c4b) test(mcp): qualify full path schemas on current main - [`3ce7945`](https://github.com/morluto/rea/commit/3ce794585d1c0e4335f6145d67a82901d6c33973) test(mcp): preserve canonical refusals in compact workflows ### 📊 Changes **45 files changed** (+3887 additions, -331 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+6 -0) 📝 `docs/client-verification.md` (+2 -2) 📝 `docs/mcp-contracts.md` (+6 -5) ➕ `experiments/analysis-efficiency/mcp-input-catalog-costs.py` (+90 -0) ➕ `experiments/analysis-efficiency/mcp-input-catalog-oracle.py` (+54 -0) ➕ `experiments/analysis-efficiency/mcp-input-catalog.json` (+2794 -0) ➕ `experiments/analysis-efficiency/mcp-input-catalog.md` (+228 -0) ➕ `experiments/analysis-efficiency/mcp-input-catalog.mjs` (+176 -0) 📝 `scripts/generate-skill-metadata.mjs` (+2 -2) 📝 `scripts/lib/catalog-builders.mjs` (+2 -1) 📝 `scripts/lib/product-catalog.mjs` (+1 -1) 📝 `scripts/lib/release-package-canary.mjs` (+2 -2) 📝 `scripts/verify-claude-client.mjs` (+19 -3) 📝 `scripts/verify-package-pack.mjs` (+2 -2) 📝 `scripts/verify-reconstruction-readiness.mjs` (+15 -2) 📝 `src/application/DirectAnalysisStatus.ts` (+8 -0) 📝 `src/application/Doctor.fixture.ts` (+2 -2) 📝 `src/application/Doctor.ts` (+6 -5) 📝 `src/application/Setup.fixture.ts` (+2 -2) 📝 `src/catalogIdentity.ts` (+10 -4) _...and 25 more files_ </details> ### 📄 Description ## Behavior Refs #5861. Omitted `REA_MCP_INPUT_SCHEMA_PROFILE` now selects the existing compact advertisement. Explicit `full` retains complete input guidance and nested advertised constraints. All 213 tools, canonical input validation, output contracts and complete Evidence remain available. This changes the default advertisement and is marked breaking. Catalog ownership distinguishes canonical full from default identity. Runtime identity requires an explicit catalog; CLI status honors parsed input/output profiles and readiness records the live server identity. ## Evidence and validation - Twelve completed SDK tasks on unmodified Alpine ripgrep/Zellij, three alternating pairs each: whole-task estimates ~204.3k → ~51.7k tokens including input catalog, every argument and text reply. Independent ELF/zlib/JSON oracle; complete parent Evidence agrees. No stable wall/CPU/memory gain. - Six actual Codex questions answered correctly. Actual Codex token savings are not established; compact required an extra call for the broad question. - Latest-main integration on `8e3bf56e1` preserved complete Zellij Evidence and input catalog. Production CLI/MCP profile parity, full/compact workflows, canonical negative cases, static and documentation checks passed. Earlier incomplete or failed local attempts and unchanged-limit retries remain recorded. - Native Claude 2.1.296 persisted its ~55KB status; the existing inline-only verifier also fails on untouched baseline. Persisted statuses validate and match selected identities; full Claude end-to-end success is not claimed. [CI passed](https://github.com/morluto/rea/actions/runs/39629728525/job/119334675360). Codex reviewed the final head with no findings; Greptile 5/5; all actionable threads resolved. [Reproduction, receipts and remaining limits](https://github.com/morluto/rea/blob/3ce794585d1c0e4335f6145d67a82901d6c33973/experiments/analysis-efficiency/mcp-input-catalog.md). ## Author readiness Human owner: @gensokyo-dev The following owner declarations are transcribed at the human owner's explicit standing instruction in this session. This records that instruction, not an independently witnessed human review by the agent. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] Concrete problem, focused outcome and related issue identified. - [x] Existing advertisement profiles and validation ownership reused; no new provider or target authority. - [x] Contracts, caller overrides, complete Evidence and selected catalog identity checked. - [x] Required CI and actionable automated review findings completed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:45:28 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-03 13:39:25 +00:00

[PR #7117] [MERGED] fix(javascript): bind defaulted and destructured Webpack factory roles #7655

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7113

No description provided.

Rows
Columns