mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6008] [MERGED] fix(firmware): keep a missing producer report distinct after exit 0 #7115
Closed
opened 2026-11-01 21:45:30 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7115
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6008
Author: @kaoru0822-kitauji
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:fix/5876-binwalk-missing-report📝 Commits (2)
c733381fix(firmware): keep a missing producer report distinct after exit 0b735b40fix(firmware): keep missing-report recovery from replaying removed paths📊 Changes
5 files changed (+210 additions, -51 deletions)
View changed files
📝
docs/firmware-analysis.md(+3 -0)📝
src/firmware/FirmwareCommand.ts(+36 -21)📝
src/firmware/FirmwareFiles.ts(+49 -10)📝
tests/boundary/firmware/firmwareIntegration.test.ts(+46 -20)📝
tests/boundary/firmware/firmwareReportFiles.test.ts(+76 -0)📄 Description
What broke: A firmware engine (observed: real Binwalk 3.1.0) can exit 0 without writing its requested report; REA returned a generic
unreadable_outputwhose message told the caller to runrea doctor, with stdout/stderr folded into a free-text reason.Fix: The report owner (
FirmwareFileAccess.report) now records the observedreport_state(missing,empty,invalid_json,oversized,not_regular_file);readFirmwareCommandReportkeeps it with the command, args, limiter, exit status, signal and captured output, and gives report-specific recovery (recorded args are provenance; their private-workspace paths are removed, so recovery says to replace them rather than replay). No automatic retry, no empty result.Risk: Low. Same error code (
unreadable_output, not retryable) and success path;details.reasontext changes and stdout/stderr move intodetails.diagnostics.Summary
Fixes #5876. Before: Binwalk exiting 0 with no
--logreport gaveunreadable_outputwith the reasonTool did not produce the expected complete report: <path>; stdout (0 bytes): ; stderr (0 bytes):and genericrea doctoradvice. After: the failure says the engine exited 0 without a usable report, names the report state, keeps the command facts in structured diagnostics, and gives recovery steps for this report failure. A successful exit status is still not treated as an empty or complete scan.Problem and expected behavior
Trigger: the producer exits 0 and the requested report is absent (observed intermittently with Binwalk 3.1.0 in the issue), empty, or malformed. Invariant: exit 0 without a complete report is not scan Evidence, and the failure must stay explicit. The caller should see what was observed (report state, exit status, output) and checks for this case, not generic doctor advice presented as a repair.
Change and scope
src/firmware/FirmwareFiles.ts: the report reader classifies its own refusals withdiagnostics.report_state. It addsmissing(ENOENT at open) andempty(0 bytes, which used to fall into the JSON parse error). Its existing oversized, invalid-JSON and non-regular-file refusals now carry their states too.src/firmware/FirmwareCommand.ts:readFirmwareCommandReportcombines the reader's facts with the execution facts:report_path,report_failure,command,args,resource_limiter,exit_code,signal, stdout/stderr and byte counts. These are the same execution facts a successful run keeps inraw_result. The accepted Unblob exit-1 path keepsProviderAdapterErrorand the same diagnostic fields. The exit-0 path is anAnalysisOutputErrorwith its ownuserMessageandremediationAction. Removed: the stdout/stderr text folded intoreason.Contract and boundary impact
Semantic owner and earliest changed stage:
FirmwareFileAccess.report(report-state classification), thenreadFirmwareCommandReport(failure composition).Contribution scope fit and linked maintainer decision: not applicable (failure classification fix).
CLI and MCP/tool-catalog contract: no schema or catalog change. The error code is still
unreadable_output,retryable: false.details.reason,messageandremediation.actiontext changed, anddetails.diagnosticswas added.Provider, bridge, target-format, or platform compatibility: unchanged (Linux-only firmware lane).
Evidence, artifact, provenance, or reconstruction contract: unchanged success Evidence. Failures keep the command and report facts.
Target selection, authority, upstream behavior, and cleanup details: unchanged. No retry and no new process launches.
Generated metadata, package, or installation impact: none.
Read existing files or captured data.
Evidence and regression coverage
Tests added or updated:
tests/boundary/firmware/firmwareReportFiles.test.ts(cross-platform): an exit-0 run with a missing, empty, truncated-JSON, oversized or directory report projectsunreadable_outputwithreport_state, report path, command/args/limiter, exit and output facts, withoutrea doctorin the message; recovery must not present the removed private-workspace arguments as replayable.tests/boundary/firmware/firmwareIntegration.test.ts(Linux): real owned subprocess workflow for bothinspect_firmware_regions(Binwalk lane) andextract_firmware(Unblob lane), through the service projection and MCPstructuredContent. The exit-1 startup test now assertsreport_state: "missing".Base reproduction: the new boundary test failed on the base revision for the original 3 states (missing/empty/invalid_json; source restored with
git stash); oversized/not_regular_file cases were added after review. Real Binwalk is not installed on this host, so the runtime intermittency was not reproduced here.User-visible output (from the projection asserted in tests, missing report):
binwalk exited successfully but left no usable report (Report was not created), so inspect_firmware_regions produced no Evidence. A successful exit status is not an empty or complete result.details.diagnostics.report_state:"missing"Remaining proof gaps: the Linux-only integration cases were not run locally (macOS host); CI ran them green on the first push. Real Binwalk 3.1.0 was not run. The issue's root cause is still NOT_ENOUGH_INFO.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
npm run test:local -- src/firmware/{FirmwareCommand,FirmwareDeadline,FirmwareReports,FirmwareVersion}.test.ts src/domain/analysisErrorProjection.test.ts: 101 passed, 8 skipped (Linux-only).npm run test:focused -- tests/boundary/firmware/{firmwareReportFiles,firmwareValidationProjection,firmwareWorkspaceRecovery}.test.ts tests/process-global/firmware{FileLifetime,PublicationDeadline}.test.ts tests/acceptance/tools/localToolContracts.test.ts: 48 passed, 23 skipped (Linux-only).npm run test:focused -- tests/boundary/firmware/firmwareIntegration.test.ts: 36 skipped (macOS host; Linux-only).npm run test:local -- src/firmware/FirmwareCommand.test.ts src/domain/analysisErrorProjection.test.ts— 62 passed, 8 skipped;npm run test:focused -- tests/boundary/firmware/{firmwareReportFiles,firmwareIntegration,firmwareWorkspaceRecovery}.test.ts— 11 passed, 38 skipped (Linux-only).npm run check:fast: passed.npm run format:check: passed.npm run docs:check: passed.Compatibility, safety, and release
details.reasonshould readdetails.diagnostics.stdout/stderrinstead.Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.