mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6016] [MERGED] fix(browser)!: keep malformed console argument inventories unknown #7121
Closed
opened 2026-11-01 21:45:33 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7121
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6016
Author: @kaoru0822-kitauji
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:fix/5934-cdp-console-argument-inventory📝 Commits (2)
e57f66ffix(browser)!: keep malformed console argument inventories unknown7f2052ffix(browser): report malformed WebMCP registration stacks as incomplete📊 Changes
8 files changed (+377 additions, -37 deletions)
View changed files
📝
docs/browser-observation.md(+2 -2)📝
src/browser/CdpCaptureEventHandlers.ts(+35 -10)📝
src/browser/CdpCaptureEventHelpers.ts(+35 -10)📝
src/browser/CdpWebMcpDiscovery.ts(+6 -4)📝
src/domain/browserObservationSchemas.ts(+7 -2)➕
tests/boundary/browser/cdpConsoleArgumentInventory.test.ts(+278 -0)📝
tests/fixtures/fakeCdpBrowserEvents.ts(+12 -9)📝
tests/fixtures/fakeCdpBrowserTypes.ts(+2 -0)📄 Description
What broke: A CDP
Runtime.consoleAPICalledevent with an omitted, null or non-arrayargswas reported as a complete empty argument inventory. A malformed element was dropped and its retained siblings were renumbered. A malformed stack or top stack frame was likewise replaced by its caller frame, or treated as having no source at all.Fix: Console arguments are parsed by position. An unknown inventory is
argument_types: null, and text capture isunavailable. A malformed element stays at its index asunknown. Call-site attribution uses only frame 0 of a well-formed stack. Each malformed case recordsinvalid_protocol_valuein completeness, including WebMCP registration stacks.Risk: Low to moderate. Two schema widenings (
argument_typesnullable, newtext_capture.status: "unavailable") are marked breaking. Conforming browser events produce the same output as before.Summary
Fixes #5934.
inspect_web_page/rea inspect-web-pagenow keep a missing or malformed console argument inventory distinguishable from an observedargs: [], and keep retained console text at its original CDPargument_index.Problem and expected behavior
recordsValue(inCdpCaptureValues.ts) turns non-array input into[]and filters out non-record elements. The console handler used that filtered list for bothargument_typesand text positions. As a result:argsomitted,nullor"invalid"gaveargument_types: [],text_capture: {status: "included", values: []}and no completeness marker.args: [null, {type:"string", value:"second"}]gaveargument_types: ["string"]andargument_index: 0for"second", whose real position is 1.The same drop-and-reindex pattern was in
firstCallFrame(recordsValue(callFrames)[0]). WithcallFrames: [null, frame], it picked the caller frame as the call site. That frame was used for the console source location, the network initiator location and the WebMCP registration source.Change and scope
CdpCaptureEventHandlers.handleConsoleAPICalled: parsesargswithadmitRecordsand maps each element by position. A non-record element, or a record without a stringtype, becomes"unknown"at its index. An absent or non-array inventory becomesargument_types: null, and approved text capture becomesunavailable. Any of these recordsconsole_events: invalid_protocol_value, once per event, together with the existing timestamp check.CdpCaptureEventHelpers:firstCallFrameis replaced bytopCallFrame, which takes the raw stack value and returns aResultwith aMalformedCdpCallFrametag. It returns ok(frame) for frame 0, ok(undefined) for an omitted stack or emptycallFrames, and the error for a non-object stack, non-arraycallFramesor a non-record frame 0.initiatorLocationstops at a malformed stack or top frame, including a malformedparent, instead of walking on. Consumers recordconsole_events/network_initiators/webmcp_tools: invalid_protocol_value. WebMCP discovery keeps the registration withregistration_source: nulland marks discovery incomplete, socompareWebCapturesdoes not confirm a changed source (Codex review). It replaces WebMCP's own copy of the pattern.browserObservationSchemas.ts:argument_typesis nullable and has a description.text_capture.statusadds"unavailable", the vocabulary that accessibility text capture already uses.docs/browser-observation.md: documents positional argument types, the null/unknown cases and the frame-0 rule.recordsValueconsumers (cookies, IndexedDB stores and entries, cache entries, metrics, DOM properties). Those are unordered inventories with no positional identity. Whether they report dropped malformed elements is a separate question, left out of this PR.Contract and boundary impact
Semantic owner and earliest changed stage: the CDP capture event handlers and helpers in
src/browser/, whereRuntime.consoleAPICalledand initiator stacks are first parsed.Contribution scope fit and linked maintainer decision: not applicable (bug fix inside an existing boundary).
CLI and MCP/tool-catalog contract: the
inspect_web_pageoutput schema widensconsole.events[].argument_typesto nullable and adds"unavailable"toconsole.events[].text_capture.status.Provider, bridge, target-format, or platform compatibility: none. Conforming CDP producers always send an
argsarray of RemoteObjects withtype.Evidence, artifact, provenance, or reconstruction contract: missing or malformed producer data is now reported as unknown and incomplete instead of as a complete empty observation. Retained text keeps the original CDP argument identity.
Target selection, authority, upstream behavior, and cleanup details: unchanged.
Generated metadata, package, or installation impact: the advertised output schema changes as described; nothing generated is committed.
Read existing files or captured data.
Launch or attach to a process.
Evidence and regression coverage
Tests added or updated:
tests/boundary/browser/cdpConsoleArgumentInventory.test.tsrunsCdpBrowserProvider.inspectPageagainst the repository's fake CDP browser over HTTP/WebSocket and validates the result withwebPageInspectionSchema. Cases:argsomitted,nulland non-array; a non-object element; an element withouttype; the empty-array control; a non-primitive (object) control; console stacks with a malformed top frame, non-arraycallFramesand a non-object stack; a malformed top initiator frame; WebMCP registration stacks with the same three malformed shapes, plus omitted and empty controls. The fake browser gained awebMcpStackTraceoption for this.Base reproduction: on the base revision (
6d356b843), 7 of the original 9 cases fail. The two controls pass. The 4 cases added for the review (the non-object console stack and the three malformed WebMCP stacks) fail against the previous PR head (e57f66f7e), and the WebMCP controls pass there. The failures match the issue output, for exampleexpected [] to be nullandexpected ['string'] to deeply equal ['unknown','string']. All 16 pass with the fix.User-visible CLI/MCP output: not run separately. The CLI and MCP adapters reach the same provider;
consoleTimestampCliMcp.test.ts(CLI and MCP) still passes with the widened schema.Remaining proof gaps: no real browser was used. Only the simulated CDP producer was exercised.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
tests/boundary/browser/cdpConsoleArgumentInventory.test.ts: base revision 7 of 9 failed. The previous PR head failed 4 of 16. The current head passes all 16.npm run test:local --allsrc/browser/Cdp*.test.tsplussrc/domain/webMcpDiscovery.test.ts: 19 files, 251 tests passed.npm run test:focused --alltests/boundary/browser/cdp*.test.ts(including the new test),consoleTimestampCliMcp,webMcpReceiverCli,webSocketOpcodeCliMcp,tests/boundary/mcp/streamableHttpMcp.test.ts: 46 files passed, 1 skipped (cdpSvgXlinkHref, which skips itself); 473 tests passed, 3 skipped.streamableHttpMcp, which failed in CI shard 8/8 withfetch failed / other side closed, also passed on its own (2 of 2).npm run check:fast: passed.npm run format:check: passed.npm run docs:check: passed.mapover each console event's arguments in place of the existing filter. It was not measured.Compatibility, safety, and release
argsreturnedargument_types: []andtext_capture.status: "included". It now returnsargument_types: nullandtext_capture.status: "unavailable"(when text capture was selected), plus aconsole_events: invalid_protocol_valueexclusion. Consumers must handlenulland"unavailable". Compatibility cannot be kept without reporting missing evidence as a known empty inventory. The commit uses!and aBREAKING CHANGE:footer.unknown/null.Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.