[PR #6027] [CLOSED] test(contracts): keep JavaScript example counters in sync #7130

New issue

Closed

opened 2026-11-01 21:45:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:45:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6027
Author: @prayaggaikwad96
Created: 10/21/2026
Status: ❌ Closed

Base: main ← Head: fix/5955-canonical-javascript-example-stats

📝 Commits (1)

87ccd72 test(contracts): align counter test formatting with repository style

📊 Changes

2 files changed (+57 additions, -1 deletions)

View changed files

➕ src/contracts/javascript/javascriptRuntimeReconciliationExample.test.ts (+54 -0)
📝 src/contracts/javascript/javascriptRuntimeReconciliationExample.ts (+3 -1)

📄 Description

Summary

Add regression coverage for the canonical JavaScript application Evidence example's visited_ast_nodes and findings counters.

The corrected counter values (7 / 1) are already present on current upstream main.
Export the example's source string once and use it both to construct the artifact and in the regression test.
Compare the embedded statistics against static source analysis and a real one-file application analysis.

Branch status

Rebased the change onto current upstream main at 4557791a2e0b77ff08afbb886b9cd3a92b6e1aef.
Current head: 87ccd72c61a4f2093e30c00363af430c56baee34.
Current PR diff contains the shared source constant and regression test; branch is 1 commit ahead and 0 behind that base.
Used node:path's join for the temporary fixture path.

Validation

PR readiness workflow passed on current head: latest run.
Author declaration check passed.
Greptile completed its review and added no comments.
Run the focused Vitest test and typecheck in a local checkout.
Confirm required CI checks pass. The CI and PR title workflows are currently action_required, so full test validation has not been confirmed.

Tests have not been run in a local checkout. Keep this PR in draft until focused validation and required CI are verified.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6027 **Author:** [@prayaggaikwad96](https://github.com/prayaggaikwad96) **Created:** 10/21/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/5955-canonical-javascript-example-stats` --- ### 📝 Commits (1) - [`87ccd72`](https://github.com/morluto/rea/commit/87ccd72c61a4f2093e30c00363af430c56baee34) test(contracts): align counter test formatting with repository style ### 📊 Changes **2 files changed** (+57 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `src/contracts/javascript/javascriptRuntimeReconciliationExample.test.ts` (+54 -0) 📝 `src/contracts/javascript/javascriptRuntimeReconciliationExample.ts` (+3 -1) </details> ### 📄 Description ## Summary Add regression coverage for the canonical JavaScript application Evidence example's `visited_ast_nodes` and `findings` counters. - The corrected counter values (`7` / `1`) are already present on current upstream `main`. - Export the example's source string once and use it both to construct the artifact and in the regression test. - Compare the embedded statistics against static source analysis and a real one-file application analysis. ## Branch status - Rebased the change onto current upstream `main` at `4557791a2e0b77ff08afbb886b9cd3a92b6e1aef`. - Current head: `87ccd72c61a4f2093e30c00363af430c56baee34`. - Current PR diff contains the shared source constant and regression test; branch is 1 commit ahead and 0 behind that base. - Used `node:path`'s `join` for the temporary fixture path. ## Validation - [x] PR readiness workflow passed on current head: [latest run](https://github.com/morluto/rea/actions/runs/40333583401). - [x] Author declaration check passed. - [x] Greptile completed its review and added no comments. - [ ] Run the focused Vitest test and typecheck in a local checkout. - [ ] Confirm required CI checks pass. The `CI` and `PR title` workflows are currently `action_required`, so full test validation has not been confirmed. Tests have not been run in a local checkout. Keep this PR in draft until focused validation and required CI are verified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:45:38 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-03 13:39:28 +00:00

[PR #7131] [MERGED] fix(javascript): close member-path cycles through self stores #7662

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7130

No description provided.

Rows
Columns