[PR #6144] [MERGED] fix(cancellation): preserve caller abort reason in cancellation errors #7159

New issue

Closed

opened 2026-11-01 21:45:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-11-01 21:45:48 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6144
Author: @agorevski
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto

Base: main ← Head: fix/cancel-reason-a

---

📝 Commits (2)

• b74ae8e fix(cancellation): preserve caller abort reason in cancellation errors
• b215ca0 test(cancellation): assert the exact caller reason identity

📊 Changes

22 files changed (+253 additions, -52 deletions)

View changed files

📝 src/application/analysisView/AnalysisViewService.test.ts (+22 -15)
📝 src/application/analysisView/AnalysisViewService.ts (+12 -4)
📝 src/application/binaryDiagnostics/BinaryLayoutService.test.ts (+27 -0)
📝 src/application/binaryDiagnostics/BinaryLayoutService.ts (+5 -1)
📝 src/application/binaryDiagnostics/RecordedCrashService.test.ts (+27 -0)
📝 src/application/binaryDiagnostics/RecordedCrashService.ts (+5 -1)
📝 src/application/flutter/DartAotInspection.ts (+5 -1)
📝 src/application/javascript/JavaScriptArtifactReconstruction.ts (+1 -0)
📝 src/application/wasm/WasmArtifactService.test.ts (+11 -7)
📝 src/application/wasm/WasmArtifactService.ts (+5 -1)
📝 src/artifacts/AsarListing.ts (+1 -0)
📝 src/artifacts/javascript/JavaScriptArtifactFiles.ts (+1 -0)
📝 src/flutter/FlutterBuildProvider.ts (+5 -1)
📝 src/kuna/KunaProjectReader.ts (+4 -1)
📝 src/process/DetachedPgpSignature.test.ts (+20 -0)
📝 src/process/DetachedPgpSignature.ts (+1 -0)
📝 src/server/runDerivedOperation.test.ts (+44 -1)
📝 src/server/runDerivedOperation.ts (+15 -3)
📝 tests/boundary/filesystem/asarListingAdmission.test.ts (+5 -2)
📝 tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts (+8 -4)

...and 2 more files

📄 Description

Summary

Cancellation errors built at nine producing boundaries omitted the caller's signal.reason as the error cause. The typed result therefore reported cancelled with an undefined reason, even though the exact object passed to AbortController.abort(reason) was still on the signal. This passes the exact reason at each producing site, following the convention already used by ArtifactHash.abortIfNeeded and PeResourcesService. Cancellation classification and cleanup behavior are unchanged.

Fixes #5935
Fixes #5944
Fixes #6100
Fixes #6101
Fixes #6110
Fixes #6113
Fixes #6121
Fixes #6131
Fixes #6132

Problem and expected behavior

Smallest trigger: pass an AbortSignal aborted with a non-undefined reason (null, a string, or an object) to one of the affected services or helpers, either already aborted or aborted while the operation runs.

Expected: the cancellation error's cause is that exact reason. Observed: cause === undefined. Violated invariant: a caller-supplied abort reason survives into the typed cancellation error.

Change and scope

Each affected site now passes { cause: <signal>.reason } to the cancellation error it constructs:

• src/artifacts/javascript/JavaScriptArtifactFiles.ts and src/application/javascript/JavaScriptArtifactReconstruction.ts: abortIfNeeded.
• src/server/runDerivedOperation.ts: all three checkpoints (before compute, after compute, at terminal delivery).
• src/process/DetachedPgpSignature.ts: the shared cancelled() helper, which covers every cancelled return.
• src/artifacts/AsarListing.ts: header listing traversal checkpoint.
• src/application/flutter/DartAotInspection.ts and src/flutter/FlutterBuildProvider.ts: the wrapper guard and the provider pre-admission guard.
• src/application/analysisView/AnalysisViewService.ts: both evidence-file cancellation checkpoints.
• src/application/binaryDiagnostics/BinaryLayoutService.ts and RecordedCrashService.ts: admission guards.
• src/application/wasm/WasmArtifactService.ts: admission guard.
• src/kuna/KunaProjectReader.ts: shared assembly-index wait that returns ABORTED.

Intentionally not included: other cancellation sites that already pass a cause, public CLI/MCP schema changes, and any change to provider execution. The fix follows the existing { cause: signal.reason } convention within existing boundaries.

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Contract and boundary impact

• Semantic owner and earliest changed stage: each boundary that constructs the cancellation error; the change is at that construction site.
• Contribution scope fit and linked maintainer decision: not applicable (ordinary fix within existing boundaries).
• CLI and MCP/tool-catalog contract: no schema change. The typed error's cause is now populated. Whether cause reaches MCP wire output was not examined.
• Provider, bridge, target-format, or platform compatibility: none. Kuna was exercised only through the repository's simulated executable.
• Evidence, artifact, provenance, or reconstruction contract: unchanged.
• Target selection, authority, upstream behavior, and cleanup details (if applicable): unchanged; existing cleanup assertions still pass.
• Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): none.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

The change adds no new effects; existing read paths are unchanged, so no effect boxes are checked.

• Read existing files or captured data.
• Launch or attach to a process.
• Inject instrumentation or run scripts/code.
• Change process memory, registers, files, or configuration.
• Contact network services.
• Recover protected code or work around protections.
• Documentation or usability only; no target interaction.
• Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

• Tests added or updated (existing test files only):
  • src/application/analysisView/AnalysisViewService.test.ts: pre-aborted and running evidence-file cancellation.
  • src/application/binaryDiagnostics/BinaryLayoutService.test.ts and RecordedCrashService.test.ts: pre-invocation admission, zero provider calls.
  • src/application/wasm/WasmArtifactService.test.ts: pre-provider cancellation.
  • src/process/DetachedPgpSignature.test.ts: null, string, and object reasons.
  • src/server/runDerivedOperation.test.ts: before compute, after compute, and at terminal delivery.
  • tests/boundary/filesystem/asarListingAdmission.test.ts: mid-traversal ASAR cancellation.
  • tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts: pre-aborted reconstruction.
  • tests/boundary/mcp/dartAotSummaryMcp.test.ts: Dart AOT wrapper and service-to-provider path.
  • tests/boundary/providers/kuna/kunaReaderCancellation.test.ts: shared assembly-index wait, for all three operations.
• Base reproduction or other evidence: I restored the 12 production files to origin/main (01788bac8) while keeping the new tests. The 10 test files then reported 17 failed and 126 passed, with failures covering all nine issues. After a later test-helper refactor, runDerivedOperation.test.ts alone reported 3 failed and 5 passed on the base sources. Evidence is executed (in-process service, boundary, and simulated-provider tests).
• User-visible CLI/MCP output (if applicable): not applicable; the change is in typed results.
• Remaining proof gaps:
  • Real Ghidra, IDA, Hopper, Frida, and browser providers were not run. Kuna was exercised only with its simulated executable.
  • No SDK or stdio cancellation transport test was run. The derived-operation cases are in-process.
  • The post-projection checkpoint in AnalysisViewService is fixed but has no deterministic test; the running-abort test may hit either checkpoint.
  • The JavaScriptArtifactFiles.ts abortIfNeeded fix has no isolated test; the reconstruction test covers the sibling helper in JavaScriptArtifactReconstruction.ts.
  • The Dart provider guard is asserted through service.execute, not in isolation.
  • Issue #6131 pointed at kunaProjectReaderConcurrency.test.ts; the regression was added to kunaReaderCancellation.test.ts, which already covers this path.

For evidence-bearing changes:

• Observed, derived, and inferred claims remain distinguishable.
• Artifact identity, source provenance, and failed attempts remain preserved.
• Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Review follow-up at b215ca09c (the bullets below describe the earlier commit):

• npm run test:focused -- tests/boundary/filesystem/asarListingAdmission.test.ts tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts — exit 0, 2 files, 24 tests passed.
• node scripts/run-typescript.mjs --noEmit — exit 0.
• npx oxlint on the changed test files — 0 errors, 0 warnings.
• npx oxfmt on the changed test files — formatted.
• Not run: the full suite.

• npx vitest run src/application/analysisView/AnalysisViewService.test.ts src/application/binaryDiagnostics/BinaryLayoutService.test.ts src/application/binaryDiagnostics/RecordedCrashService.test.ts src/application/wasm/WasmArtifactService.test.ts src/process/DetachedPgpSignature.test.ts src/server/runDerivedOperation.test.ts tests/boundary/filesystem/asarListingAdmission.test.ts tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts tests/boundary/mcp/dartAotSummaryMcp.test.ts tests/boundary/providers/kuna/kunaReaderCancellation.test.ts — passed: 10 files, 143 tests.
• Red run: same file list with the 12 production files restored from origin/main — 17 failed, 126 passed. Fixed files were restored and verified with cmp.
• npx vitest run src/server/runDerivedOperation.test.ts on base sources — 3 failed, 5 passed.
• npm run typecheck — exit 0.
• npx oxlint on the 22 changed files — exit 0 (warnings only, on pre-existing lines).
• npx oxfmt --check on the 22 changed files — passed.

Full suite not run.

Compatibility, safety, and release

• Breaking changes or migration steps: none. Typed cancellation errors now carry a populated cause.
• Real Hopper/Ghidra, browser, or OS coverage: not run.
• Package or release metadata impact: none; this is a patch-level fix.
• Security, privacy, process, or containment review: the caller's reason is retained as an in-process error cause. The change adds no new process, network, or file effects.

Author readiness

Human owner: @agorevski

• I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
• I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
• I declare this PR ready for initial maintainer review.

Before merge

• This PR addresses a concrete problem or an agreed enhancement.
• Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked, or the reason for not linking one is stated above.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6144 **Author:** [@agorevski](https://github.com/agorevski) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/cancel-reason-a` --- ### 📝 Commits (2) - [`b74ae8e`](https://github.com/morluto/rea/commit/b74ae8e5f298dbef612f6914b2153d2c3f552015) fix(cancellation): preserve caller abort reason in cancellation errors - [`b215ca0`](https://github.com/morluto/rea/commit/b215ca09c28aa4f6cef22998e9dab470a6c28b45) test(cancellation): assert the exact caller reason identity ### 📊 Changes **22 files changed** (+253 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `src/application/analysisView/AnalysisViewService.test.ts` (+22 -15) 📝 `src/application/analysisView/AnalysisViewService.ts` (+12 -4) 📝 `src/application/binaryDiagnostics/BinaryLayoutService.test.ts` (+27 -0) 📝 `src/application/binaryDiagnostics/BinaryLayoutService.ts` (+5 -1) 📝 `src/application/binaryDiagnostics/RecordedCrashService.test.ts` (+27 -0) 📝 `src/application/binaryDiagnostics/RecordedCrashService.ts` (+5 -1) 📝 `src/application/flutter/DartAotInspection.ts` (+5 -1) 📝 `src/application/javascript/JavaScriptArtifactReconstruction.ts` (+1 -0) 📝 `src/application/wasm/WasmArtifactService.test.ts` (+11 -7) 📝 `src/application/wasm/WasmArtifactService.ts` (+5 -1) 📝 `src/artifacts/AsarListing.ts` (+1 -0) 📝 `src/artifacts/javascript/JavaScriptArtifactFiles.ts` (+1 -0) 📝 `src/flutter/FlutterBuildProvider.ts` (+5 -1) 📝 `src/kuna/KunaProjectReader.ts` (+4 -1) 📝 `src/process/DetachedPgpSignature.test.ts` (+20 -0) 📝 `src/process/DetachedPgpSignature.ts` (+1 -0) 📝 `src/server/runDerivedOperation.test.ts` (+44 -1) 📝 `src/server/runDerivedOperation.ts` (+15 -3) 📝 `tests/boundary/filesystem/asarListingAdmission.test.ts` (+5 -2) 📝 `tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts` (+8 -4) _...and 2 more files_ </details> ### 📄 Description <!-- PR title: type(optional-scope): imperative outcome The title becomes the squash-merge commit subject and generated changelog entry. --> ## Summary <!-- What user, agent, or maintainer problem does this solve? Link the issue with "Fixes #123" when applicable. Keep the prior behavior, expected contract, and new behavior understandable without private context. --> Cancellation errors built at nine producing boundaries omitted the caller's `signal.reason` as the error `cause`. The typed result therefore reported `cancelled` with an undefined reason, even though the exact object passed to `AbortController.abort(reason)` was still on the signal. This passes the exact reason at each producing site, following the convention already used by `ArtifactHash.abortIfNeeded` and `PeResourcesService`. Cancellation classification and cleanup behavior are unchanged. Fixes #5935 Fixes #5944 Fixes #6100 Fixes #6101 Fixes #6110 Fixes #6113 Fixes #6121 Fixes #6131 Fixes #6132 ## Problem and expected behavior <!-- For fixes, give the smallest trigger and violated invariant. For features, describe the use case and observable outcome. --> Smallest trigger: pass an `AbortSignal` aborted with a non-undefined reason (`null`, a string, or an object) to one of the affected services or helpers, either already aborted or aborted while the operation runs. Expected: the cancellation error's `cause` is that exact reason. Observed: `cause === undefined`. Violated invariant: a caller-supplied abort reason survives into the typed cancellation error. ## Change and scope <!-- Explain the chosen approach, why it fits REA's architecture, and what is intentionally not included. --> Each affected site now passes `{ cause: <signal>.reason }` to the cancellation error it constructs: - `src/artifacts/javascript/JavaScriptArtifactFiles.ts` and `src/application/javascript/JavaScriptArtifactReconstruction.ts`: `abortIfNeeded`. - `src/server/runDerivedOperation.ts`: all three checkpoints (before compute, after compute, at terminal delivery). - `src/process/DetachedPgpSignature.ts`: the shared `cancelled()` helper, which covers every cancelled return. - `src/artifacts/AsarListing.ts`: header listing traversal checkpoint. - `src/application/flutter/DartAotInspection.ts` and `src/flutter/FlutterBuildProvider.ts`: the wrapper guard and the provider pre-admission guard. - `src/application/analysisView/AnalysisViewService.ts`: both evidence-file cancellation checkpoints. - `src/application/binaryDiagnostics/BinaryLayoutService.ts` and `RecordedCrashService.ts`: admission guards. - `src/application/wasm/WasmArtifactService.ts`: admission guard. - `src/kuna/KunaProjectReader.ts`: shared assembly-index wait that returns `ABORTED`. Intentionally not included: other cancellation sites that already pass a cause, public CLI/MCP schema changes, and any change to provider execution. The fix follows the existing `{ cause: signal.reason }` convention within existing boundaries. Follow the [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope). Unresolved scope, authority, side effects, or required verification block integration. Link the required maintainer scope decision for new providers or capabilities involving target execution, injection, mutation, or protection recovery; ordinary fixes within existing boundaries may state "not applicable". Draft PRs may leave the scope decision pending and the readiness and merge checklists unchecked. Maintainers can help resolve open questions. ## Contract and boundary impact <!-- Short answers are welcome. Complete applicable lines; mark unresolved facts as "unknown". Use "none" or "not applicable" only when established. --> - Semantic owner and earliest changed stage: each boundary that constructs the cancellation error; the change is at that construction site. - Contribution scope fit and linked maintainer decision: not applicable (ordinary fix within existing boundaries). - CLI and MCP/tool-catalog contract: no schema change. The typed error's `cause` is now populated. Whether `cause` reaches MCP wire output was not examined. - Provider, bridge, target-format, or platform compatibility: none. Kuna was exercised only through the repository's simulated executable. - Evidence, artifact, provenance, or reconstruction contract: unchanged. - Target selection, authority, upstream behavior, and cleanup details (if applicable): unchanged; existing cleanup assertions still pass. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `.agents/skills/reverse-engineer-anything/` and never commit build outputs): none. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. The change adds no new effects; existing read paths are unchanged, so no effect boxes are checked. - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage <!-- State whether evidence is executed, source-derived, or proposed. For fixes, show the original failure and explain how the regression would fail on the affected base revision when practical. Include the most useful proof inline; link long logs or artifacts, or put them in optional details. Documentation-only changes can use source, link, or rendered-document checks. --> - Tests added or updated (existing test files only): - `src/application/analysisView/AnalysisViewService.test.ts`: pre-aborted and running evidence-file cancellation. - `src/application/binaryDiagnostics/BinaryLayoutService.test.ts` and `RecordedCrashService.test.ts`: pre-invocation admission, zero provider calls. - `src/application/wasm/WasmArtifactService.test.ts`: pre-provider cancellation. - `src/process/DetachedPgpSignature.test.ts`: `null`, string, and object reasons. - `src/server/runDerivedOperation.test.ts`: before compute, after compute, and at terminal delivery. - `tests/boundary/filesystem/asarListingAdmission.test.ts`: mid-traversal ASAR cancellation. - `tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts`: pre-aborted reconstruction. - `tests/boundary/mcp/dartAotSummaryMcp.test.ts`: Dart AOT wrapper and service-to-provider path. - `tests/boundary/providers/kuna/kunaReaderCancellation.test.ts`: shared assembly-index wait, for all three operations. - Base reproduction or other evidence: I restored the 12 production files to `origin/main` (`01788bac8`) while keeping the new tests. The 10 test files then reported 17 failed and 126 passed, with failures covering all nine issues. After a later test-helper refactor, `runDerivedOperation.test.ts` alone reported 3 failed and 5 passed on the base sources. Evidence is executed (in-process service, boundary, and simulated-provider tests). - User-visible CLI/MCP output (if applicable): not applicable; the change is in typed results. - Remaining proof gaps: - Real Ghidra, IDA, Hopper, Frida, and browser providers were not run. Kuna was exercised only with its simulated executable. - No SDK or stdio cancellation transport test was run. The derived-operation cases are in-process. - The post-projection checkpoint in `AnalysisViewService` is fixed but has no deterministic test; the running-abort test may hit either checkpoint. - The `JavaScriptArtifactFiles.ts` `abortIfNeeded` fix has no isolated test; the reconstruction test covers the sibling helper in `JavaScriptArtifactReconstruction.ts`. - The Dart provider guard is asserted through `service.execute`, not in isolation. - Issue #6131 pointed at `kunaProjectReaderConcurrency.test.ts`; the regression was added to `kunaReaderCancellation.test.ts`, which already covers this path. For evidence-bearing changes: - [ ] Observed, derived, and inferred claims remain distinguishable. - [ ] Artifact identity, source provenance, and failed attempts remain preserved. - [ ] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Review follow-up at `b215ca09c` (the bullets below describe the earlier commit): - `npm run test:focused -- tests/boundary/filesystem/asarListingAdmission.test.ts tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts` — exit 0, 2 files, 24 tests passed. - `node scripts/run-typescript.mjs --noEmit` — exit 0. - `npx oxlint` on the changed test files — 0 errors, 0 warnings. - `npx oxfmt` on the changed test files — formatted. - Not run: the full suite. <!-- List only commands that actually ran, with observed results. Include the relevant real-provider or platform workflow, or explain why it was unavailable. Keep these results current after changes; a command without its result is incomplete. --> - `npx vitest run src/application/analysisView/AnalysisViewService.test.ts src/application/binaryDiagnostics/BinaryLayoutService.test.ts src/application/binaryDiagnostics/RecordedCrashService.test.ts src/application/wasm/WasmArtifactService.test.ts src/process/DetachedPgpSignature.test.ts src/server/runDerivedOperation.test.ts tests/boundary/filesystem/asarListingAdmission.test.ts tests/boundary/filesystem/javascriptArtifactReconstruction.test.ts tests/boundary/mcp/dartAotSummaryMcp.test.ts tests/boundary/providers/kuna/kunaReaderCancellation.test.ts` — passed: 10 files, 143 tests. - Red run: same file list with the 12 production files restored from `origin/main` — 17 failed, 126 passed. Fixed files were restored and verified with `cmp`. - `npx vitest run src/server/runDerivedOperation.test.ts` on base sources — 3 failed, 5 passed. - `npm run typecheck` — exit 0. - `npx oxlint` on the 22 changed files — exit 0 (warnings only, on pre-existing lines). - `npx oxfmt --check` on the 22 changed files — passed. Full suite not run. ## Compatibility, safety, and release <!-- Call out breaking changes, migrations, package effects, platform/provider limits, security/privacy/containment implications, and meaningful proof gaps. --> - Breaking changes or migration steps: none. Typed cancellation errors now carry a populated `cause`. <!-- For ! / BREAKING CHANGE: show a previously valid call/configuration, its new behavior and migration, and why compatibility/deprecation cannot preserve it. Every release increments minor, including breaking changes; keep breaking markers and migration notes so callers can assess compatibility. See docs/releasing.md. --> - Real Hopper/Ghidra, browser, or OS coverage: not run. - Package or release metadata impact: none; this is a patch-level fix. - Security, privacy, process, or containment review: the caller's reason is retained as an in-process error cause. The change adds no new process, network, or file effects. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @agorevski <!-- @GitHub-handle --> - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge <!-- Draft PRs may leave pending items unchecked. Resolve material scope and authority questions before integration. --> - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-11-01 21:45:48 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-03 13:39:38 +00:00

[PR #7159] [MERGED] feat(native): make function matching allowance configurable #7684

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7159

No description provided.