[PR #6148] [MERGED] test(artifacts): cover fixed input-size recovery for Rust and IL2CPP #7163

Closed
opened 2026-11-01 21:45:50 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6148
Author: @mpratsaki
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto

Base: main ← Head: fix/input-size-recovery-advice


📝 Commits (2)

  • 1b80650 test(artifacts): cover fixed input-size recovery for Rust and IL2CPP
  • 2ce1fda Merge origin/main; keep upstream Go and WASM input-size recovery

📊 Changes

1 file changed (+26 additions, -5 deletions)

View changed files

📝 tests/boundary/cli/artifactInputLimits.test.ts (+26 -5)

📄 Description

Summary

#5633 (ef59174c1) already fixed the wording reported in #5405: Rust and IL2CPP input-size refusals now recommend selecting an artifact within the fixed input allowance. That PR referenced #5405 without closing it, and no public CLI check covers either command. This PR locks the fix in with public CLI regression coverage.

Fixes #5405

Problem and expected behavior

  • inspect-rust-binary and inspect-il2cpp-metadata refusing a 257 MiB input must not suggest raising an evidence-reply file-size allowance. On current main they don't, but only Rust has a provider-level remediation assertion (rustBinaryBudget.test.ts). IL2CPP has none, and neither command is in the CLI input-limit matrix.
  • The matrix's negative assertion not.toContain("evidence reply") passes the current wording only because it says "evidence-reply" with a hyphen. It would not catch the old advice if a writer were reworded.

Change and scope

  • tests/boundary/cli/artifactInputLimits.test.ts: adds inspect-rust-binary and inspect-il2cpp-metadata to the public CLI matrix. Each entry asserts the allowance it names, and the absence of the old /allowance for the evidence reply/ advice.
  • Not included: no production change. An earlier revision of this PR also moved Go and WASM onto the shared helper; #6088 has since extended their bespoke advice (exact byte count, no runtime override, command_timeout_ms), so this PR now keeps main's wording and expects each command's own recovery text.

Contribution scope: ordinary fix within existing boundaries; maintainer scope decision not applicable.

Contract and boundary impact

  • Semantic owner and earliest changed stage: tests only; the producers (fixedAllowanceOptions for Rust/IL2CPP, provider-specific text for Go/WASM) are unchanged.
  • Contribution scope fit and linked maintainer decision: fix within existing boundaries; not applicable.
  • CLI and MCP/tool-catalog contract: unchanged.
  • Provider, bridge, target-format, or platform compatibility: none.
  • Evidence, artifact, provenance, or reconstruction contract: unchanged.
  • Target selection, authority, upstream behavior, and cleanup details: not applicable.
  • Generated metadata, package, or installation impact: none.

Expected effects:

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: artifactInputLimits.test.ts (+2 commands, per-command expected recovery, stronger negative assertion).
  • Base reproduction: the #5405 script (257 MiB file, adapted for Windows), run against a build of main 6d356b843, confirms #5633 already fixed Rust and IL2CPP:
    • inspect-rust-binary: Select a suitable complete artifact within the fixed Rust input allowance. Increasing an evidence-reply file-size allowance does not admit this input. Do not truncate required bytes. Repeating the unchanged request fails the same way.
    • inspect-il2cpp-metadata: the same, naming the fixed IL2CPP input allowance.
    • Both: code: resource_constraint, retryable: false, details.resource: file-size, maximum_input_bytes: 268435456.
  • Remaining proof gaps: I did not run the new matrix entries against a pre-#5633 revision to show them failing; that they would fail is derived from the source (the old text matches /allowance for the evidence reply/). MCP was not exercised; it uses the same producers.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Linux (Ubuntu 24.04, Node 24.18.0, head 2ce1fda51 after merging main d2015e94f):

  • npm run test:focused -- tests/boundary/cli/artifactInputLimits.test.ts src/wasm/WabtFailures.test.ts tests/boundary/rust/rustBinaryBudget.test.ts: 3 files, 20 passed, 0 skipped. All four matrix commands (go, rust, il2cpp, wasm) ran.

Windows 11 (Node 24.18.0, head 2ce1fda51):

  • npx tsc --noEmit and the pre-push npm run check:fast: passed.

Windows 11 (Node 24.18.0, earlier head 1b8065091):

  • Same focused command: 3 files passed, 24 tests passed, 4 skipped. The CLI matrix is skipIf(win32).
  • npm run check:fast: 2/2 successful.
  • npx oxfmt --check on the changed files: clean.

Compatibility, safety, and release

  • Breaking changes or migration steps: none.
  • Real Hopper/Ghidra, browser, or OS coverage: not applicable; Linux and Windows as above.
  • Package or release metadata impact: none.
  • Security, privacy, process, or containment review: no new authority or side effects.

Author readiness

Human owner: @mpratsaki

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6148 **Author:** [@mpratsaki](https://github.com/mpratsaki) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/input-size-recovery-advice` --- ### 📝 Commits (2) - [`1b80650`](https://github.com/morluto/rea/commit/1b8065091808853e12693c50b513005eef24dd15) test(artifacts): cover fixed input-size recovery for Rust and IL2CPP - [`2ce1fda`](https://github.com/morluto/rea/commit/2ce1fda514f497e6e179997301c882f67b19cc0f) Merge origin/main; keep upstream Go and WASM input-size recovery ### 📊 Changes **1 file changed** (+26 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/artifactInputLimits.test.ts` (+26 -5) </details> ### 📄 Description ## Summary #5633 (`ef59174c1`) already fixed the wording reported in #5405: Rust and IL2CPP input-size refusals now recommend selecting an artifact within the fixed input allowance. That PR referenced #5405 without closing it, and no public CLI check covers either command. This PR locks the fix in with public CLI regression coverage. Fixes #5405 ## Problem and expected behavior - `inspect-rust-binary` and `inspect-il2cpp-metadata` refusing a 257 MiB input must not suggest raising an evidence-reply file-size allowance. On current `main` they don't, but only Rust has a provider-level remediation assertion (`rustBinaryBudget.test.ts`). IL2CPP has none, and neither command is in the CLI input-limit matrix. - The matrix's negative assertion `not.toContain("evidence reply")` passes the current wording only because it says "evidence-reply" with a hyphen. It would not catch the old advice if a writer were reworded. ## Change and scope - `tests/boundary/cli/artifactInputLimits.test.ts`: adds `inspect-rust-binary` and `inspect-il2cpp-metadata` to the public CLI matrix. Each entry asserts the allowance it names, and the absence of the old `/allowance for the evidence reply/` advice. - Not included: no production change. An earlier revision of this PR also moved Go and WASM onto the shared helper; #6088 has since extended their bespoke advice (exact byte count, no runtime override, `command_timeout_ms`), so this PR now keeps main's wording and expects each command's own recovery text. Contribution scope: ordinary fix within existing boundaries; maintainer scope decision not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: tests only; the producers (`fixedAllowanceOptions` for Rust/IL2CPP, provider-specific text for Go/WASM) are unchanged. - Contribution scope fit and linked maintainer decision: fix within existing boundaries; not applicable. - CLI and MCP/tool-catalog contract: unchanged. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: unchanged. - Target selection, authority, upstream behavior, and cleanup details: not applicable. - Generated metadata, package, or installation impact: none. Expected effects: - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: `artifactInputLimits.test.ts` (+2 commands, per-command expected recovery, stronger negative assertion). - Base reproduction: the #5405 script (257 MiB file, adapted for Windows), run against a build of `main` 6d356b843, confirms #5633 already fixed Rust and IL2CPP: - `inspect-rust-binary`: `Select a suitable complete artifact within the fixed Rust input allowance. Increasing an evidence-reply file-size allowance does not admit this input. Do not truncate required bytes. Repeating the unchanged request fails the same way.` - `inspect-il2cpp-metadata`: the same, naming the fixed IL2CPP input allowance. - Both: `code: resource_constraint`, `retryable: false`, `details.resource: file-size`, `maximum_input_bytes: 268435456`. - Remaining proof gaps: I did not run the new matrix entries against a pre-#5633 revision to show them failing; that they would fail is derived from the source (the old text matches `/allowance for the evidence reply/`). MCP was not exercised; it uses the same producers. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Linux (Ubuntu 24.04, Node 24.18.0, head 2ce1fda51 after merging `main` d2015e94f): - `npm run test:focused -- tests/boundary/cli/artifactInputLimits.test.ts src/wasm/WabtFailures.test.ts tests/boundary/rust/rustBinaryBudget.test.ts`: 3 files, 20 passed, 0 skipped. All four matrix commands (go, rust, il2cpp, wasm) ran. Windows 11 (Node 24.18.0, head 2ce1fda51): - `npx tsc --noEmit` and the pre-push `npm run check:fast`: passed. Windows 11 (Node 24.18.0, earlier head 1b8065091): - Same focused command: 3 files passed, 24 tests passed, 4 skipped. The CLI matrix is `skipIf(win32)`. - `npm run check:fast`: 2/2 successful. - `npx oxfmt --check` on the changed files: clean. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable; Linux and Windows as above. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no new authority or side effects. ## Author readiness Human owner: @mpratsaki - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:45:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#7163
No description provided.