[PR #6150] [CLOSED] fix(diagnostics): attribute input and refusal failures to their source #7165

New issue

Closed

opened 2026-11-01 21:45:52 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-11-01 21:45:52 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6150
Author: @agorevski
Created: 10/21/2026
Status: ❌ Closed

Base: main ← Head: fix/input-diagnostics-b

---

📝 Commits (1)

• d1f1f63 fix(diagnostics): attribute input and refusal failures to their source

📊 Changes

28 files changed (+481 additions, -45 deletions)

View changed files

📝 bridge/pwntools/layout_impl.py (+1 -1)
📝 src/adb/AdbConfiguration.ts (+4 -3)
📝 src/adb/AdbProvider.ts (+2 -2)
📝 src/adb/AdbVersionProbe.test.ts (+25 -2)
📝 src/application/DirectAnalysis.ts (+3 -0)
📝 src/application/JsonFiles.ts (+3 -7)
📝 src/application/binary/AnalysisSnapshotFiles.ts (+3 -1)
📝 src/application/binary/BinarySessionRecords.ts (+11 -2)
📝 src/application/javascript/ElectronEvidence.ts (+7 -12)
📝 src/application/native/NativeMatchingAdmission.ts (+17 -1)
📝 src/application/native/NativeMatchingBundleSources.ts (+21 -7)
📝 src/application/native/NativeMatchingSources.ts (+10 -1)
📝 src/artifacts/pyinstaller/MarshalSubset.test.ts (+13 -0)
📝 src/domain/analysisView/environmentStateGate.ts (+1 -1)
📝 src/domain/analysisView/environmentStateRules.ts (+14 -4)
📝 src/domain/analysisView/environmentStateView.test.ts (+33 -0)
📝 src/domain/providerConfigurationRefusal.ts (+1 -0)
📝 src/javascript/analysis/JavaScriptAnalysisWorker.ts (+9 -0)
📝 src/server/registerFunctionComparisonTool.ts (+31 -0)
📝 src/server/registerSessionTools.ts (+1 -0)

...and 8 more files

📄 Description

Summary

Ten input and diagnostic defects where REA reported the wrong cause, operation, or
recovery for a request it refused or recovered from. Each fix moves the attribution
to the boundary that owns the fact:

• Malformed inline native-matching Evidence now names its request field (left,
  right, or the observation index) on both the MCP and CLI bundle paths. Fixes #5950.
• compare_functions reports wrong-kind Evidence per side as input issues instead of a
  generic integrity mismatch. Fixes #5932.
• ADB and Apktool capability refusals keep their version-probe diagnostics (selected
  command, stdout, stderr, probe result). Fixes #6094.
• ADB version-probe limits are attributed to the requesting operation. Fixes #5981.
• A cancelled open_binary snapshot read reports open_binary, not read_evidence_file.
  Fixes #5968.
• JavaScript worker I/O failure frames map to ProviderAdapterError with source path,
  phase, and I/O message instead of unreadable_output. Fixes #6114.
• Digit-string list totals count as environment-state counters. Fixes #5974.
• Negative PYZ marshal counts and lengths are format failures, so opaque PYZ recovery
  applies instead of aborting sibling inventory. Fixes #6120.
• Electron target-list Evidence reports the browser environment and host-platform
  limitation, as inspect already does. Fixes #5917.
• An overflowing ELF program-header offset in the pwntools bridge is an invalid format,
  not an execution failure. Fixes #5716.

Problem and expected behavior

Each case was reproduced or traced in the current base (01788bac8):

• Native matching parsed deferred Evidence without a request path, so the catch emitted
  an issue with path: []. The CLI bundle loader had the same gap and emitted no
  details.issues.
• The compare_functions kind gate constructed EvidenceIntegrityError with no side.
• providerConfigurationRefusal dropped failure.diagnostics, although the error
  options and projection already support them.
• inspectAdbClient hard-coded inspect_adb_client; readAnalysisSnapshot and the JSON
  readers hard-coded read_evidence_file.
• environmentStateGate compared counters with ===, excluding strings that countOf
  accepts.
• #protocolFailure sent every non-resource worker failure, including io, to
  AnalysisOutputError.
• MarshalSubset returned limit for negative sizes; PyzArchive recovers only format.
• list-electron-targets gated the environment on "target" in result, which list
  results lack.
• layout_impl.py omitted OverflowError from the structural-parse tuple.

Change and scope

Each change is local to the owning boundary, with no new contracts, providers, or
process launches:

• Shared helper malformedInlineEvidence in NativeMatchingBundleSources.ts is used by
  the loader root loop and the MCP-path resolve.
• The operation is threaded explicitly through readAnalysisSnapshot (new optional
  parameter defaulting to read_evidence_file) and readJsonObjectMembersFile.
• renderStateList keeps a string counter as a string, so the gate's
  same(render(...), body) check still accepts digit-string totals.

Not included: no tool schema or Evidence shape change; no change to ADB, Apktool, or
pwntools launch behavior; no unrelated cleanup. One new max-params warning is
introduced in src/application/JsonFiles.ts (warning only; the operation parameter must
reach the cancellation site).

Contribution scope: not applicable. These are fixes within existing boundaries.

Contract and boundary impact

• Semantic owner and earliest changed stage: each fix is at its producing boundary (the
  native input parser and bundle loader, the function-comparison input gate, the ADB and
  Apktool configuration projection, the snapshot reader, the JavaScript worker protocol
  mapping, the PYZ marshal classifier, the environment-state gate, the Electron evidence
  projection, and the pwntools bridge classifier).
• Contribution scope fit and linked maintainer decision: not applicable (existing
  boundaries).
• CLI and MCP/tool-catalog contract: no schema change. Error codes and details change
  as described under Compatibility.
• Provider, bridge, target-format, or platform compatibility: pwntools bridge (Python,
  Linux x64). Other providers are unchanged apart from the refusal diagnostics above.
• Evidence, artifact, provenance, or reconstruction contract: Evidence shape unchanged.
  Electron target-list Evidence now carries the same environment and limitation fields
  that inspect Evidence already carries.
• Target selection, authority, upstream behavior, and cleanup details (if applicable):
  not applicable. Cleanup and ownership paths are untouched.
• Generated metadata (docs/public/product-catalog.json), package, or installation impact:
  none. No generated catalogs, skills, or dependency manifests are edited.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

• Read existing files or captured data.
• Launch or attach to a process.
• Inject instrumentation or run scripts/code.
• Change process memory, registers, files, or configuration.
• Contact network services.
• Recover protected code or work around protections.
• Documentation or usability only; no target interaction.
• Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Evidence type: executed tests and base-revision reproductions. Source-derived conclusions
are noted where a test was not run.

• Tests added or updated:
  • tests/boundary/binaryDiagnostics/pwntoolsLayoutProvider.test.ts (real pwntools bridge; gated on REA_PWNTOOLS_PYTHON)
  • tests/boundary/cli/electronCli.test.ts
  • tests/boundary/mcp/functionComparisonReferenceFactsMcp.test.ts
  • tests/acceptance/tools/nativeFunctionMatching.test.ts (MCP cases plus one CLI case)
  • tests/boundary/filesystem/analysisSnapshotInput.test.ts
  • tests/boundary/javascript/javascriptSourceAnalysisWorker.test.ts (real worker process with deterministic input removal)
  • tests/process-global/apktoolEnvironment.test.ts
  • src/adb/AdbVersionProbe.test.ts
  • src/artifacts/pyinstaller/MarshalSubset.test.ts
  • src/domain/analysisView/environmentStateView.test.ts
  • tests/boundary/providers/adb/adbCommandFinalization.test.ts (call-site signature updates only)
• Base reproduction: each new regression was run with the base source restored (for
  CLI and stdio-MCP cases, dist was rebuilt from base first), then with the fix. All ten
  failed on base and passed with the fix:
  • #5716: execution_failure where invalid_request was expected.
  • #5917: list Evidence without environment or limitation.
  • #5932: no details.issues.
  • #5950: 5 of 5 cases, path: [] or no issues.
  • #5968: cancellation attributed to read_evidence_file.
  • #5974: counters empty for a string total.
  • #5981: resource_constraint attributed to inspect_adb_client.
  • #6094: no diagnostics.
  • #6114: unreadable_output.
  • #6120: limit where format was expected.
• User-visible CLI/MCP output (if applicable):
  • list-adb-devices --json with an unrecognized version launcher now returns
    capability_unavailable with details.diagnostics containing selected_binary,
    path_source, version_probe: "unrecognized_output", stdout, and stderr.
  • match-native-functions with left: "not-evidence" and --source_bundle returns
    invalid_request with details.issues: [{path: ["left"], reason: "invalid_value", ...}].
• Remaining proof gaps:
  • Real Ghidra, IDA, Hopper, Frida, and browser providers were not run.
  • No live Electron app (fake CDP endpoint only); no real adb device or Apktool install
    (substitute launchers only).
  • The pwntools case runs only when REA_PWNTOOLS_PYTHON points at pwntools 4.15.0,
    pyelftools 0.33, and Unicorn 2.1.2. The default vitest run skips it, and CI's
    real-binary-layout workflow runs verify:binary:layout, not this file. It was run
    locally against a venv that is not committed.
  • The open_binary cancellation test pre-aborts the signal at the snapshot reader; it
    does not race a live MCP cancellation.
  • Cancellation timeout and other operation-attribution paths of the ADB probe were not
    executed (only the output-limit path).

For evidence-bearing changes:

• Observed, derived, and inferred claims remain distinguishable.
• Artifact identity, source provenance, and failed attempts remain preserved.
• Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Merge follow-up: main was merged into the branch (f2a0da223) to resolve conflicts in src/application/JsonFiles.ts and src/javascript/analysis/JavaScriptAnalysisWorker.ts. After the merge:

• node scripts/run-typescript.mjs --noEmit — exit 0.
• npm run test:focused -- <12 files covering the changed boundaries> — 12 files, 164 passed, 2 skipped.
• npx oxlint on the two conflicted files — 0 errors; warnings only.
• npx oxfmt --check on the two conflicted files — formatted.
• Not run: the full suite.

Earlier validation (before the merge):

Each entry lists a command that ran and its observed result. Run in the worktree on Node
v22.23.1 (within engines).

• npm run build:cached — exit 0 (rebuilt several times, including from base source for
  the CLI and stdio-MCP base runs; final dist is from the fixed tree).
• npx vitest run src/artifacts/pyinstaller/MarshalSubset.test.ts src/domain/analysisView/environmentStateView.test.ts src/adb/AdbVersionProbe.test.ts tests/boundary/providers/adb/adbCommandFinalization.test.ts tests/boundary/filesystem/analysisSnapshotInput.test.ts tests/process-global/apktoolEnvironment.test.ts tests/boundary/mcp/functionComparisonReferenceFactsMcp.test.ts tests/boundary/cli/electronCli.test.ts tests/boundary/javascript/javascriptSourceAnalysisWorker.test.ts tests/acceptance/tools/nativeFunctionMatching.test.ts --maxWorkers 2 — 10 files, 115 tests passed.
• REA_PWNTOOLS_PYTHON=<local pwntools 4.15.0 venv>/bin/python npx vitest run tests/boundary/binaryDiagnostics/pwntoolsLayoutProvider.test.ts — 35 passed, 1 skipped (unsupported-host case).
• npx vitest run tests/boundary/binaryDiagnostics/pwntoolsLayoutProvider.test.ts (no runtime configured) — 34 passed, 2 skipped.
• Base-reproduction runs (each failed on base, as listed above) — 10 of 10 failed on base.
• npm run typecheck — exit 0.
• npx oxlint <27 changed files> — exit 0, 0 errors; pre-existing warnings plus one new max-params warning in src/application/JsonFiles.ts.
• npx oxfmt --check <27 changed files> — exit 0.
• Commit pre-commit hook (lint-staged) — exit 0.
• Manual CLI spot checks with the built runtime: list-adb-devices --json (unrecognized launcher) and match-native-functions with malformed left both returned the expected details shown above.

Not run: the full test suite, npm run check:pr, and any real-provider workflow.

Compatibility, safety, and release

• Breaking changes or migration steps: none to tool schemas or Evidence shape. Caller-visible
  error changes:
  • compare_functions wrong-kind Evidence: invalid_request with per-side issues
    (previously evidence_integrity_mismatch).
  • JavaScript worker I/O failure: execution_failure (previously unreadable_output).
  • PYZ with negative counts or lengths: left opaque, so sibling inventory is delivered
    (previously the whole artifact failed with truncated/limit).
  • Electron target-list Evidence: now includes environment and limitation fields.
  • Capability refusals for ADB and Apktool: now include details.diagnostics.
  • Environment-state list views: digit-string totals now count as counters.
    Internal signatures changed: inspectAdbClient (adds operation), readAnalysisSnapshot
    (optional trailing operation), readJsonObjectMembersFile (adds operation).
• Real Hopper/Ghidra, browser, or OS coverage: not run. Linux x64 only for the pwntools
  gated case.
• Package or release metadata impact: none.
• Security, privacy, process, or containment review: no new process launches, target
  access, or network access. The JavaScript worker I/O diagnostic carries the source path and
  the worker's I/O message, text that was previously embedded in the output error message.
  Other redaction is unchanged.

Author readiness

Human owner: @agorevski

• I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
• I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
• I declare this PR ready for initial maintainer review.

Before merge

• This PR addresses a concrete problem or an agreed enhancement.
• Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked, or the reason for not linking one is stated above.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6150 **Author:** [@agorevski](https://github.com/agorevski) **Created:** 10/21/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/input-diagnostics-b` --- ### 📝 Commits (1) - [`d1f1f63`](https://github.com/morluto/rea/commit/d1f1f63118418187481cd4f56ecf7608e80bcb82) fix(diagnostics): attribute input and refusal failures to their source ### 📊 Changes **28 files changed** (+481 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `bridge/pwntools/layout_impl.py` (+1 -1) 📝 `src/adb/AdbConfiguration.ts` (+4 -3) 📝 `src/adb/AdbProvider.ts` (+2 -2) 📝 `src/adb/AdbVersionProbe.test.ts` (+25 -2) 📝 `src/application/DirectAnalysis.ts` (+3 -0) 📝 `src/application/JsonFiles.ts` (+3 -7) 📝 `src/application/binary/AnalysisSnapshotFiles.ts` (+3 -1) 📝 `src/application/binary/BinarySessionRecords.ts` (+11 -2) 📝 `src/application/javascript/ElectronEvidence.ts` (+7 -12) 📝 `src/application/native/NativeMatchingAdmission.ts` (+17 -1) 📝 `src/application/native/NativeMatchingBundleSources.ts` (+21 -7) 📝 `src/application/native/NativeMatchingSources.ts` (+10 -1) 📝 `src/artifacts/pyinstaller/MarshalSubset.test.ts` (+13 -0) 📝 `src/domain/analysisView/environmentStateGate.ts` (+1 -1) 📝 `src/domain/analysisView/environmentStateRules.ts` (+14 -4) 📝 `src/domain/analysisView/environmentStateView.test.ts` (+33 -0) 📝 `src/domain/providerConfigurationRefusal.ts` (+1 -0) 📝 `src/javascript/analysis/JavaScriptAnalysisWorker.ts` (+9 -0) 📝 `src/server/registerFunctionComparisonTool.ts` (+31 -0) 📝 `src/server/registerSessionTools.ts` (+1 -0) _...and 8 more files_ </details> ### 📄 Description <!-- PR title: type(optional-scope): imperative outcome The title becomes the squash-merge commit subject and generated changelog entry. --> ## Summary Ten input and diagnostic defects where REA reported the wrong cause, operation, or recovery for a request it refused or recovered from. Each fix moves the attribution to the boundary that owns the fact: - Malformed inline native-matching Evidence now names its request field (`left`, `right`, or the observation index) on both the MCP and CLI bundle paths. Fixes #5950. - `compare_functions` reports wrong-kind Evidence per side as input issues instead of a generic integrity mismatch. Fixes #5932. - ADB and Apktool capability refusals keep their version-probe diagnostics (selected command, stdout, stderr, probe result). Fixes #6094. - ADB version-probe limits are attributed to the requesting operation. Fixes #5981. - A cancelled `open_binary` snapshot read reports `open_binary`, not `read_evidence_file`. Fixes #5968. - JavaScript worker I/O failure frames map to `ProviderAdapterError` with source path, phase, and I/O message instead of `unreadable_output`. Fixes #6114. - Digit-string list totals count as environment-state counters. Fixes #5974. - Negative PYZ marshal counts and lengths are format failures, so opaque PYZ recovery applies instead of aborting sibling inventory. Fixes #6120. - Electron target-list Evidence reports the browser environment and host-platform limitation, as inspect already does. Fixes #5917. - An overflowing ELF program-header offset in the pwntools bridge is an invalid format, not an execution failure. Fixes #5716. ## Problem and expected behavior Each case was reproduced or traced in the current base (`01788bac8`): - Native matching parsed deferred Evidence without a request path, so the catch emitted an issue with `path: []`. The CLI bundle loader had the same gap and emitted no `details.issues`. - The `compare_functions` kind gate constructed `EvidenceIntegrityError` with no side. - `providerConfigurationRefusal` dropped `failure.diagnostics`, although the error options and projection already support them. - `inspectAdbClient` hard-coded `inspect_adb_client`; `readAnalysisSnapshot` and the JSON readers hard-coded `read_evidence_file`. - `environmentStateGate` compared counters with `===`, excluding strings that `countOf` accepts. - `#protocolFailure` sent every non-resource worker failure, including `io`, to `AnalysisOutputError`. - `MarshalSubset` returned `limit` for negative sizes; `PyzArchive` recovers only `format`. - `list-electron-targets` gated the environment on `"target" in result`, which list results lack. - `layout_impl.py` omitted `OverflowError` from the structural-parse tuple. ## Change and scope Each change is local to the owning boundary, with no new contracts, providers, or process launches: - Shared helper `malformedInlineEvidence` in `NativeMatchingBundleSources.ts` is used by the loader root loop and the MCP-path `resolve`. - The operation is threaded explicitly through `readAnalysisSnapshot` (new optional parameter defaulting to `read_evidence_file`) and `readJsonObjectMembersFile`. - `renderStateList` keeps a string counter as a string, so the gate's `same(render(...), body)` check still accepts digit-string totals. Not included: no tool schema or Evidence shape change; no change to ADB, Apktool, or pwntools launch behavior; no unrelated cleanup. One new `max-params` warning is introduced in `src/application/JsonFiles.ts` (warning only; the operation parameter must reach the cancellation site). Contribution scope: not applicable. These are fixes within existing boundaries. ## Contract and boundary impact - Semantic owner and earliest changed stage: each fix is at its producing boundary (the native input parser and bundle loader, the function-comparison input gate, the ADB and Apktool configuration projection, the snapshot reader, the JavaScript worker protocol mapping, the PYZ marshal classifier, the environment-state gate, the Electron evidence projection, and the pwntools bridge classifier). - Contribution scope fit and linked maintainer decision: not applicable (existing boundaries). - CLI and MCP/tool-catalog contract: no schema change. Error codes and details change as described under Compatibility. - Provider, bridge, target-format, or platform compatibility: pwntools bridge (Python, Linux x64). Other providers are unchanged apart from the refusal diagnostics above. - Evidence, artifact, provenance, or reconstruction contract: Evidence shape unchanged. Electron target-list Evidence now carries the same environment and limitation fields that inspect Evidence already carries. - Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable. Cleanup and ownership paths are untouched. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact: none. No generated catalogs, skills, or dependency manifests are edited. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [x] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage Evidence type: executed tests and base-revision reproductions. Source-derived conclusions are noted where a test was not run. - Tests added or updated: - `tests/boundary/binaryDiagnostics/pwntoolsLayoutProvider.test.ts` (real pwntools bridge; gated on `REA_PWNTOOLS_PYTHON`) - `tests/boundary/cli/electronCli.test.ts` - `tests/boundary/mcp/functionComparisonReferenceFactsMcp.test.ts` - `tests/acceptance/tools/nativeFunctionMatching.test.ts` (MCP cases plus one CLI case) - `tests/boundary/filesystem/analysisSnapshotInput.test.ts` - `tests/boundary/javascript/javascriptSourceAnalysisWorker.test.ts` (real worker process with deterministic input removal) - `tests/process-global/apktoolEnvironment.test.ts` - `src/adb/AdbVersionProbe.test.ts` - `src/artifacts/pyinstaller/MarshalSubset.test.ts` - `src/domain/analysisView/environmentStateView.test.ts` - `tests/boundary/providers/adb/adbCommandFinalization.test.ts` (call-site signature updates only) - Base reproduction: each new regression was run with the base source restored (for CLI and stdio-MCP cases, `dist` was rebuilt from base first), then with the fix. All ten failed on base and passed with the fix: - #5716: `execution_failure` where `invalid_request` was expected. - #5917: list Evidence without `environment` or limitation. - #5932: no `details.issues`. - #5950: 5 of 5 cases, `path: []` or no issues. - #5968: cancellation attributed to `read_evidence_file`. - #5974: `counters` empty for a string total. - #5981: `resource_constraint` attributed to `inspect_adb_client`. - #6094: no `diagnostics`. - #6114: `unreadable_output`. - #6120: `limit` where `format` was expected. - User-visible CLI/MCP output (if applicable): - `list-adb-devices --json` with an unrecognized version launcher now returns `capability_unavailable` with `details.diagnostics` containing `selected_binary`, `path_source`, `version_probe: "unrecognized_output"`, `stdout`, and `stderr`. - `match-native-functions` with `left: "not-evidence"` and `--source_bundle` returns `invalid_request` with `details.issues: [{path: ["left"], reason: "invalid_value", ...}]`. - Remaining proof gaps: - Real Ghidra, IDA, Hopper, Frida, and browser providers were not run. - No live Electron app (fake CDP endpoint only); no real adb device or Apktool install (substitute launchers only). - The pwntools case runs only when `REA_PWNTOOLS_PYTHON` points at pwntools 4.15.0, pyelftools 0.33, and Unicorn 2.1.2. The default vitest run skips it, and CI's `real-binary-layout` workflow runs `verify:binary:layout`, not this file. It was run locally against a venv that is not committed. - The `open_binary` cancellation test pre-aborts the signal at the snapshot reader; it does not race a live MCP cancellation. - Cancellation timeout and other operation-attribution paths of the ADB probe were not executed (only the output-limit path). For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Merge follow-up: `main` was merged into the branch (`f2a0da223`) to resolve conflicts in `src/application/JsonFiles.ts` and `src/javascript/analysis/JavaScriptAnalysisWorker.ts`. After the merge: - `node scripts/run-typescript.mjs --noEmit` — exit 0. - `npm run test:focused -- <12 files covering the changed boundaries>` — 12 files, 164 passed, 2 skipped. - `npx oxlint` on the two conflicted files — 0 errors; warnings only. - `npx oxfmt --check` on the two conflicted files — formatted. - Not run: the full suite. Earlier validation (before the merge): Each entry lists a command that ran and its observed result. Run in the worktree on Node v22.23.1 (within `engines`). - `npm run build:cached` — exit 0 (rebuilt several times, including from base source for the CLI and stdio-MCP base runs; final `dist` is from the fixed tree). - `npx vitest run src/artifacts/pyinstaller/MarshalSubset.test.ts src/domain/analysisView/environmentStateView.test.ts src/adb/AdbVersionProbe.test.ts tests/boundary/providers/adb/adbCommandFinalization.test.ts tests/boundary/filesystem/analysisSnapshotInput.test.ts tests/process-global/apktoolEnvironment.test.ts tests/boundary/mcp/functionComparisonReferenceFactsMcp.test.ts tests/boundary/cli/electronCli.test.ts tests/boundary/javascript/javascriptSourceAnalysisWorker.test.ts tests/acceptance/tools/nativeFunctionMatching.test.ts --maxWorkers 2` — 10 files, 115 tests passed. - `REA_PWNTOOLS_PYTHON=<local pwntools 4.15.0 venv>/bin/python npx vitest run tests/boundary/binaryDiagnostics/pwntoolsLayoutProvider.test.ts` — 35 passed, 1 skipped (unsupported-host case). - `npx vitest run tests/boundary/binaryDiagnostics/pwntoolsLayoutProvider.test.ts` (no runtime configured) — 34 passed, 2 skipped. - Base-reproduction runs (each failed on base, as listed above) — 10 of 10 failed on base. - `npm run typecheck` — exit 0. - `npx oxlint <27 changed files>` — exit 0, 0 errors; pre-existing warnings plus one new `max-params` warning in `src/application/JsonFiles.ts`. - `npx oxfmt --check <27 changed files>` — exit 0. - Commit pre-commit hook (`lint-staged`) — exit 0. - Manual CLI spot checks with the built runtime: `list-adb-devices --json` (unrecognized launcher) and `match-native-functions` with malformed `left` both returned the expected `details` shown above. Not run: the full test suite, `npm run check:pr`, and any real-provider workflow. ## Compatibility, safety, and release - Breaking changes or migration steps: none to tool schemas or Evidence shape. Caller-visible error changes: - `compare_functions` wrong-kind Evidence: `invalid_request` with per-side issues (previously `evidence_integrity_mismatch`). - JavaScript worker I/O failure: `execution_failure` (previously `unreadable_output`). - PYZ with negative counts or lengths: left opaque, so sibling inventory is delivered (previously the whole artifact failed with `truncated`/`limit`). - Electron target-list Evidence: now includes environment and limitation fields. - Capability refusals for ADB and Apktool: now include `details.diagnostics`. - Environment-state list views: digit-string totals now count as counters. Internal signatures changed: `inspectAdbClient` (adds `operation`), `readAnalysisSnapshot` (optional trailing `operation`), `readJsonObjectMembersFile` (adds `operation`). - Real Hopper/Ghidra, browser, or OS coverage: not run. Linux x64 only for the pwntools gated case. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no new process launches, target access, or network access. The JavaScript worker I/O diagnostic carries the source path and the worker's I/O message, text that was previously embedded in the output error message. Other redaction is unchanged. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @agorevski <!-- @GitHub-handle --> - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge <!-- Draft PRs may leave pending items unchecked. Resolve material scope and authority questions before integration. --> - [x] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-11-01 21:45:52 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-03 13:39:40 +00:00

[PR #7165] [CLOSED] fix(tests): align setup and doctor regressions with explicit runtime registration #7688

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7165

No description provided.