mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-11-01 21:46:06 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7204
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6209
Author: @kaoru0822-kitauji
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:feat/asar-header-admission-setting📝 Commits (2)
1f28b74feat(artifacts): make ASAR header admission configurablea157dc4fix(artifacts): resolve ASAR header admission from the caller's environment📊 Changes
53 files changed (+657 additions, -127 deletions)
View changed files
📝
.agents/skills/reverse-engineer-anything/references/javascript-applications.md(+4 -4)📝
docs/electron-observation.md(+5 -5)📝
docs/javascript-artifact-reconstruction.md(+10 -7)📝
src/application/javascript/JavaScriptApplicationService.ts(+17 -2)📝
src/application/javascript/JavaScriptArtifactReconstruction.ts(+8 -1)📝
src/artifacts/ArtifactClassificationProbe.ts(+5 -2)📝
src/artifacts/ArtifactHash.ts(+3 -1)📝
src/artifacts/ArtifactOperationFailure.ts(+7 -3)📝
src/artifacts/ArtifactProvider.ts(+2 -0)📝
src/artifacts/AsarArtifactReader.ts(+9 -2)📝
src/artifacts/AsarHeader.ts(+57 -24)📝
src/artifacts/extraction/ArtifactExtraction.ts(+6 -1)📝
src/artifacts/inventory/ArtifactGraphConstruction.ts(+2 -1)📝
src/artifacts/inventory/classify.ts(+13 -3)📝
src/artifacts/inventory/reader.ts(+8 -1)📝
src/artifacts/inventory/scanCanonical.ts(+8 -1)📝
src/artifacts/inventory/scanReader.ts(+11 -1)📝
src/artifacts/inventory/types.ts(+3 -0)📝
src/artifacts/javascript/JavaScriptArtifactFiles.ts(+10 -1)📝
src/artifacts/javascript/JavaScriptArtifactReader.ts(+8 -1)...and 33 more files
📄 Description
Summary
Fixes #6176 (P0 ASAR item; the regex matching deadline is left for a separate PR).
Before:
MAX_ASAR_HEADER_BYTESwas a module constant shared by four consumers, and recovery text said the release had no override. After: operators can raise (up to 256 MiB) or lower the admission with one environment setting. The default stays the same.Problem and expected behavior
An app whose ASAR header exceeds 16 MiB is refused by
inspect_artifact,inventory_artifact,analyze_javascript_application,extract_artifactand Electron page resolution. Raisingmax_heap_mbor host memory does not help, and the only workaround was extracting the archive. Expected, per the issue: a named setting whose default equals today's constant, a documented maximum, recovery that names the effective value, and no change when unset.Change and scope
src/config/asarHeaderAdmission.tsowns the setting: schema, default, maximum and constraint text.REA_ASAR_MAX_HEADER_BYTESjoins the runtime environment schema, so MCP startup,rea doctorand setup/registration validation reject invalid values.AsarHeader.tsreplaces the constant withresolveAsarHeaderAdmission(environment). Nothing readsprocess.env; helpers without an environment use the default. The signature probe carries its admission and reports it with alimitobservation, so inventory raises the failure for the same admission the probe used.ArtifactProvider(inventory/inspection) and extraction resolve it intoArtifactInventoryOptions.asarHeaderAdmission. That reaches the root classification probe, root and nestedAsarArtifactReaders, and the per-entry hashing probes.environmentpassed by its server (ServerToolContext.environment) or CLI caller.CdpElectronProviderandV8InspectorProviderreceive it fromcreateOptionalObservationFactories(selectedEnvironment)and the CLI contexts, and forward it to everyauthorizedElectronFilecall.ConfigurationError, whichtranslateArtifactFailurenow passes through as typed (before, it became a generic I/O failure), and JS analysis returns it as aResult.ArtifactAdmissionLimitgainssource; error details addmaximum_header_bytes_sourceandsetting.Contract and boundary impact
src/config/asarHeaderAdmission.ts(value) andsrc/artifacts/AsarHeader.ts(admission, before any header allocation).maximum_header_bytes_sourceandsetting; recovery text now names the setting instead of "no runtime override".Expected effects:
Evidence and regression coverage
Tests added or updated (
tests/boundary/filesystem/asarHeaderAdmission.test.ts):"1",createDirectAnalysis({REA_ASAR_MAX_HEADER_BYTES: header-1})refuses a real@electron/asararchive forinventory_artifactandinspect_artifact, naming the setting, andcreateDirectAnalysis({})admits it. JS analysis refuses atheader-1and admits at the exact header size;"",0,-1, leading zero, units, exponent, whitespace, max+1) are refused by both the parser andparseEnvironment. At each owner an invalid value surfaces asconfiguration_invalid, not a default fallback;electronFileScope.test.ts: a header cached under a larger admission is not reused for a smaller one.clientConfigurationEnvironment.test.tsgains a setup/doctor refusal row; existing default-boundary tests were updated to the new owner.Real-app evidence, executed on this Mac (Node 26.5.0) with
rea inspect-artifact /Applications/Signal.app/Contents/Resources/app.asar --integrity-policy record-and-continue --detail summary --evidence_output …. Signal's archive is 43 MB with a 400,496-byte header. Baseline = merge-baseorigin/mainbuild; 3 runs each:7cf24efd802cd2527cf24efd802cd252=4004967cf24efd802cd252=2684354567cf24efd802cd252=400495truncated=0configuration_invalidUnset output is identical to baseline, and time and memory are within run-to-run noise. Token cost of successful results is unchanged.
analyze-javascript-applicationon Obsidian'sapp.asar(6,984-byte header) is refused at=6983and admitted at=6984, where it then reaches Obsidian's own unrelated unpacked-integrity mismatch. WithREA_ASAR_MAX_HEADER_BYTES=0,rea doctorreportsruntime-configuration:REA_ASAR_MAX_HEADER_BYTESasconfig_drift.User-visible output at
=400495:Remaining proof gaps: no real application with a header above 16 MiB was available, so the raise path is covered by the sparse-file boundary test rather than a real app. Windows and Linux were not run locally (CI).
For evidence-bearing changes:
Validation performed
npm run test:focused -- <78 ASAR/Electron/V8/CLI/optional-provider test files>— 77 files passed. 1564 tests passed, 10 skipped, 1 failed:src/inspector/JavaScriptRuntimeScope.cancellation.test.ts › stops Inspector target authorization after the current stat settles, which fails identically on unmodifiedorigin/mainon this macOS host (pre-existing, not changed here).npm run test:focused -- tests/boundary/filesystem/clientConfigurationEnvironment.test.ts tests/boundary/filesystem/electronFileScope.test.ts src/browser/ElectronFileScope.cleanup.test.ts tests/boundary/mcp/asarListingAdmissionMcp.test.ts— 39 passed, 10 skipped.npm run check:fast— passed.npm run format:check— passed.npm run docs:check— passed.npm run build:cachedon both trees).Compatibility, safety, and release
MAX_ASAR_HEADER_BYTESis replaced byDEFAULT_ASAR_MAX_HEADER_BYTES(config) andresolveAsarHeaderAdmission().Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.