morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #6248] [CLOSED] fix(cli): describe analysis-view parents through the shared contract #7225

New issue

Closed

opened 2026-11-01 21:46:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6248
Author: @AmmarJamil23
Created: 10/22/2026
Status: ❌ Closed

Base: main ← Head: fix/analysis-view-cli-help

📝 Commits (2)

a5143f8 fix(cli): describe analysis-view parents through the shared contract
28fff89 Merge remote-tracking branch 'upstream/main' into fix/analysis-view-cli-help

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 src/cli/analysisViewCommands.ts (+3 -1)
📝 tests/boundary/cli/analysisViewCli.test.ts (+12 -0)

📄 Description

Summary

Fixes #6225.

rea inspect-analysis-view --help described the command with its own hand-written list of Evidence families. That list drifted from the inspect_analysis_view contract and omitted parents the shared workflow accepts (Rust, IL2CPP metadata, model artifacts, GPU code objects, and also protobuf, qlog, Frida status and GDB/objdump command observations). The help now describes the command generally and defers the list to the contract that owns it.

Problem and expected behavior

Trigger: node scripts/rea.mjs inspect-analysis-view --help. The opening line ended in ... Dart AOT, web network capture or pcap Evidence JSON, understating accepted inputs. Expected (per the issue): accurate general wording; an exhaustive list is not required.

Change and scope

The CLI and MCP adapters already share one input schema (inspectAnalysisViewInputSchema) and one service (inspectAnalysisViewValidatedWithFiles; see src/application/analysisView/AnalysisViewService.ts). The family list therefore has one owner: the inspect_analysis_view tool contract (src/contracts/analysisViewToolContracts.ts). Rather than adding the missing names to a second copy, which would drift again, the CLI description no longer enumerates families and points to that contract. Nothing else changes; the other help text, options and behavior are untouched.

Contribution scope: ordinary documentation/usability fix within existing boundaries; maintainer scope decision not applicable.

Contract and boundary impact

Semantic owner and earliest changed stage: inspect_analysis_view tool contract (unchanged); CLI command description only.
Contribution scope fit and linked maintainer decision: not applicable (help-text fix).
CLI and MCP/tool-catalog contract: CLI help wording only; MCP tool description, schemas and catalog unchanged.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata, package, or installation impact: none; npm run docs:check passed with no generated changes.
Documentation or usability only; no target interaction.

Evidence and regression coverage

Tests added or updated: tests/boundary/cli/analysisViewCli.test.ts — "describes accepted parents through the shared analysis-view contract" runs inspect-analysis-view --help through the CLI fixture and requires the help to reference inspect_analysis_view.
Base reproduction: with the source change stashed, the new test failed with expected 'rea inspect-analysis-view — Project a…' to contain 'inspect_analysis_view' (received the old family list). With the change, it passes.
User-visible CLI output (after):

rea inspect-analysis-view — Project a selected view of completed analysis Evidence JSON without repeating the analysis; accepts the same parent Evidence and views as the inspect_analysis_view MCP tool

Remaining proof gaps: the claim that the CLI accepts the same parents and views as MCP is source-derived (shared schema and service), not re-executed per family in this PR.

Validation performed

Windows 11 x64, Node.js 24.18.0 (pinned), npm ci with locked dependencies. The Windows native addon was taken from the published rea-agents@6.7.0 tarball (sha512 verified), as the runner's error message suggests, since source checkouts do not include it.

npm run test:focused -- tests/boundary/cli/analysisViewCli.test.ts on base (fix stashed) — new test failed as expected; the file's first test ("authenticates an exact portable parent…") also hit the 30 s timeout on that cold run, unrelated to this change.
npm run test:focused -- tests/boundary/cli/analysisViewCli.test.ts with the fix — 21/21 passed (including the previously timed-out test).
npm run test:focused -- tests/boundary/cli/managedMemberSummaryCli.test.ts (also asserts on this command's help) — 10/10 passed.
npm run check:fast — passed (typecheck, lint).
npm run docs:check — passed; no generated changes.
node scripts/rea.mjs inspect-analysis-view --help — prints the new description above.

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable; Windows only locally.
Package or release metadata impact: none.
Security, privacy, process, or containment review: none affected.

Author readiness

Human owner: @AmmarJamil23

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6248 **Author:** [@AmmarJamil23](https://github.com/AmmarJamil23) **Created:** 10/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/analysis-view-cli-help` --- ### 📝 Commits (2) - [`a5143f8`](https://github.com/morluto/rea/commit/a5143f8ce1c23feed0325fbf8014ddc840a10ace) fix(cli): describe analysis-view parents through the shared contract - [`28fff89`](https://github.com/morluto/rea/commit/28fff899a089501bc9717147ff8153a8f7e05ca4) Merge remote-tracking branch 'upstream/main' into fix/analysis-view-cli-help ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cli/analysisViewCommands.ts` (+3 -1) 📝 `tests/boundary/cli/analysisViewCli.test.ts` (+12 -0) </details> ### 📄 Description ## Summary Fixes #6225. `rea inspect-analysis-view --help` described the command with its own hand-written list of Evidence families. That list drifted from the `inspect_analysis_view` contract and omitted parents the shared workflow accepts (Rust, IL2CPP metadata, model artifacts, GPU code objects, and also protobuf, qlog, Frida status and GDB/objdump command observations). The help now describes the command generally and defers the list to the contract that owns it. ## Problem and expected behavior Trigger: `node scripts/rea.mjs inspect-analysis-view --help`. The opening line ended in `... Dart AOT, web network capture or pcap Evidence JSON`, understating accepted inputs. Expected (per the issue): accurate general wording; an exhaustive list is not required. ## Change and scope The CLI and MCP adapters already share one input schema (`inspectAnalysisViewInputSchema`) and one service (`inspectAnalysisViewValidatedWithFiles`; see `src/application/analysisView/AnalysisViewService.ts`). The family list therefore has one owner: the `inspect_analysis_view` tool contract (`src/contracts/analysisViewToolContracts.ts`). Rather than adding the missing names to a second copy, which would drift again, the CLI description no longer enumerates families and points to that contract. Nothing else changes; the other help text, options and behavior are untouched. Contribution scope: ordinary documentation/usability fix within existing boundaries; maintainer scope decision not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: `inspect_analysis_view` tool contract (unchanged); CLI command description only. - Contribution scope fit and linked maintainer decision: not applicable (help-text fix). - CLI and MCP/tool-catalog contract: CLI help wording only; MCP tool description, schemas and catalog unchanged. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details: not applicable. - Generated metadata, package, or installation impact: none; `npm run docs:check` passed with no generated changes. - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage - Tests added or updated: `tests/boundary/cli/analysisViewCli.test.ts` — "describes accepted parents through the shared analysis-view contract" runs `inspect-analysis-view --help` through the CLI fixture and requires the help to reference `inspect_analysis_view`. - Base reproduction: with the source change stashed, the new test failed with `expected 'rea inspect-analysis-view — Project a…' to contain 'inspect_analysis_view'` (received the old family list). With the change, it passes. - User-visible CLI output (after): ```text rea inspect-analysis-view — Project a selected view of completed analysis Evidence JSON without repeating the analysis; accepts the same parent Evidence and views as the inspect_analysis_view MCP tool ``` - Remaining proof gaps: the claim that the CLI accepts the same parents and views as MCP is source-derived (shared schema and service), not re-executed per family in this PR. ## Validation performed Windows 11 x64, Node.js 24.18.0 (pinned), `npm ci` with locked dependencies. The Windows native addon was taken from the published `rea-agents@6.7.0` tarball (sha512 verified), as the runner's error message suggests, since source checkouts do not include it. - `npm run test:focused -- tests/boundary/cli/analysisViewCli.test.ts` on base (fix stashed) — new test failed as expected; the file's first test ("authenticates an exact portable parent…") also hit the 30 s timeout on that cold run, unrelated to this change. - `npm run test:focused -- tests/boundary/cli/analysisViewCli.test.ts` with the fix — 21/21 passed (including the previously timed-out test). - `npm run test:focused -- tests/boundary/cli/managedMemberSummaryCli.test.ts` (also asserts on this command's help) — 10/10 passed. - `npm run check:fast` — passed (typecheck, lint). - `npm run docs:check` — passed; no generated changes. - `node scripts/rea.mjs inspect-analysis-view --help` — prints the new description above. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable; Windows only locally. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none affected. ## Author readiness Human owner: @AmmarJamil23 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:19 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-03 13:39:57 +00:00

[PR #7225] [MERGED] fix(har): accept Chrome DevTools bracketed IPv6 server addresses #7728

bsakaguchi changed title from ~~[PR #6248] [CLOSED] fix(cli): describe analysis-view parents through the shared contract~~ to [PR #6248] fix(cli): describe analysis-view parents through the shared contract

2026-11-03 15:41:38 +00:00

bsakaguchi changed title from ~~[PR #6248] fix(cli): describe analysis-view parents through the shared contract~~ to [PR #6248] [CLOSED] fix(cli): describe analysis-view parents through the shared contract

2026-11-03 16:43:08 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7225

No description provided.

Rows
Columns