morluto/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00
Code Issues 1.3k Projects Packages Wiki Activity

[PR #6253] [MERGED] fix(doctor): check only the current platform's Hopper launcher candidates #7228

New issue
Closed
opened 2026-11-01 21:46:19 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-11-01 21:46:19 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6253
Author: @SandstromPL
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/23/2026
Merged by: @baron

Base: main ← Head: fix/doctor-hopper-platform-candidates

📝 Commits (5)

  • 0151bdc fix(doctor): check only the current platform's Hopper launcher candidates
  • 5ffad47 fix(doctor): keep the renamed Hopper bundle scan asynchronous
  • 1cce496 Merge upstream/main into fix/doctor-hopper-platform-candidates
  • 85c57a6 Merge upstream/main into fix/doctor-hopper-platform-candidates
  • 4dab6bc test(doctor): model renamed launchers with runtime's POSIX joins

📊 Changes

9 files changed (+205 additions, -105 deletions)

View changed files

📝 docs/installation.md (+3 -1)
📝 src/application/Doctor.test.ts (+84 -10)
📝 src/application/Doctor.ts (+6 -25)
📝 src/application/DoctorDiagnostics.ts (+10 -30)
➕ src/application/HopperLauncherDiscovery.ts (+49 -0)
📝 src/application/LinuxHopper.ts (+1 -1)
📝 src/application/MacHopperPaths.test.ts (+15 -12)
📝 src/application/MacHopperPaths.ts (+27 -9)
📝 src/config/parseConfig.ts (+10 -17)

📄 Description

Summary

Fixes #6228.

With no HOPPER_LAUNCHER_PATH, rea doctor built one launcher list for every platform. On macOS that list included the Linux system paths /opt/hopper-v4/bin/hopper and /usr/bin/hopper, ahead of renamed Hopper*.app bundles. On Linux it included the macOS system application and ~/Applications bundles. Runtime discovery (defaultHopperLauncherPath) already checked only the current platform. As a result:

  • Doctor could report a Linux-only path as a healthy Hopper on macOS.
  • That path won over a valid renamed bundle that runtime would select.
  • Setup trusts doctor's hopperPath: it writes it into client registrations as HOPPER_LAUNCHER_PATH and treats Hopper as configured. So setup could register that Linux path on macOS and stop offering a Hopper install.

After this change, doctor and runtime read one per-platform owner. Doctor checks only the current platform's candidates, in runtime's order.

Problem and expected behavior

  • Smallest trigger (from the issue): macOS, no override, no canonical application, /opt/hopper-v4/bin/hopper executable. Doctor reported that path with healthy: true, while runtime selected its macOS fallback. When a renamed bundle was also present, doctor still returned the Linux path while runtime selected the bundle.
  • Violated invariant: docs/installation.md defines the automatic launcher order separately for macOS and Linux. Doctor is the readiness check for the launcher CLI/MCP startup uses.

Change and scope

  • New owner, src/application/HopperLauncherDiscovery.ts: hopperLauncherDiscovery(platform, home) returns, for one platform:
    • the fixed candidates, probed in order;
    • whether renamed macOS bundles are probed afterwards (probesMacApplicationBundles);
    • the runtime fallback.
  • What each platform gets:
    • macOS: the canonical system and ~/Applications launchers, then renamed bundles. Fallback: the system launcher.
    • Linux: linuxHopperLauncherCandidates. Fallback: the REA-managed /opt/hopper/bin/Hopper.
    • Other platforms: no automatic candidates. Runtime keeps its existing fallback.
  • Runtime: defaultHopperLauncherPath (src/config/parseConfig.ts) reads the owner. Its selections are unchanged on every platform.
  • Doctor: findHopper (src/application/DoctorDiagnostics.ts) reads the owner too.
    • A configured HOPPER_LAUNCHER_PATH is still checked alone.
    • Otherwise doctor probes the fixed candidates, then, on macOS only, renamed bundles and then the Homebrew cask application.
    • Renamed bundles are now scanned only after the fixed candidates fail.
    • The Homebrew probe no longer runs on Linux or Windows. The hopper-disassembler cask is macOS-only, and the docs already describe it as a macOS doctor diagnostic.
  • Removed duplication:
    • MacHopperPaths.ts now owns both renamed-bundle scans: the lazy synchronous generator runtime needs (localMacHopperRenamedLauncherCandidates), and the asynchronous readMacHopperRenamedLauncherCandidates the production doctor host uses, so doctor never blocks the event loop on a slow ~/Applications. Both share the directory filter and macHopperRenamedLauncherCandidates, so the naming and ordering rules have one owner. Doctor's separate scan in Doctor.ts is deleted.
    • macHopperLauncherCandidates, the canonical-plus-renamed generator, is replaced by the renamed-only generator. The redundant name filter in its directory read is dropped.
    • systemLinuxHopperLauncherCandidates is no longer exported. Only doctor's cross-platform list used it from outside.
  • Docs: docs/installation.md now says doctor checks only the current platform's candidates, in the same order, and that other platforms have no automatic candidates.
  • Remaining related cleanup, intentionally not included:
    • Linux executability still differs. On Linux, doctor's executable check also runs ldd and rejects launchers with missing shared libraries; runtime checks only that the file is executable and a regular file. If /opt/hopper/bin/Hopper is missing a library and /usr/bin/hopper is fine, doctor reports /usr/bin/hopper while runtime selects /opt/hopper/bin/Hopper. This existed before; fixing it means choosing one executability rule for both, so it belongs in a separate change.
    • Windows remediation. On Windows, doctor's Hopper remediation still says "Run rea setup to install Hopper", although HopperProvider reports unsupported_host there.

Contribution scope: an ordinary fix within existing doctor and launcher-discovery boundaries, so a maintainer scope decision is not applicable.

Contract and boundary impact

  • Semantic owner and earliest changed stage: hopperLauncherDiscovery in src/application/HopperLauncherDiscovery.ts, consumed by runtime configuration and doctor discovery.
  • Contribution scope fit and linked maintainer decision: routine fix; not applicable.
  • CLI and MCP/tool-catalog contract: no flag, schema or catalog change.
    • rea doctor may now report no Hopper (missing_analysis_engine) where it previously reported another platform's path as healthy.
    • On macOS, a valid renamed bundle now wins over a Linux path.
  • Provider, bridge, target-format, or platform compatibility:
    • Runtime launcher selection is unchanged.
    • Doctor discovery changes on every platform, as described above.
    • Setup follows doctor: on macOS, a launcher at a Linux-only path is no longer written into client registrations, and setup can offer a Hopper install there again.
  • Evidence, artifact, provenance, or reconstruction contract: none.
  • Target selection, authority, upstream behavior, and cleanup details: doctor runs fewer probes: no renamed-bundle scan when a canonical launcher exists, and no Homebrew process on Linux or Windows. No new probes.
  • Generated metadata, package, or installation impact: none.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data. (doctor's existing launcher-path probes and application-directory listing)
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated:
    • src/application/Doctor.test.ts, new describe("doctor Hopper discovery matches runtime selection"): a 7-row table using the doctor host fixture with modeled executables, and a per-case temporary home holding a real Applications/Hopper 5.app directory for runtime's scan. Each row asserts:
      • doctor's hopperPath;
      • that it equals runtime's selection whenever that selection is executable;
      • how many renamed-bundle scans and Homebrew probes ran;
      • missing_analysis_engine when nothing is found.
    • Rows:
      • macOS, Linux path only: none.
      • macOS, Linux path plus renamed bundle: the renamed bundle.
      • macOS, Linux path plus canonical launcher: canonical.
      • macOS, renamed bundle plus canonical launcher: canonical, with no bundle scan.
      • Linux, macOS paths only: none.
      • Linux, macOS plus Linux paths: the Linux path.
      • Windows: nothing probed.
    • Removed: "detects a manually installed Hopper application" duplicated the macOS renamed-bundle row.
    • src/application/MacHopperPaths.test.ts: a real temporary home checks that runtime's synchronous scan and doctor's asynchronous scan return the same candidates: a renamed bundle is kept, while the canonical name and a non-directory Hopper*.app are skipped. The deleted canonical-membership check is still covered by the canonical-candidates test.
  • Base reproduction (executed): with only the source files reverted to bd5d189a8, all 7 new rows fail.
    • The two macOS cases from the issue get /opt/hopper-v4/bin/hopper.
    • The Linux and Windows rows get the macOS system launcher.
    • The two canonical macOS rows fail only on the scan count, because the base scanned renamed bundles eagerly.
  • User-visible CLI/MCP output: for the issue's macOS Linux-path-only case, the hopper check changes from ok: true, classification: "healthy", detail: "/opt/hopper-v4/bin/hopper" to ok: false with classification: "missing_analysis_engine". This is asserted at service level, not from a CLI run.
  • Remaining proof gaps:
    • No real macOS or Windows host; platforms are modeled through the doctor host fixture.
    • No real Hopper installation or launch.
    • Performance was not measured. The only cost change is fewer probes.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Run on Linux with Node 24.18.0 and npm 11.16.0, on bd5d189a8:

  • npm run test:local -- on Doctor, Doctor.*, all Setup* service tests, MacHopperPaths, LinuxHopper, config, GhidraDoctor and doctorRuntime: 12 files, 277 tests passed.
  • npm run test:focused -- tests/boundary/filesystem/hopperLauncherSelection.test.ts tests/boundary/cli/doctorHopperDiscovery.test.ts tests/boundary/filesystem/doctorSystemHostFilesystem.test.ts tests/boundary/cli/setupProviderReadiness.test.ts tests/boundary/filesystem/setupUnavailableProvider.test.ts tests/boundary/cli/cliSetup.test.ts tests/boundary/filesystem/setupConfig.test.ts: 7 files, 49 tests passed.
  • After keeping doctor's scan asynchronous (Greptile review): the same unit set, 12 files, 277 tests passed; the first five boundary files above, 15 tests passed; npm run check:fast passed.
  • After merging upstream/main at 4043e71f6 (merge commit 1cce496f6): the same unit set, 12 files, 278 tests passed; the seven boundary files above, 50 tests passed; npx tsc --noEmit -p ., npm run check:fast and npm run docs:check passed; npm run verify:test-discovery discovered all 2020 test files exactly once.
  • CI on 5ffad47e1 failed only in the Windows capability lane: tests/acceptance/webModuleCli.test.ts exceeded its 15000 ms process deadline after printing its complete result. That test traces web modules and does not touch files in this PR; the same lane passed on 0151bdc56. This push reruns CI.
  • CI on 1cce496f6 passed, including the Windows lane.
  • After merging upstream/main at 9eb829aca, conflicts with #3422 (Linux architecture gate) and #5235 (POSIX joins in MacHopperPaths.ts) were resolved: MacHopperPaths.ts keeps both renamed-bundle scans on posix.join, DoctorDiagnostics.ts keeps the shared owner plus #3422's LINUX_HOPPER_SETUP_HOSTS, and the scan agreement test now uses #5235's Windows-safe temporary home.
    • The same unit set: 12 files, 313 tests passed. The seven boundary files above: 51 tests passed.
    • npx tsc --noEmit -p ., npm run check:fast and npm run docs:check passed; npm run verify:test-discovery discovered all 2105 test files exactly once.
  • Greptile follow-up (4dab6bc9f): the doctor discovery table now models launchers with posix.join, matching runtime since #5235, while filesystem setup stays native. Doctor, Doctor.*, MacHopperPaths and config tests: 4 files, 148 tests passed; npm run check:fast passed. The modeled and runtime launcher strings were checked to agree for drive-letter, UNC and POSIX homes; the table was not run on Windows locally.
  • npm run test:local -- src/application/Doctor.test.ts with only the source files reverted: 7 failed (the new rows), 59 passed.
  • npx tsc --noEmit -p .: clean.
  • npm run check:fast (typecheck and lint): passed.
    • npx oxlint on the changed files: 0 errors.
    • Doctor.ts and LinuxHopper.ts keep their existing size and complexity warnings. Doctor.ts shrinks from 746 to 727 lines; systemDoctorHost grows from 225 to 226 lines.
  • npm run docs:check: passed.
  • npm run verify:test-discovery: discovered all 1971 test files exactly once.
  • npx oxfmt --check on the changed files and git diff --check: clean.
  • Not run: npm run check:pr, real Hopper or macOS/Windows verification.

Compatibility, safety, and release

  • Breaking changes or migration steps: none. Runtime selection is unchanged. Doctor stops reporting another platform's launcher; users relying on such a path can set HOPPER_LAUNCHER_PATH, which doctor still checks as given.
  • Real Hopper/Ghidra, browser, or OS coverage: Linux only; macOS and Windows behavior is modeled with the doctor host fixture.
  • Package or release metadata impact: none.
  • Security, privacy, process, or containment review: doctor runs fewer filesystem probes and no Homebrew process on Linux or Windows. Nothing new is executed or written.

Author readiness

Human owner: @SandstromPL

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6253 **Author:** [@SandstromPL](https://github.com/SandstromPL) **Created:** 10/22/2026 **Status:** ✅ Merged **Merged:** 10/23/2026 **Merged by:** [@baron](https://github.com/baron) **Base:** `main` ← **Head:** `fix/doctor-hopper-platform-candidates` --- ### 📝 Commits (5) - [`0151bdc`](https://github.com/morluto/rea/commit/0151bdc56b544e1d3a07b6e0646f0a04db07340b) fix(doctor): check only the current platform's Hopper launcher candidates - [`5ffad47`](https://github.com/morluto/rea/commit/5ffad47e16cba56de5d2ef2107176c74932b081e) fix(doctor): keep the renamed Hopper bundle scan asynchronous - [`1cce496`](https://github.com/morluto/rea/commit/1cce496f6a858fe2ebf491c9ab4c4e619ec5fb2c) Merge upstream/main into fix/doctor-hopper-platform-candidates - [`85c57a6`](https://github.com/morluto/rea/commit/85c57a659aaf82101e4cb9be34b3de331bfbc655) Merge upstream/main into fix/doctor-hopper-platform-candidates - [`4dab6bc`](https://github.com/morluto/rea/commit/4dab6bc9f3c8dc8b761559c46b56a446cd20ac0d) test(doctor): model renamed launchers with runtime's POSIX joins ### 📊 Changes **9 files changed** (+205 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `docs/installation.md` (+3 -1) 📝 `src/application/Doctor.test.ts` (+84 -10) 📝 `src/application/Doctor.ts` (+6 -25) 📝 `src/application/DoctorDiagnostics.ts` (+10 -30) ➕ `src/application/HopperLauncherDiscovery.ts` (+49 -0) 📝 `src/application/LinuxHopper.ts` (+1 -1) 📝 `src/application/MacHopperPaths.test.ts` (+15 -12) 📝 `src/application/MacHopperPaths.ts` (+27 -9) 📝 `src/config/parseConfig.ts` (+10 -17) </details> ### 📄 Description ## Summary Fixes #6228. With no `HOPPER_LAUNCHER_PATH`, `rea doctor` built one launcher list for every platform. On macOS that list included the Linux system paths `/opt/hopper-v4/bin/hopper` and `/usr/bin/hopper`, ahead of renamed `Hopper*.app` bundles. On Linux it included the macOS system application and `~/Applications` bundles. Runtime discovery (`defaultHopperLauncherPath`) already checked only the current platform. As a result: - Doctor could report a Linux-only path as a healthy Hopper on macOS. - That path won over a valid renamed bundle that runtime would select. - Setup trusts doctor's `hopperPath`: it writes it into client registrations as `HOPPER_LAUNCHER_PATH` and treats Hopper as configured. So setup could register that Linux path on macOS and stop offering a Hopper install. After this change, doctor and runtime read one per-platform owner. Doctor checks only the current platform's candidates, in runtime's order. ## Problem and expected behavior - **Smallest trigger (from the issue):** macOS, no override, no canonical application, `/opt/hopper-v4/bin/hopper` executable. Doctor reported that path with `healthy: true`, while runtime selected its macOS fallback. When a renamed bundle was also present, doctor still returned the Linux path while runtime selected the bundle. - **Violated invariant:** `docs/installation.md` defines the automatic launcher order separately for macOS and Linux. Doctor is the readiness check for the launcher CLI/MCP startup uses. ## Change and scope - **New owner, `src/application/HopperLauncherDiscovery.ts`:** `hopperLauncherDiscovery(platform, home)` returns, for one platform: - the fixed candidates, probed in order; - whether renamed macOS bundles are probed afterwards (`probesMacApplicationBundles`); - the runtime fallback. - **What each platform gets:** - **macOS:** the canonical system and `~/Applications` launchers, then renamed bundles. Fallback: the system launcher. - **Linux:** `linuxHopperLauncherCandidates`. Fallback: the REA-managed `/opt/hopper/bin/Hopper`. - **Other platforms:** no automatic candidates. Runtime keeps its existing fallback. - **Runtime:** `defaultHopperLauncherPath` (`src/config/parseConfig.ts`) reads the owner. Its selections are unchanged on every platform. - **Doctor:** `findHopper` (`src/application/DoctorDiagnostics.ts`) reads the owner too. - A configured `HOPPER_LAUNCHER_PATH` is still checked alone. - Otherwise doctor probes the fixed candidates, then, on macOS only, renamed bundles and then the Homebrew cask application. - Renamed bundles are now scanned only after the fixed candidates fail. - The Homebrew probe no longer runs on Linux or Windows. The `hopper-disassembler` cask is macOS-only, and the docs already describe it as a macOS doctor diagnostic. - **Removed duplication:** - `MacHopperPaths.ts` now owns both renamed-bundle scans: the lazy synchronous generator runtime needs (`localMacHopperRenamedLauncherCandidates`), and the asynchronous `readMacHopperRenamedLauncherCandidates` the production doctor host uses, so doctor never blocks the event loop on a slow `~/Applications`. Both share the directory filter and `macHopperRenamedLauncherCandidates`, so the naming and ordering rules have one owner. Doctor's separate scan in `Doctor.ts` is deleted. - `macHopperLauncherCandidates`, the canonical-plus-renamed generator, is replaced by the renamed-only generator. The redundant name filter in its directory read is dropped. - `systemLinuxHopperLauncherCandidates` is no longer exported. Only doctor's cross-platform list used it from outside. - **Docs:** `docs/installation.md` now says doctor checks only the current platform's candidates, in the same order, and that other platforms have no automatic candidates. - **Remaining related cleanup, intentionally not included:** - **Linux executability still differs.** On Linux, doctor's `executable` check also runs `ldd` and rejects launchers with missing shared libraries; runtime checks only that the file is executable and a regular file. If `/opt/hopper/bin/Hopper` is missing a library and `/usr/bin/hopper` is fine, doctor reports `/usr/bin/hopper` while runtime selects `/opt/hopper/bin/Hopper`. This existed before; fixing it means choosing one executability rule for both, so it belongs in a separate change. - **Windows remediation.** On Windows, doctor's Hopper remediation still says "Run rea setup to install Hopper", although `HopperProvider` reports `unsupported_host` there. Contribution scope: an ordinary fix within existing doctor and launcher-discovery boundaries, so a maintainer scope decision is not applicable. ## Contract and boundary impact - **Semantic owner and earliest changed stage:** `hopperLauncherDiscovery` in `src/application/HopperLauncherDiscovery.ts`, consumed by runtime configuration and doctor discovery. - **Contribution scope fit and linked maintainer decision:** routine fix; not applicable. - **CLI and MCP/tool-catalog contract:** no flag, schema or catalog change. - `rea doctor` may now report no Hopper (`missing_analysis_engine`) where it previously reported another platform's path as healthy. - On macOS, a valid renamed bundle now wins over a Linux path. - **Provider, bridge, target-format, or platform compatibility:** - Runtime launcher selection is unchanged. - Doctor discovery changes on every platform, as described above. - Setup follows doctor: on macOS, a launcher at a Linux-only path is no longer written into client registrations, and setup can offer a Hopper install there again. - **Evidence, artifact, provenance, or reconstruction contract:** none. - **Target selection, authority, upstream behavior, and cleanup details:** doctor runs fewer probes: no renamed-bundle scan when a canonical launcher exists, and no Homebrew process on Linux or Windows. No new probes. - **Generated metadata, package, or installation impact:** none. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [x] Read existing files or captured data. (doctor's existing launcher-path probes and application-directory listing) - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - **Tests added or updated:** - **`src/application/Doctor.test.ts`, new `describe("doctor Hopper discovery matches runtime selection")`:** a 7-row table using the doctor host fixture with modeled executables, and a per-case temporary home holding a real `Applications/Hopper 5.app` directory for runtime's scan. Each row asserts: - doctor's `hopperPath`; - that it equals runtime's selection whenever that selection is executable; - how many renamed-bundle scans and Homebrew probes ran; - `missing_analysis_engine` when nothing is found. - **Rows:** - macOS, Linux path only: none. - macOS, Linux path plus renamed bundle: the renamed bundle. - macOS, Linux path plus canonical launcher: canonical. - macOS, renamed bundle plus canonical launcher: canonical, with no bundle scan. - Linux, macOS paths only: none. - Linux, macOS plus Linux paths: the Linux path. - Windows: nothing probed. - **Removed:** "detects a manually installed Hopper application" duplicated the macOS renamed-bundle row. - **`src/application/MacHopperPaths.test.ts`:** a real temporary home checks that runtime's synchronous scan and doctor's asynchronous scan return the same candidates: a renamed bundle is kept, while the canonical name and a non-directory `Hopper*.app` are skipped. The deleted canonical-membership check is still covered by the canonical-candidates test. - **Base reproduction (executed):** with only the source files reverted to `bd5d189a8`, all 7 new rows fail. - The two macOS cases from the issue get `/opt/hopper-v4/bin/hopper`. - The Linux and Windows rows get the macOS system launcher. - The two canonical macOS rows fail only on the scan count, because the base scanned renamed bundles eagerly. - **User-visible CLI/MCP output:** for the issue's macOS Linux-path-only case, the `hopper` check changes from `ok: true`, `classification: "healthy"`, `detail: "/opt/hopper-v4/bin/hopper"` to `ok: false` with `classification: "missing_analysis_engine"`. This is asserted at service level, not from a CLI run. - **Remaining proof gaps:** - No real macOS or Windows host; platforms are modeled through the doctor host fixture. - No real Hopper installation or launch. - Performance was not measured. The only cost change is fewer probes. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Run on Linux with Node 24.18.0 and npm 11.16.0, on `bd5d189a8`: - `npm run test:local --` on `Doctor`, `Doctor.*`, all `Setup*` service tests, `MacHopperPaths`, `LinuxHopper`, `config`, `GhidraDoctor` and `doctorRuntime`: 12 files, 277 tests passed. - `npm run test:focused -- tests/boundary/filesystem/hopperLauncherSelection.test.ts tests/boundary/cli/doctorHopperDiscovery.test.ts tests/boundary/filesystem/doctorSystemHostFilesystem.test.ts tests/boundary/cli/setupProviderReadiness.test.ts tests/boundary/filesystem/setupUnavailableProvider.test.ts tests/boundary/cli/cliSetup.test.ts tests/boundary/filesystem/setupConfig.test.ts`: 7 files, 49 tests passed. - After keeping doctor's scan asynchronous (Greptile review): the same unit set, 12 files, 277 tests passed; the first five boundary files above, 15 tests passed; `npm run check:fast` passed. - After merging `upstream/main` at `4043e71f6` (merge commit `1cce496f6`): the same unit set, 12 files, 278 tests passed; the seven boundary files above, 50 tests passed; `npx tsc --noEmit -p .`, `npm run check:fast` and `npm run docs:check` passed; `npm run verify:test-discovery` discovered all 2020 test files exactly once. - CI on `5ffad47e1` failed only in the Windows capability lane: `tests/acceptance/webModuleCli.test.ts` exceeded its 15000 ms process deadline after printing its complete result. That test traces web modules and does not touch files in this PR; the same lane passed on `0151bdc56`. This push reruns CI. - CI on `1cce496f6` passed, including the Windows lane. - After merging `upstream/main` at `9eb829aca`, conflicts with #3422 (Linux architecture gate) and #5235 (POSIX joins in `MacHopperPaths.ts`) were resolved: `MacHopperPaths.ts` keeps both renamed-bundle scans on `posix.join`, `DoctorDiagnostics.ts` keeps the shared owner plus #3422's `LINUX_HOPPER_SETUP_HOSTS`, and the scan agreement test now uses #5235's Windows-safe temporary home. - The same unit set: 12 files, 313 tests passed. The seven boundary files above: 51 tests passed. - `npx tsc --noEmit -p .`, `npm run check:fast` and `npm run docs:check` passed; `npm run verify:test-discovery` discovered all 2105 test files exactly once. - Greptile follow-up (`4dab6bc9f`): the doctor discovery table now models launchers with `posix.join`, matching runtime since #5235, while filesystem setup stays native. `Doctor`, `Doctor.*`, `MacHopperPaths` and `config` tests: 4 files, 148 tests passed; `npm run check:fast` passed. The modeled and runtime launcher strings were checked to agree for drive-letter, UNC and POSIX homes; the table was not run on Windows locally. - `npm run test:local -- src/application/Doctor.test.ts` with only the source files reverted: 7 failed (the new rows), 59 passed. - `npx tsc --noEmit -p .`: clean. - `npm run check:fast` (typecheck and lint): passed. - `npx oxlint` on the changed files: 0 errors. - `Doctor.ts` and `LinuxHopper.ts` keep their existing size and complexity warnings. `Doctor.ts` shrinks from 746 to 727 lines; `systemDoctorHost` grows from 225 to 226 lines. - `npm run docs:check`: passed. - `npm run verify:test-discovery`: discovered all 1971 test files exactly once. - `npx oxfmt --check` on the changed files and `git diff --check`: clean. - Not run: `npm run check:pr`, real Hopper or macOS/Windows verification. ## Compatibility, safety, and release - **Breaking changes or migration steps:** none. Runtime selection is unchanged. Doctor stops reporting another platform's launcher; users relying on such a path can set `HOPPER_LAUNCHER_PATH`, which doctor still checks as given. - **Real Hopper/Ghidra, browser, or OS coverage:** Linux only; macOS and Windows behavior is modeled with the doctor host fixture. - **Package or release metadata impact:** none. - **Security, privacy, process, or containment review:** doctor runs fewer filesystem probes and no Homebrew process on Linux or Windows. Nothing new is executed or written. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @SandstromPL - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:46:19 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels   
area: bridge

   
area: bridge

   
area: build

   
area: build

   
area: build

   
area: cli

   
area: domain

   
area: evidence

   
area: mcp

   
area: native

   
area: providers

   
area: runtime

   
area: server

   
area: setup

   
area: tests

   
bug

   
design

   
documentation

   
enhancement

   
enhancement

   
enhancement

   
experiment

   
help wanted

   
i18n

   
invalid

   
P0: critical

   
P1: high

   
P2: medium

   
P2: medium

   
P2: medium

   
P3: low

   
performance

   
provider-request

   
pull-request
Mirrored from GitHub Pull Request

  
question

   
roadmap

   
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#7228
No description provided.