[PR #6317] [CLOSED] fix(artifacts): include table index in CArchive TOC entry diagnostics #7278

New issue

Closed

opened 2026-11-01 21:46:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6317
Author: @genius-0963
Created: 10/22/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

9a18b91 fix(artifacts): include table index in CArchive TOC entry diagnostics

📊 Changes

1 file changed (+19 additions, -8 deletions)

View changed files

📝 src/artifacts/pyinstaller/CArchiveLayout.ts (+19 -8)

📄 Description

Summary

Fixes #6312 by including the table index in all CArchive TOC entry validation error messages.

Problem

Malformed CArchive TOC diagnostics were missing the TOC entry index, making it difficult to identify which entry is malformed. The error messages for compression-flag, type-code, truncation, and name validation errors all omitted the entry index.

Solution

Modified src/artifacts/pyinstaller/CArchiveLayout.ts to include the table index in all parse-time TOC entry validation error messages:

Compression flag validation
Type code validation
Entry truncation validation
Entry extends outside table validation
Name validation (added index parameter to tocName function)

This is consistent with existing integrity validation in validateCArchiveMembers which already includes table indices in its error messages.

Test plan

Reproduction test from issue #6312 passed (valid control + 3 corrupted indices with correct table index in error messages)
All PyInstaller unit tests passed (63 tests)
Typecheck and lint passed

Generated with Devin

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6317 **Author:** [@genius-0963](https://github.com/genius-0963) **Created:** 10/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`9a18b91`](https://github.com/morluto/rea/commit/9a18b912002b6ce50255ee2758f5a982aac9aca5) fix(artifacts): include table index in CArchive TOC entry diagnostics ### 📊 Changes **1 file changed** (+19 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/artifacts/pyinstaller/CArchiveLayout.ts` (+19 -8) </details> ### 📄 Description ## Summary Fixes #6312 by including the table index in all CArchive TOC entry validation error messages. ## Problem Malformed CArchive TOC diagnostics were missing the TOC entry index, making it difficult to identify which entry is malformed. The error messages for compression-flag, type-code, truncation, and name validation errors all omitted the entry index. ## Solution Modified `src/artifacts/pyinstaller/CArchiveLayout.ts` to include the table index in all parse-time TOC entry validation error messages: - Compression flag validation - Type code validation - Entry truncation validation - Entry extends outside table validation - Name validation (added index parameter to `tocName` function) This is consistent with existing integrity validation in `validateCArchiveMembers` which already includes table indices in its error messages. ## Test plan - Reproduction test from issue #6312 passed (valid control + 3 corrupted indices with correct table index in error messages) - All PyInstaller unit tests passed (63 tests) - Typecheck and lint passed Generated with [Devin](https://devin.ai) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:42 +00:00