[PR #6355] [CLOSED] fix(doctor): ignore Linux Hopper launcher candidates on macOS #7300

New issue

Closed

opened 2026-11-01 21:46:52 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:46:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6355
Author: @dezzy-music
Created: 10/22/2026
Status: ❌ Closed

Base: main ← Head: fix/doctor-macos-hopper-linux-candidates

📝 Commits (1)

b4401b9 fix(doctor): ignore Linux Hopper launcher candidates on macOS

📊 Changes

2 files changed (+57 additions, -13 deletions)

View changed files

📝 src/application/Doctor.test.ts (+41 -0)
📝 src/application/DoctorDiagnostics.ts (+16 -13)

📄 Description

Summary

Resolves #6228.

On macOS with no explicit launcher override (HOPPER_LAUNCHER_PATH unset), rea doctor --provider hopper previously considered Linux system launcher candidates (systemLinuxHopperLauncherCandidates, e.g. /opt/hopper-v4/bin/hopper), checking them before renamed macOS bundles (manualHopperPaths()). This could report a Linux-only path as healthy on macOS or displace an eligible renamed macOS bundle.

Changes

In src/application/DoctorDiagnostics.ts, scoped automatic Hopper candidate discovery in findHopper strictly by host platform: on darwin, only macOS canonical candidates and renamed bundles are probed; on linux, Linux home and system candidates are probed.
Added unit tests in src/application/Doctor.test.ts verifying that Linux-only launcher candidates are ignored on macOS (reporting missing analysis engine) and that renamed macOS bundles are preferred over Linux paths on macOS.

Verification

Targeted Vitest suite in src/application/Doctor.test.ts passed (2/2 green).
node scripts/run-turbo.mjs run typecheck lint passed cleanly with 0 errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6355 **Author:** [@dezzy-music](https://github.com/dezzy-music) **Created:** 10/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/doctor-macos-hopper-linux-candidates` --- ### 📝 Commits (1) - [`b4401b9`](https://github.com/morluto/rea/commit/b4401b99509f793e26d42aac8866e7d48b62e617) fix(doctor): ignore Linux Hopper launcher candidates on macOS ### 📊 Changes **2 files changed** (+57 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/application/Doctor.test.ts` (+41 -0) 📝 `src/application/DoctorDiagnostics.ts` (+16 -13) </details> ### 📄 Description ### Summary Resolves #6228. On macOS with no explicit launcher override (`HOPPER_LAUNCHER_PATH` unset), `rea doctor --provider hopper` previously considered Linux system launcher candidates (`systemLinuxHopperLauncherCandidates`, e.g. `/opt/hopper-v4/bin/hopper`), checking them before renamed macOS bundles (`manualHopperPaths()`). This could report a Linux-only path as healthy on macOS or displace an eligible renamed macOS bundle. ### Changes - In `src/application/DoctorDiagnostics.ts`, scoped automatic Hopper candidate discovery in `findHopper` strictly by host platform: on `darwin`, only macOS canonical candidates and renamed bundles are probed; on `linux`, Linux home and system candidates are probed. - Added unit tests in `src/application/Doctor.test.ts` verifying that Linux-only launcher candidates are ignored on macOS (reporting missing analysis engine) and that renamed macOS bundles are preferred over Linux paths on macOS. ### Verification - Targeted Vitest suite in `src/application/Doctor.test.ts` passed (2/2 green). - `node scripts/run-turbo.mjs run typecheck lint` passed cleanly with 0 errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:46:52 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7300

No description provided.

Rows
Columns