mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #6353] [MERGED] fix(mcp): escalate transient failures before asking for a restart #7302
Closed
opened 2026-11-01 21:46:53 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7302
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6353
Author: @morluto
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto
Base:
main← Head:cursor/agent-recovery-ladder-f397📝 Commits (5)
b371f28fix(mcp): escalate transient failures before asking for a restartcfdbf6afix(process): stop unexpected command failures from recommending a retry999378ffix(mcp): limit retries to safe calls and recommended settings1c55530test(mcp): match recovery guidance across wrapped lines367b004merge(main): take the shared cancellation contract📊 Changes
15 files changed (+233 additions, -44 deletions)
View changed files
📝
.agents/skills/reverse-engineer-anything/SKILL.md(+9 -1)📝
.agents/skills/reverse-engineer-anything/references/connection-and-recovery.md(+16 -10)📝
docs/mcp-contracts.md(+9 -5)📝
docs/user-visible-errors.csv(+5 -5)📝
scripts/lib/test-projects.mjs(+1 -1)📝
src/application/process/ProcessCli.ts(+8 -0)📝
src/domain/analysisErrorProjection.test.ts(+1 -1)📝
src/generatedPackageMetadata.ts(+1 -1)➕
src/main/messages.test.ts(+150 -0)📝
src/main/messages.ts(+3 -3)📝
src/server/createServer.ts(+1 -1)📝
tests/boundary/filesystem/processCliFileInput.test.ts(+6 -0)📝
tests/boundary/mcp/deferredRuntime.test.ts(+1 -3)📝
tests/boundary/mcp/javascriptAnalysisResources.test.ts(+11 -0)📝
tests/boundary/mcp/mainErrors.test.ts(+11 -13)📄 Description
Summary
Transient MCP failures tell an agent when one retry is safe, then to tell the user and ask them to restart the MCP client. A dropped connection is retried only when the call is safe to repeat or known not to have started. Startup that can reject the same bytes every time does not ask for a retry. A setting changes only when the returned remediation explicitly recommends that change.
No linked issue. This aligns agent-facing recovery copy with the current settings; it does not change a reported defect's reproduction.
Problem and expected behavior
Dropped MCP connections and startup failures only said to restart REA or run
rea doctor. Agents had no bounded retry and no scripted handoff to the user. The timeout catalog still said to reduce work without assuming adjustable limits, even where a producer namesanalysis_timeout_msor aREA_*setting.A dropped connection can return after the tool has already changed the target, so the retry is limited to a call that is safe to repeat or known not to have started. Otherwise the agent tells the user REA lost its MCP client connection and asks them to restart the MCP client. A connection that never started still retries once, then uses that handoff and
rea doctor. Server startup, including a catalog the same bytes will reject again, does not repeat: tell the user REA could not start, restart the MCP client, then runrea doctor.An unexpected process command does not use that retry. The catch can already have launched the target, and the projection stays
retryable: false. Its remediation tells the user the command could not complete, asks them to check the input files, and namesrea doctor.Timeout guidance changes a request field or
REA_*setting only when the remediation explicitly recommends that change. A mention that a control does not raise the deadline, such as the Wakaru recovery note aboutanalysis_timeout_msandmax_heap_mb, is not a recommendation.Change and scope
The ladder lives in the stderr constants, MCP initialization instructions, and the shipped skill.
rea doctoris included only when startup can be diagnosed. A lost connection does not name doctor, because doctor cannot restore that connection.Shutdown and HTTP listen failures keep their existing named fixes. A failed close must end the process before another start, and a port conflict is fixed by choosing another port. Hopper
close_binaryrecoveries and ceiling dial catalogs (captureDecoderHeapRecovery,mcpPhaseBudgetRecovery, and the other effective-value helpers) are unchanged.Generic
AnalysisTimeoutErrortext still does not invent a setting. Producer remediations that already name one, such as JavaScriptanalysis_timeout_ms, stay in place. The skill version moves from 44 to 45 so an installed skill can pick up the recovery guide.Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
Contract and boundary impact
remediation.actionthat does not recommend a retry;retryablestays false.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): authored skill version 45.src/generatedPackageMetadata.tsskillVersionis 45. Ignoredskills/output is regenerated by CI.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
src/main/messages.test.tslocks the safe-retry ladder, keeps startup off a retry, keeps shutdown and HTTP listen on their named fixes, keeps ceiling dial recoveries free of the user handoff, rejects the old non-adjustable timeout phrases, and rejects the word retry in the unexpected process remediation. It also requires guidance to change a setting only when the remediation explicitly recommends that change, and keeps the Wakaru sentence that raisinganalysis_timeout_msormax_heap_mbdoes not raise that deadline. Boundary tests cover stderr emission, deferred startup, process CLI remediation, and initialization instructions.REA lost its MCP client connection. Restart REA from your MCP client.Startup wasREA could not start its MCP connection. Restart REA from your MCP client; runrea doctorif it fails again.The timeout catalog saidwithout assuming adjustable limits.Retry the tool call once only when it is safe to repeat or known not to have started. If it may already have changed the target, or it fails again, tell the user REA lost its MCP client connection and ask them to restart the MCP client.A connection that never started still beginsRetry once.Server startup isDo not repeat this startup. Tell the user REA could not start and ask them to restart the MCP client, then runrea doctor.Unexpected process commands keep the sanitized cause inmessage. Remediation isDo not repeat this command. Tell the user the process command could not complete and ask them to check the input files, then runrea doctor.367b0043ahad not finished when this body was updated.Validation performed
npm run test:local -- src/main/messages.test.ts— 3 passed on1c5553032.npm run check:fast— typecheck and lint succeeded on1c5553032.npx oxfmt --checkon the edited recovery sources — passed on1c5553032.npm run test:focused -- tests/boundary/mcp/mainErrors.test.ts tests/boundary/mcp/deferredRuntime.test.ts tests/boundary/mcp/javascriptAnalysisResources.test.ts— 39 passed on1c5553032.npm run test:focused -- tests/boundary/filesystem/processCliFileInput.test.ts— 19 passed oncfdbf6abb. That remediation was not edited again.npm run metadata:check— succeeded during the focused-test build with skill version 45.1c5553032: Portable tests and Test shard (6/8) failed onreports file progress and honors cancellation before the next source. The run receivedArtifactOperationErrorwhere that older test requiredAnalysisCancelledError.CI requiredfailed because those jobs failed. Greptile Review passed on that commit.367b0043amerges currentmain, which already asserts the shared cancellation projection (code: cancelled, caller abort reason, partial observation) instead of one error tag.npm run test:focused -- tests/boundary/filesystem/javascript-applications/javascriptArtifactReconstruction.test.ts— 44 passed on367b0043a, including that cancellation test.Compatibility, safety, and release
skillVersion45; setup or skill install refreshes the recovery guide.skillVersion45 in generated package metadata. Package version unchanged.Author readiness
Human owner: @morluto
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.