mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-11-01 21:46:55 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7305
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/6358
Author: @gongfpp
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto
Base:
main← Head:fix/browser-late-script-inventory-6231📝 Commits (2)
46681bbfix(browser): account for late script metadatae329736chore: sync upstream cancellation assertion fix📊 Changes
4 files changed (+259 additions, -12 deletions)
View changed files
📝
docs/browser-observation.md(+8 -0)📝
src/browser/CdpPageCapture.ts(+6 -2)📝
src/browser/CdpPageCaptureScripts.ts(+25 -10)➕
tests/boundary/mcp/scriptInventoryRace.test.ts(+220 -0)📄 Description
Summary
Fixes #6231. Keep passive page script metadata/source reads tied to a fixed admitted-script snapshot, and explicitly account for additional in-scope script IDs still retained at the end of capture. Incomplete inventories must not produce a false
unchangedscript comparison.Problem and expected behavior
If
Debugger.scriptParsedadds a second script while the initial script's source request is pending, the old producer can returnscripts.total=2, one retained item, zero dropped scripts, and no script truncation. An identical pair of those incomplete outputs can then compare asunchanged. Scripts arriving during later storage or final-frame reads can also escape accounting entirely.The fixed producer preserves the initial metadata and selected source-read pass. At the final capture boundary it counts distinct additional IDs still retained, records them as dropped script metadata, and marks
scriptstruncated. For one late ID the registered MCP workflow now observestotal=2, retained items=1, dropped scripts=1, andcompare_web_capturesreports script statusunknownrather than asserting equality.Change and scope
This is an ordinary correctness fix within the existing passive CDP observation boundary. Maintainer scope decision: not applicable; no new execution, injection, mutation, provider, or protection-recovery capability. Coordination: https://github.com/morluto/rea/issues/6231#issuecomment-6345563758 . Nearby #4014 addresses comparison identities, and #6276 addresses when coverage starts; neither supplies this producer snapshot/finalization fix. No directly overlapping public implementation was found in the inspected issue timeline and open-PR search; unpublished work cannot be ruled out.
Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
Contract and boundary impact
CdpPageCaptureScriptssnapshots admitted script metadata before source reads;CdpPageCapturesettles final omissions before normalizing completeness.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): no authored catalog, package, lockfile, installation, or release metadata changes; ignored generated artifacts were validated and are not committed.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
The changed production path attaches to an explicitly selected CDP target and reads admitted metadata/source; it does not evaluate target JavaScript. Real-browser verification uses owned local fixtures and intentionally exercises the repository's broader existing browser workflows, separate from the authority of this fix.
Evidence and regression coverage
CdpBrowserProviderand registered MCPinspect_web_page/compare_web_capturestools against a fake CDP transport. They cover source-pass, post-source, final-frame, source-disabled, duplicate-ID, shared-metadata/different-ID, foreign-origin, existing-ID replacement, deletion-plus-late-ID, and unchanged controls.2127095e3b4a377abbc124ca83af46b98a2a557b, with the same regression file copied in: 7 failed, 3 passed. Failures are missing drop accounting or missing final totals. With this fix: 10/10 passed, plus the four existing source-budget/cancellation tests and six existing browser MCP tests (20 passed).scripts.total=2, one retained item,dropped_events.scripts=1, script truncation, and script comparison statusunknown. No additional source read is issued.For evidence-bearing changes:
Validation performed
Original implementation:
46681bb87062d852667681e0d30cce4fecdb120a. Current head:e329736561b647bfd96565d3540a73faebf7412f, merging upstream791f6328b02a29f23822fe600754fcd228bf754b. The maintainer-owned cancellation assertion fix is now included; no separate JavaScript implementation or duplicate fix was added. Relative to that upstream revision, this PR still contains only the original four browser inventory files.On macOS, Node 24.18.0, npm 11.16.0, at the current tree:
npm run deps:checkandnpm run check:fast— passed (typecheck/lint also passed the push hook).npm run docs:check— generated/document/license checks and all 9 README consistency tests passed.git diff --checkand merge-tree identity check — passed; hooks did not change the validated tree.The two local macOS complete real-browser verifier attempts below did not complete successfully. Current-head Linux real-browser CI subsequently passed (linked below); that does not erase the local macOS limitation. Two complete verifier attempts were made without changing budgets: the first CLI child was killed (the helper has a 60-second cap); the isolated full rerun reached the later module-trace verification and returned
provider_timeoutat the existing 20000ms server deadline. That rerun had already completed the basic real provider/CLI/stdio-MCP observation, stable source comparison, scenario/storage/service-worker, screenshot, popup, network and script-export stages. The timeout cause is not established; no unrelated timeout or module-trace change has been included. At the original implementation head, the 20 focused tests and complete Chrome 155.0.8059.85 verifier had passed. That earlier result is not claimed as a pass for the current head.Follow-up isolation check: a separate worktree at exact upstream
791f6328b02a29f23822fe600754fcd228bf754bwas installed and built using the normal runners.verifyBrowserModulesthen passed sequentially on that baseline and current heade329736561b647bfd96565d3540a73faebf7412f, each covering all 8 public CLI/stdio-MCP trace cases, cancellation cleanup, source/map identity and zero implicit refetches. The timeout was not reproduced in these isolated runs; its cause is still unproven, and these isolated passes alone do not establish a complete macOS verifier pass. No timeout budgets or unrelated source were changed.All npm commands above ran via
mise exec node@24.18.0 -- .... Upstream CI and maintainer approval remain separate from these local results.Upstream CI history and current status
At the previous head
46681bb87062d852667681e0d30cce4fecdb120a, CI run 39817264495 failed on the stale JavaScript reconstruction cancellation assertion. Baseline run 39814960190 had the same expectedAnalysisCancelledErrorversus actualArtifactOperationErrormismatch. Upstream subsequently fixed the assertion while preserving artifact-owned cancellation/provenance; this head merges that fix. At current heade329736561b647bfd96565d3540a73faebf7412f, CI run 39827440624 completed successfully, including CI required, all eight test shards, source tests, static/docs/build checks, portable tests, Linux native package checks and the Linux real-browser verifier. The 19 unselected/skipped lanes are not passing coverage. Superseded/cancelled jobs are not reused as evidence. Human readiness and successful CI request initial review, not maintainer approval or merge permission.Compatibility, safety, and release
unknown; existing stored captures are not retroactively repaired.Author readiness
Human owner: @gongfpp
AI-assisted contribution. The human owner confirmed review and requested initial maintainer review; automated/static review is not a substitute for those human declarations.
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.