[PR #6363] [MERGED] fix(lifecycle): retain Android and Kuna descriptors when close fails #7309

New issue

Closed

opened 2026-11-01 21:46:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-11-01 21:46:55 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6363
Author: @morluto
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto

Base: main ← Head: cursor/android-kuna-close-ownership-89de

---

📝 Commits (10+)

• 94e7e6c fix(android): retain snapshot descriptors when close fails
• ea333bd fix(kuna): retain span descriptors when close fails
• c671f1c fix(android): attribute snapshot cleanup to the descriptor that failed
• a561443 fix(kuna): gate span admission until a retained close releases
• 298c7f3 fix(android): preserve nested snapshot facts when both closes fail
• 0e1b079 fix(kuna): release recovered span leases before the next open
• 832be4b fix(android): retain a source descriptor when admission close fails
• 2b9f510 fix(kuna): keep cancellation when a completed span close fails
• fb071c2 style: format Android and Kuna close-ownership changes
• 7268380 fix(android): keep the snapshot hash inside a nested cancellation

📊 Changes

7 files changed (+1912 additions, -118 deletions)

View changed files

📝 src/android/AndroidTargetSnapshot.ts (+277 -80)
📝 src/android/JadxFailure.ts (+144 -12)
📝 src/android/JadxProvider.ts (+32 -3)
📝 src/kuna/KunaProjectReader.ts (+195 -7)
📝 src/kuna/KunaSessionClient.ts (+180 -16)
➕ tests/boundary/process/androidSnapshotClose.test.ts (+630 -0)
➕ tests/boundary/providers/kuna/kunaSpanCloseOwnership.test.ts (+454 -0)

📄 Description

Summary

Fixes #6047 and Fixes #6052.

Android APK snapshot finalization and Kuna span reads closed raw file handles in finally. A rejected close replaced the primary copy-change diagnosis, the completed copy, or the completed span text, and the descriptor never entered the owner that retries it. Provider or session close could then report success while that handle was still open.

Both paths now keep the primary diagnosis or the completed facts, retain the exact handle, and stay cleanupIncomplete until that owner closes. This follows the Hopper and LLDB ownership pattern from #6357. Hopper and LLDB are unchanged.

Problem and expected behavior

A destination-close EIO during copyAndroidSnapshot turned an AndroidSnapshotChangedError or a finished copy into generic execution_failure, with cleanupIncomplete: false, and left the destination descriptor open after provider.close(). A Kuna span-close refusal did the same to a warm procedure_assembly read: the text or short-read diagnostic was lost, and client.close() returned success while the handle was still readable.

Close failure now preserves the stable-file diagnosis or the completed snapshot hash, and the span text or short-read diagnostic. The exact handle is retried before the next admission and on close. Cleanup stays incomplete until that release. Workspace retirement still waits until child descriptors close. Session close does not succeed while the span handle is open.

Change and scope

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Not applicable: ordinary lifecycle fixes inside the existing Android/JADX snapshot boundary and the existing Kuna session boundary. No new provider, target execution, injection, mutation, or protection recovery.

copyAndroidSnapshot closes the source and destination through withOwnedFileHandle. Stream destroy closes through that same owner, so a successful stream close is confirmed instead of looking abandoned. Nested close failures are walked: a finished copy keeps its file-snapshot-hash observation, and a changed APK keeps its AnalysisInputError, when the other descriptor also rejects close. Cleanup resources name each descriptor that rejected close. A cancellation recorded on a nested close is classified as cancellation or timeout. A destination close that succeeds after abort carries the finished copy inside RegularFileCancelled; the hash stays on the observation whether the source close then rejects or the cancellation is returned directly. If source admission rejects after the descriptor opens and that close also fails, the owner is retained before adoption. Jadx retirement retries only the owners from that close failure and removes the workspace root after they release.

KunaProjectReader.readSpan uses the same owned close. Span admission and close share one queue; the byte read stays outside it, so concurrent dossier reads still overlap. The caller signal is checked again immediately before open, and it is passed into finalization. A completed read whose close fails after the caller aborts stays AnalysisCancelledError, with the span text and the descriptor retained. A completed read whose close succeeds after that abort is AnalysisCancelledError with the caller's abort reason. A failed close is retained on the existing resource scope. A later successful close releases that exact scope record, so both the span map and the scope pending set drop it. Installation cleanup on that scope is not re-adjudicated by the span retry.

Deliberately left alone: Hopper, LLDB, ADB, real JADX or Kuna launches, and unrelated Android or Kuna behavior. Regressions cover destination-only, source-only, and both-close failures, including a changed APK, a nested cancellation, a source admission close failure, a finished copy nested in RegularFileCancelled, and a direct successful-close cancellation.

Contract and boundary impact

• Semantic owner and earliest changed stage: Android snapshot destination (and source) descriptor close during JADX admission, before the engine session exists; Kuna span-descriptor close after a project export read, before session retirement.
• Contribution scope fit and linked maintainer decision: ordinary fix inside existing boundaries. Maintainer scope decision not applicable.
• CLI and MCP/tool-catalog contract: no schema or catalog change. These failures project as cleanup_incomplete. The stable-file diagnosis remains cleanupPrimary / diagnostics.primary_error (invalid_request). Completed snapshot bytes and span text stay on the cleanup error.
• Provider, bridge, target-format, or platform compatibility: JADX APK snapshot admission and Kuna procedure_assembly / pseudocode span reads. No bridge protocol change.
• Evidence, artifact, provenance, or reconstruction contract: a completed copy records file-snapshot-hash (path, sha256, bytes). A completed span records span_text and its byte range as cleanup diagnostics, not a successful result, until close succeeds.
• Target selection, authority, upstream behavior, and cleanup details (if applicable): no new target authority. Failed close retains the exact descriptor. Child descriptors are released before workspace retirement. Kuna session close retries the span lease and stays incomplete while it is open.
• Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): none.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

• Read existing files or captured data.
• Launch or attach to a process.
• Inject instrumentation or run scripts/code.
• Change process memory, registers, files, or configuration.
• Contact network services.
• Recover protected code or work around protections.
• Documentation or usability only; no target interaction.
• Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

• Tests added or updated:
  • tests/boundary/process/androidSnapshotClose.test.ts
  • tests/boundary/providers/kuna/kunaSpanCloseOwnership.test.ts
• Base reproduction or other evidence: adapted from the issue repros. On this branch, a changed APK keeps invalid_request and AndroidSnapshotChangedError when destination close succeeds, and keeps that diagnosis as cleanupPrimary when one or both closes reject. A finished copy keeps snapshot_sha256 and file-snapshot-hash when the source, the destination, or both reject close. Cleanup resources name the descriptor that failed. A nested destination cancellation is AnalysisCancelledError with the hash retained. A destination close that succeeds after abort keeps that hash both when the source close then rejects and when the cancellation is returned directly, and the direct case is not cleanup_incomplete. A source admission stat failure whose close also rejects keeps that descriptor, reports cleanup_incomplete, and does not open the destination. The unresolved fd stays open, the next admission does not open another snapshot handle, provider.close() rejects while the fd is open, and the workspace directory remains until the same owner closes. Kuna keeps the assembly text or the short-read message, blocks the next open while a close is still retained, refuses a queued open after the caller aborts, and keeps cancellation plus the completed span text when close rejects after that abort. When that close succeeds, the result is AnalysisCancelledError whose cause is the caller's abort reason. Session close rejects while the handle is still readable, and releases the span from the resource scope once that close succeeds.
• User-visible CLI/MCP output (if applicable): projectAnalysisError for these close failures returns code: "cleanup_incomplete". The changed-APK primary remains invalid_request. No separate CLI or MCP adapter change.
• Remaining proof gaps: no real JADX, JVM, or Kuna process was launched. Natural OS close-failure frequency was not measured.

For evidence-bearing changes:

• Observed, derived, and inferred claims remain distinguishable.
• Artifact identity, source provenance, and failed attempts remain preserved.
• Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

• PATH="/usr/local/bin:$PATH" npm run check:fast — typecheck and lint passed. That script does not run format:check.
• PATH="/usr/local/bin:$PATH" npx oxfmt --check . — passed after formatting the four close-ownership files CI rejected.
• PATH="/usr/local/bin:$PATH" node node_modules/vitest/vitest.mjs run tests/boundary/process/androidSnapshotClose.test.ts tests/boundary/android/androidTargetSnapshot.test.ts tests/boundary/process/jadxHashCleanup.test.ts tests/boundary/process/jadxIntegration.test.ts tests/boundary/providers/kuna --maxWorkers 4 — 36 files, 385 tests passed. This run was before the format-only commit; oxfmt changed whitespace only.
• PATH="/usr/local/bin:$PATH" npm run check:fast and npx oxfmt --check on the two edited files, then vitest on androidSnapshotClose, androidTargetSnapshot, jadxHashCleanup, and jadxIntegration — 4 files, 60 tests passed after recovering a snapshot hash nested in RegularFileCancelled.
• PATH="/usr/local/bin:$PATH" npm run check:fast, npx oxfmt --check on the four edited files, then vitest on androidSnapshotClose, jadxIntegration, kunaSpanCloseOwnership, kunaReaderCancellation, and kunaProjectReaderConcurrency — 5 files, 71 tests passed after attaching a direct close cancellation's snapshot hash and returning the caller's abort reason when a completed span close succeeds.
• GitHub Actions run 39834210977 on head 7c8bd59a7 failed Static checks and Build package while compiling the pull-request merge with the then-current main. src/application/ReconstructionObligationCandidates.ts called uniqueBy, which was not defined (5d3762456, #3826). This branch did not modify that file. The same merge checkout also failed source and portable tests in IDA, browser scenario diff, pcap, and reconstruction fixtures.
• Merged origin/main at 7091be291 (#6375) in 225d2d742. No conflicts. Android snapshot and Kuna span close-ownership commits are unchanged. After that merge: PATH="/usr/local/bin:$PATH" npm run check:fast passed; npx oxfmt --check . passed (5125 files); vitest on androidSnapshotClose, jadxIntegration, kunaSpanCloseOwnership, kunaReaderCancellation, and kunaProjectReaderConcurrency passed (5 files, 71 tests). GitHub CI on 225d2d742 had not finished when this was recorded.

npm run test:focused was not run as a separate script. The vitest command above is the boundary-project run those tests use; they import src/ directly. No real JADX or Kuna installation was used.

Compatibility, safety, and release

• Breaking changes or migration steps: none. Callers that matched execution_failure for a snapshot or span close rejection now receive cleanup_incomplete, with the previous diagnosis or completed facts retained. Successful copies and span reads are unchanged when close succeeds.
• Real Hopper/Ghidra, browser, or OS coverage: not exercised. Linux Node handles and the repository's JADX and Kuna fixtures only.
• Package or release metadata impact: none.
• Security, privacy, process, or containment review: no new process authority. Retained descriptors stay owned until their own retry confirms release. Workspace removal still follows descriptor release.

Author readiness

Human owner: @morluto

• I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
• I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
• I declare this PR ready for initial maintainer review.

Before merge

• This PR addresses a concrete problem or an agreed enhancement.
• Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked, or the reason for not linking one is stated above.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

  

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6363 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/22/2026 **Status:** ✅ Merged **Merged:** 10/22/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `cursor/android-kuna-close-ownership-89de` --- ### 📝 Commits (10+) - [`94e7e6c`](https://github.com/morluto/rea/commit/94e7e6cbbce2c10abe600943f0f800ed9bf67a7c) fix(android): retain snapshot descriptors when close fails - [`ea333bd`](https://github.com/morluto/rea/commit/ea333bda26363971ae1e94d8098588e073da2f38) fix(kuna): retain span descriptors when close fails - [`c671f1c`](https://github.com/morluto/rea/commit/c671f1c30c7ba8184946f1ccfe125948d2b8b8ec) fix(android): attribute snapshot cleanup to the descriptor that failed - [`a561443`](https://github.com/morluto/rea/commit/a5614439f460fbad61d85b20346869b3d16b52b6) fix(kuna): gate span admission until a retained close releases - [`298c7f3`](https://github.com/morluto/rea/commit/298c7f319a7d7beb57726bc7dc4f61921fada14d) fix(android): preserve nested snapshot facts when both closes fail - [`0e1b079`](https://github.com/morluto/rea/commit/0e1b07957a4abb27e242607daf4de45b2f536857) fix(kuna): release recovered span leases before the next open - [`832be4b`](https://github.com/morluto/rea/commit/832be4b82efebc35ae8a479309ca5873806af747) fix(android): retain a source descriptor when admission close fails - [`2b9f510`](https://github.com/morluto/rea/commit/2b9f510053036c888f57f37905856dbf45e8de02) fix(kuna): keep cancellation when a completed span close fails - [`fb071c2`](https://github.com/morluto/rea/commit/fb071c2f3d55d139739f60fca5d457b11663a477) style: format Android and Kuna close-ownership changes - [`7268380`](https://github.com/morluto/rea/commit/7268380315fc805e4ab953b3ebe4d046e1554ad7) fix(android): keep the snapshot hash inside a nested cancellation ### 📊 Changes **7 files changed** (+1912 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `src/android/AndroidTargetSnapshot.ts` (+277 -80) 📝 `src/android/JadxFailure.ts` (+144 -12) 📝 `src/android/JadxProvider.ts` (+32 -3) 📝 `src/kuna/KunaProjectReader.ts` (+195 -7) 📝 `src/kuna/KunaSessionClient.ts` (+180 -16) ➕ `tests/boundary/process/androidSnapshotClose.test.ts` (+630 -0) ➕ `tests/boundary/providers/kuna/kunaSpanCloseOwnership.test.ts` (+454 -0) </details> ### 📄 Description <!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Summary Fixes #6047 and Fixes #6052. Android APK snapshot finalization and Kuna span reads closed raw file handles in `finally`. A rejected close replaced the primary copy-change diagnosis, the completed copy, or the completed span text, and the descriptor never entered the owner that retries it. Provider or session close could then report success while that handle was still open. Both paths now keep the primary diagnosis or the completed facts, retain the exact handle, and stay `cleanupIncomplete` until that owner closes. This follows the Hopper and LLDB ownership pattern from #6357. Hopper and LLDB are unchanged. ## Problem and expected behavior A destination-close EIO during `copyAndroidSnapshot` turned an `AndroidSnapshotChangedError` or a finished copy into generic `execution_failure`, with `cleanupIncomplete: false`, and left the destination descriptor open after `provider.close()`. A Kuna span-close refusal did the same to a warm `procedure_assembly` read: the text or short-read diagnostic was lost, and `client.close()` returned success while the handle was still readable. Close failure now preserves the stable-file diagnosis or the completed snapshot hash, and the span text or short-read diagnostic. The exact handle is retried before the next admission and on close. Cleanup stays incomplete until that release. Workspace retirement still waits until child descriptors close. Session close does not succeed while the span handle is open. ## Change and scope Follow the [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope). Unresolved scope, authority, side effects, or required verification block integration. Link the required maintainer scope decision for new providers or capabilities involving target execution, injection, mutation, or protection recovery; ordinary fixes within existing boundaries may state "not applicable". Draft PRs may leave the scope decision pending and the readiness and merge checklists unchecked. Maintainers can help resolve open questions. Not applicable: ordinary lifecycle fixes inside the existing Android/JADX snapshot boundary and the existing Kuna session boundary. No new provider, target execution, injection, mutation, or protection recovery. `copyAndroidSnapshot` closes the source and destination through `withOwnedFileHandle`. Stream destroy closes through that same owner, so a successful stream close is confirmed instead of looking abandoned. Nested close failures are walked: a finished copy keeps its `file-snapshot-hash` observation, and a changed APK keeps its `AnalysisInputError`, when the other descriptor also rejects close. Cleanup resources name each descriptor that rejected close. A cancellation recorded on a nested close is classified as cancellation or timeout. A destination close that succeeds after abort carries the finished copy inside `RegularFileCancelled`; the hash stays on the observation whether the source close then rejects or the cancellation is returned directly. If source admission rejects after the descriptor opens and that close also fails, the owner is retained before adoption. Jadx retirement retries only the owners from that close failure and removes the workspace root after they release. `KunaProjectReader.readSpan` uses the same owned close. Span admission and close share one queue; the byte read stays outside it, so concurrent dossier reads still overlap. The caller signal is checked again immediately before open, and it is passed into finalization. A completed read whose close fails after the caller aborts stays `AnalysisCancelledError`, with the span text and the descriptor retained. A completed read whose close succeeds after that abort is `AnalysisCancelledError` with the caller's abort reason. A failed close is retained on the existing resource scope. A later successful close releases that exact scope record, so both the span map and the scope pending set drop it. Installation cleanup on that scope is not re-adjudicated by the span retry. Deliberately left alone: Hopper, LLDB, ADB, real JADX or Kuna launches, and unrelated Android or Kuna behavior. Regressions cover destination-only, source-only, and both-close failures, including a changed APK, a nested cancellation, a source admission close failure, a finished copy nested in `RegularFileCancelled`, and a direct successful-close cancellation. ## Contract and boundary impact - Semantic owner and earliest changed stage: Android snapshot destination (and source) descriptor close during JADX admission, before the engine session exists; Kuna span-descriptor close after a project export read, before session retirement. - Contribution scope fit and linked maintainer decision: ordinary fix inside existing boundaries. Maintainer scope decision not applicable. - CLI and MCP/tool-catalog contract: no schema or catalog change. These failures project as `cleanup_incomplete`. The stable-file diagnosis remains `cleanupPrimary` / `diagnostics.primary_error` (`invalid_request`). Completed snapshot bytes and span text stay on the cleanup error. - Provider, bridge, target-format, or platform compatibility: JADX APK snapshot admission and Kuna `procedure_assembly` / pseudocode span reads. No bridge protocol change. - Evidence, artifact, provenance, or reconstruction contract: a completed copy records `file-snapshot-hash` (path, sha256, bytes). A completed span records `span_text` and its byte range as cleanup diagnostics, not a successful result, until close succeeds. - Target selection, authority, upstream behavior, and cleanup details (if applicable): no new target authority. Failed close retains the exact descriptor. Child descriptors are released before workspace retirement. Kuna session close retries the span lease and stays incomplete while it is open. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `.agents/skills/reverse-engineer-anything/` and never commit build outputs): none. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [x] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: - `tests/boundary/process/androidSnapshotClose.test.ts` - `tests/boundary/providers/kuna/kunaSpanCloseOwnership.test.ts` - Base reproduction or other evidence: adapted from the issue repros. On this branch, a changed APK keeps `invalid_request` and `AndroidSnapshotChangedError` when destination close succeeds, and keeps that diagnosis as `cleanupPrimary` when one or both closes reject. A finished copy keeps `snapshot_sha256` and `file-snapshot-hash` when the source, the destination, or both reject close. Cleanup resources name the descriptor that failed. A nested destination cancellation is `AnalysisCancelledError` with the hash retained. A destination close that succeeds after abort keeps that hash both when the source close then rejects and when the cancellation is returned directly, and the direct case is not `cleanup_incomplete`. A source admission `stat` failure whose close also rejects keeps that descriptor, reports `cleanup_incomplete`, and does not open the destination. The unresolved fd stays open, the next admission does not open another snapshot handle, `provider.close()` rejects while the fd is open, and the workspace directory remains until the same owner closes. Kuna keeps the assembly text or the short-read message, blocks the next open while a close is still retained, refuses a queued open after the caller aborts, and keeps cancellation plus the completed span text when close rejects after that abort. When that close succeeds, the result is `AnalysisCancelledError` whose cause is the caller's abort reason. Session close rejects while the handle is still readable, and releases the span from the resource scope once that close succeeds. - User-visible CLI/MCP output (if applicable): `projectAnalysisError` for these close failures returns `code: "cleanup_incomplete"`. The changed-APK primary remains `invalid_request`. No separate CLI or MCP adapter change. - Remaining proof gaps: no real JADX, JVM, or Kuna process was launched. Natural OS close-failure frequency was not measured. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `PATH="/usr/local/bin:$PATH" npm run check:fast` — typecheck and lint passed. That script does not run `format:check`. - `PATH="/usr/local/bin:$PATH" npx oxfmt --check .` — passed after formatting the four close-ownership files CI rejected. - `PATH="/usr/local/bin:$PATH" node node_modules/vitest/vitest.mjs run tests/boundary/process/androidSnapshotClose.test.ts tests/boundary/android/androidTargetSnapshot.test.ts tests/boundary/process/jadxHashCleanup.test.ts tests/boundary/process/jadxIntegration.test.ts tests/boundary/providers/kuna --maxWorkers 4` — 36 files, 385 tests passed. This run was before the format-only commit; oxfmt changed whitespace only. - `PATH="/usr/local/bin:$PATH" npm run check:fast` and `npx oxfmt --check` on the two edited files, then `vitest` on `androidSnapshotClose`, `androidTargetSnapshot`, `jadxHashCleanup`, and `jadxIntegration` — 4 files, 60 tests passed after recovering a snapshot hash nested in `RegularFileCancelled`. - `PATH="/usr/local/bin:$PATH" npm run check:fast`, `npx oxfmt --check` on the four edited files, then `vitest` on `androidSnapshotClose`, `jadxIntegration`, `kunaSpanCloseOwnership`, `kunaReaderCancellation`, and `kunaProjectReaderConcurrency` — 5 files, 71 tests passed after attaching a direct close cancellation's snapshot hash and returning the caller's abort reason when a completed span close succeeds. - GitHub Actions run [39834210977](https://github.com/morluto/rea/actions/runs/39834210977) on head `7c8bd59a7` failed **Static checks** and **Build package** while compiling the pull-request merge with the then-current `main`. `src/application/ReconstructionObligationCandidates.ts` called `uniqueBy`, which was not defined (`5d3762456`, #3826). This branch did not modify that file. The same merge checkout also failed source and portable tests in IDA, browser scenario diff, pcap, and reconstruction fixtures. - Merged `origin/main` at `7091be291` (#6375) in `225d2d742`. No conflicts. Android snapshot and Kuna span close-ownership commits are unchanged. After that merge: `PATH="/usr/local/bin:$PATH" npm run check:fast` passed; `npx oxfmt --check .` passed (5125 files); vitest on `androidSnapshotClose`, `jadxIntegration`, `kunaSpanCloseOwnership`, `kunaReaderCancellation`, and `kunaProjectReaderConcurrency` passed (5 files, 71 tests). GitHub CI on `225d2d742` had not finished when this was recorded. `npm run test:focused` was not run as a separate script. The vitest command above is the boundary-project run those tests use; they import `src/` directly. No real JADX or Kuna installation was used. ## Compatibility, safety, and release - Breaking changes or migration steps: none. Callers that matched `execution_failure` for a snapshot or span close rejection now receive `cleanup_incomplete`, with the previous diagnosis or completed facts retained. Successful copies and span reads are unchanged when close succeeds. - Real Hopper/Ghidra, browser, or OS coverage: not exercised. Linux Node handles and the repository's JADX and Kuna fixtures only. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no new process authority. Retained descriptors stay owned until their own retry confirms release. Workspace removal still follows descriptor release. ## Author readiness Human owner: @morluto - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-778f29ba-1f64-58f8-a38f-8664d7d889de?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/background-agent?bcId=bc-778f29ba-1f64-58f8-a38f-8664d7d889de&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div> --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-11-01 21:46:55 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-03 00:29:36 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

bsakaguchi referenced this issue 2026-11-05 01:47:52 +00:00

[PR #7309] fix(mcp): stamp required resultType on tools/call results under protocol 2026-07-28 #7814

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7309

No description provided.