[PR #6591] [CLOSED] fix(cli): merge sibling filter paths through the same array slice #7381

New issue

Closed

opened 2026-11-01 21:47:27 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:47:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6591
Author: @SC-10749
Created: 10/23/2026
Status: ❌ Closed

Base: main ← Head: codex/fix-filter-slice-merge

📝 Commits (1)

4766e8f fix(cli): merge sibling filter paths through the same array slice

📊 Changes

2 files changed (+130 additions, -1 deletions)

View changed files

📝 src/cli/cliResultOutput.ts (+100 -1)
📝 tests/boundary/cli/filteredArrayOutput.test.ts (+30 -0)

📄 Description

Issue

When multiple filter paths select sibling fields from the same array slice, the later path overwrites the earlier selection. This drops fields from the CLI output even though each path is valid.

Change

Apply sibling slice selections independently and merge their object fields element by element. Preserve the existing Filter.apply behavior for single paths and selections without a shared slice prefix.

Validation

Added a regression test covering two sibling fields selected from the same array slice.
git diff --check: passed.
The repository PR checks are green except the readiness check, which was pending because this PR was still Draft.

Checklist

Added regression coverage for the reported behavior.
Preserved existing behavior for non-conflicting filter paths.
No API or CLI flag changes.

Author readiness

Human owner: @SC-10749

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6591 **Author:** [@SC-10749](https://github.com/SC-10749) **Created:** 10/23/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/fix-filter-slice-merge` --- ### 📝 Commits (1) - [`4766e8f`](https://github.com/morluto/rea/commit/4766e8f19e4a6367d2f312cbb9af0d0223d540ec) fix(cli): merge sibling filter paths through the same array slice ### 📊 Changes **2 files changed** (+130 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cli/cliResultOutput.ts` (+100 -1) 📝 `tests/boundary/cli/filteredArrayOutput.test.ts` (+30 -0) </details> ### 📄 Description ## Issue When multiple filter paths select sibling fields from the same array slice, the later path overwrites the earlier selection. This drops fields from the CLI output even though each path is valid. ## Change Apply sibling slice selections independently and merge their object fields element by element. Preserve the existing `Filter.apply` behavior for single paths and selections without a shared slice prefix. ## Validation - Added a regression test covering two sibling fields selected from the same array slice. - `git diff --check`: passed. - The repository PR checks are green except the readiness check, which was pending because this PR was still Draft. ## Checklist - [x] Added regression coverage for the reported behavior. - [x] Preserved existing behavior for non-conflicting filter paths. - [x] No API or CLI flag changes. ## Author readiness Human owner: @SC-10749 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:47:27 +00:00