[PR #6683] test(cli): cover production doctor output option ordering #7389

Open
opened 2026-11-01 21:47:30 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6683
Author: @eco-null
Created: 10/23/2026
Status: 🔄 Open

Base: main ← Head: codex/mcp-doctor-output-order


📝 Commits (9)

  • 7ec830f fix(cli): retain production doctor output routing
  • 09da173 test(reference): return byte-preserving entry names
  • c52ba80 test(cli): retain doctor routing proof on current main
  • 1e3f5fa fix(javascript): coalesce projected source facts
  • e21973c test: repair isolation and format fixtures
  • e3ec007 merge: retain upstream CI and doctor fixes
  • 06810a6 merge: retain upstream fixes and focused regression
  • cfd3a5d fix(evidence): retain rebound snapshot proof
  • 22d8e4f merge: retain upstream Evidence ownership repair

📊 Changes

1 file changed (+39 additions, -0 deletions)

View changed files

📝 tests/boundary/cli/mcpDoctorHelpCli.test.ts (+39 -0)

📄 Description

Summary

Refs #6452. Adds compiled CLI regression coverage for leading/interleaved JSON, format and full-output options. Configuration refusal retains production-stdio routing and exit 1.

The final diff contains one test file relative to pinned main 03ed0c63d9566dbc0d6e805bc62ccd7569bad314. Production corrections are upstream. The shared low-headroom Evidence repair and regressions are retained exactly from @gensokyo-dev's #7036; the competing local repair was removed.

Current-head verification

Head: 22d8e4f7e7dbbc2b8b8d53ff2ba3f720e49fefe6.

Hosted CI completed successfully: 32,836 passed, 234 skipped, across 2,398 passed/33 skipped test files. Source tests, all eight built-test shards, Portable tests, static checks and CI required all succeeded (12/12 gates). Skipped conditional/platform cases are not claimed as executed; this does not establish every real external-engine or cross-platform workflow.

Local validation

  • Pinned Node24.22.1/npm11.16.0, Windows. 19/19 CLI doctor-help and dispatcher tests, 19.40s.
  • Pinned-upstream Evidence/JSON/error/snapshot/managed-headroom/doctor selection on #6690: 143 passed/1 POSIX skip in seven files, 25.94s. All three heads share identical production code.
  • Full check: six tasks plus architecture guards passed on the pinned tree, 13.561s. Each branch passed its relevant focused tests and normal pre-push typecheck/lint.
  • Merge commits preserve read-only validated index trees; mutating precommit was not applied to upstream-only imports. No assertion, retry, timeout or allowance was weakened.

Readiness

The owner's requested current-head test gate is satisfied. The existing three human declarations below are preserved; no new human attestation or maintainer approval is asserted.

Author readiness

Human owner: @eco-null

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6683 **Author:** [@eco-null](https://github.com/eco-null) **Created:** 10/23/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/mcp-doctor-output-order` --- ### 📝 Commits (9) - [`7ec830f`](https://github.com/morluto/rea/commit/7ec830fc0103427d10ca7cf310bd17943d360985) fix(cli): retain production doctor output routing - [`09da173`](https://github.com/morluto/rea/commit/09da173b4e4e21269c25adda0e24d17dd633fd83) test(reference): return byte-preserving entry names - [`c52ba80`](https://github.com/morluto/rea/commit/c52ba80aa6128527f452f2887c48ea8e0b550933) test(cli): retain doctor routing proof on current main - [`1e3f5fa`](https://github.com/morluto/rea/commit/1e3f5fa880cf8d24de65e62342e30e8ee485dc3f) fix(javascript): coalesce projected source facts - [`e21973c`](https://github.com/morluto/rea/commit/e21973ce125ab60181fcbbda0469219a31d5c6a2) test: repair isolation and format fixtures - [`e3ec007`](https://github.com/morluto/rea/commit/e3ec0074764333d68b4cbdd0a1c42f65e30fe60b) merge: retain upstream CI and doctor fixes - [`06810a6`](https://github.com/morluto/rea/commit/06810a68dacdc7d76092734c33494c2f36cb7f24) merge: retain upstream fixes and focused regression - [`cfd3a5d`](https://github.com/morluto/rea/commit/cfd3a5d3c6cd21438c8e2bcf43ab07d55d1f3efb) fix(evidence): retain rebound snapshot proof - [`22d8e4f`](https://github.com/morluto/rea/commit/22d8e4f7e7dbbc2b8b8d53ff2ba3f720e49fefe6) merge: retain upstream Evidence ownership repair ### 📊 Changes **1 file changed** (+39 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/mcpDoctorHelpCli.test.ts` (+39 -0) </details> ### 📄 Description ## Summary Refs #6452. Adds compiled CLI regression coverage for leading/interleaved JSON, format and full-output options. Configuration refusal retains production-stdio routing and exit 1. The final diff contains **one test file** relative to pinned main `03ed0c63d9566dbc0d6e805bc62ccd7569bad314`. Production corrections are upstream. The shared low-headroom Evidence repair and regressions are retained exactly from @gensokyo-dev's [#7036](https://github.com/morluto/rea/pull/7036); the competing local repair was removed. ## Current-head verification Head: `22d8e4f7e7dbbc2b8b8d53ff2ba3f720e49fefe6`. [Hosted CI completed successfully](https://github.com/morluto/rea/actions/runs/40125119228): **32,836 passed, 234 skipped**, across 2,398 passed/33 skipped test files. Source tests, all eight built-test shards, Portable tests, static checks and `CI required` all succeeded (12/12 gates). Skipped conditional/platform cases are not claimed as executed; this does not establish every real external-engine or cross-platform workflow. ## Local validation - Pinned Node24.22.1/npm11.16.0, Windows. 19/19 CLI doctor-help and dispatcher tests, 19.40s. - Pinned-upstream Evidence/JSON/error/snapshot/managed-headroom/doctor selection on #6690: 143 passed/1 POSIX skip in seven files, 25.94s. All three heads share identical production code. - Full check: six tasks plus architecture guards passed on the pinned tree, 13.561s. Each branch passed its relevant focused tests and normal pre-push typecheck/lint. - Merge commits preserve read-only validated index trees; mutating precommit was not applied to upstream-only imports. No assertion, retry, timeout or allowance was weakened. ## Readiness The owner's requested current-head test gate is satisfied. The existing three human declarations below are preserved; no new human attestation or maintainer approval is asserted. ## Author readiness Human owner: @eco-null - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#7389
No description provided.