[PR #6690] test(ghidra): verify installation metadata budget through doctor #7390

Open
opened 2026-11-01 21:47:31 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6690
Author: @eco-null
Created: 10/23/2026
Status: 🔄 Open

Base: main ← Head: codex/ghidra-properties-limit-recovery


📝 Commits (9)

  • 63e8406 fix(ghidra): name installation metadata limit
  • 22898f6 test(reference): return byte-preserving entry names
  • cfc0fad test(ghidra): retain CLI budget proof on current main
  • 46ff7b8 fix(javascript): coalesce projected source facts
  • 5aaff19 test: repair isolation and format fixtures
  • cd6876b merge: retain upstream CI and doctor fixes
  • 2252523 merge: retain upstream fixes and focused regression
  • fc2b0b4 fix(evidence): retain rebound snapshot proof
  • 27ef4a7 merge: retain upstream Evidence ownership repair

📊 Changes

1 file changed (+26 additions, -2 deletions)

View changed files

📝 tests/boundary/cli/ghidraInstallationProperties.test.ts (+26 -2)

📄 Description

Summary

Refs #6468. Adds compiled doctor assertions for exact installation-properties capacity, nonretryable refusal and named read-budget recovery. The regular-file case runs on Windows; the FIFO case remains POSIX-only.

The final diff contains one test file relative to pinned main 03ed0c63d9566dbc0d6e805bc62ccd7569bad314. Production corrections are upstream. The shared low-headroom Evidence repair and regressions are retained exactly from @gensokyo-dev's #7036; the competing local repair was removed.

Current-head verification

Head: 27ef4a7738ddd9c3a6594f40ee2d9eac618cada4.

Hosted CI completed successfully: 32,835 passed, 234 skipped, across 2,398 passed/33 skipped test files. Source tests, all eight built-test shards, Portable tests, static checks and CI required all succeeded (12/12 gates). Skipped conditional/platform cases are not claimed as executed; this does not establish every real external-engine or cross-platform workflow.

Local validation

  • Pinned Node24.22.1/npm11.16.0, Windows. Doctor capacity passed in the seven-file run below; one POSIX FIFO case skipped on Windows. No Java or real Ghidra was launched.
  • Pinned-upstream Evidence/JSON/error/snapshot/managed-headroom/doctor selection on #6690: 143 passed/1 POSIX skip in seven files, 25.94s. All three heads share identical production code.
  • Full check: six tasks plus architecture guards passed on the pinned tree, 13.561s. Each branch passed its relevant focused tests and normal pre-push typecheck/lint.
  • Merge commits preserve read-only validated index trees; mutating precommit was not applied to upstream-only imports. No assertion, retry, timeout or allowance was weakened.

Readiness

The owner's requested current-head test gate is satisfied. The existing three human declarations below are preserved; no new human attestation or maintainer approval is asserted.

Author readiness

Human owner: @eco-null

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6690 **Author:** [@eco-null](https://github.com/eco-null) **Created:** 10/23/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/ghidra-properties-limit-recovery` --- ### 📝 Commits (9) - [`63e8406`](https://github.com/morluto/rea/commit/63e84068713e46a605a61d34d3641e0c2b3df46e) fix(ghidra): name installation metadata limit - [`22898f6`](https://github.com/morluto/rea/commit/22898f64233b6f7242a6b7a4aa7232851e94d4b5) test(reference): return byte-preserving entry names - [`cfc0fad`](https://github.com/morluto/rea/commit/cfc0fad41b14165f93232af2ffad5ba20925bf6a) test(ghidra): retain CLI budget proof on current main - [`46ff7b8`](https://github.com/morluto/rea/commit/46ff7b84267918b92ee0eda19a033e671fc7806a) fix(javascript): coalesce projected source facts - [`5aaff19`](https://github.com/morluto/rea/commit/5aaff1957709c3b06709931a1a3d8ee0a7ed71a7) test: repair isolation and format fixtures - [`cd6876b`](https://github.com/morluto/rea/commit/cd6876b50dda1c827cefd7359b2ef579d33407aa) merge: retain upstream CI and doctor fixes - [`2252523`](https://github.com/morluto/rea/commit/225252398249b2b885db93ea7a2c10f9b7f016bb) merge: retain upstream fixes and focused regression - [`fc2b0b4`](https://github.com/morluto/rea/commit/fc2b0b481f619356422e4b6504c9623e20510f9b) fix(evidence): retain rebound snapshot proof - [`27ef4a7`](https://github.com/morluto/rea/commit/27ef4a7738ddd9c3a6594f40ee2d9eac618cada4) merge: retain upstream Evidence ownership repair ### 📊 Changes **1 file changed** (+26 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/ghidraInstallationProperties.test.ts` (+26 -2) </details> ### 📄 Description ## Summary Refs #6468. Adds compiled doctor assertions for exact installation-properties capacity, nonretryable refusal and named read-budget recovery. The regular-file case runs on Windows; the FIFO case remains POSIX-only. The final diff contains **one test file** relative to pinned main `03ed0c63d9566dbc0d6e805bc62ccd7569bad314`. Production corrections are upstream. The shared low-headroom Evidence repair and regressions are retained exactly from @gensokyo-dev's [#7036](https://github.com/morluto/rea/pull/7036); the competing local repair was removed. ## Current-head verification Head: `27ef4a7738ddd9c3a6594f40ee2d9eac618cada4`. [Hosted CI completed successfully](https://github.com/morluto/rea/actions/runs/40125040451): **32,835 passed, 234 skipped**, across 2,398 passed/33 skipped test files. Source tests, all eight built-test shards, Portable tests, static checks and `CI required` all succeeded (12/12 gates). Skipped conditional/platform cases are not claimed as executed; this does not establish every real external-engine or cross-platform workflow. ## Local validation - Pinned Node24.22.1/npm11.16.0, Windows. Doctor capacity passed in the seven-file run below; one POSIX FIFO case skipped on Windows. No Java or real Ghidra was launched. - Pinned-upstream Evidence/JSON/error/snapshot/managed-headroom/doctor selection on #6690: 143 passed/1 POSIX skip in seven files, 25.94s. All three heads share identical production code. - Full check: six tasks plus architecture guards passed on the pinned tree, 13.561s. Each branch passed its relevant focused tests and normal pre-push typecheck/lint. - Merge commits preserve read-only validated index trees; mutating precommit was not applied to upstream-only imports. No assertion, retry, timeout or allowance was weakened. ## Readiness The owner's requested current-head test gate is satisfied. The existing three human declarations below are preserved; no new human attestation or maintainer approval is asserted. ## Author readiness Human owner: @eco-null - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#7390
No description provided.