morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 07:47:29 +00:00

[PR #6867] [CLOSED] fix(reconstruction): evaluate transitive surface dependencies #7427

New issue

Closed

opened 2026-11-01 21:47:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:47:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6867
Author: @ropoctl
Created: 10/23/2026
Status: ❌ Closed

Base: main ← Head: codex/fix-coverage-dependencies

📝 Commits (1)

f4e8865 fix(reconstruction): evaluate transitive surface dependencies

📊 Changes

3 files changed (+116 additions, -2 deletions)

View changed files

📝 docs/reconstruction-coverage.md (+7 -0)
📝 src/domain/reconstructionCoverage.test.ts (+98 -0)
📝 src/domain/reconstructionCoverage.ts (+11 -2)

📄 Description

Summary

Reconstruction closure could report complete when a required surface depended on an existing surface with no implementation owner. Evaluate the cycle-safe transitive closure of existing dependency surfaces before checking ownership, contradictions, risks, and package proofs. Missing edges retain their attributed diagnostic; explicit required claim selection is unchanged.

Contract and boundary impact

Semantic owner: domain reconstruction-coverage evaluator, before shared evaluation context creation. All consumers evaluate the same expanded boundary.
Contribution scope: ordinary correctness fix within the existing readiness boundary; a maintainer decision for a new provider or target execution is not applicable.
CLI/MCP schemas and generated catalogs: unchanged. summary.required_surfaces now counts unique transitive existing surfaces; callers may see incomplete instead of complete for previously unchecked dependencies.
Provider/platform, installation, artifact identities, and input persistence: unchanged. Evaluation uses captured coverage data; no target interaction or process launch is added.
Evidence, missing dependencies, and contradictions remain attributed to their owning surface. Original caller boundary data is not mutated.

Evidence and validation

Executed on Node 24.22.1:

npm run test:local -- src/domain/reconstructionCoverage.test.ts — 24 tests passed, including two-level missing owners, repeated/cyclic dependencies, missing transitive dependencies, and dependency contradictions.
npm run typecheck — passed.
npx oxfmt on the three changed files — completed; git diff --check passed.
npx oxlint src/domain/reconstructionCoverage.ts src/domain/reconstructionCoverage.test.ts — no errors; existing module size/function-size warning categories remain (525 lines; unchanged 114-line reference validator).
npm run verify:test-discovery — passed (2,151 test files).

The regression trigger is a valid required surface A with dependency B present in surfaces but without B ownership: previously only A was evaluated. No real-provider run or full repository gate was performed; the change is provider-independent. No associated issue was filed; this is a directly reviewed evaluator defect.

Author readiness

Human owner: @ropoctl

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

Human ownership/readiness and maintainer review are complete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6867 **Author:** [@ropoctl](https://github.com/ropoctl) **Created:** 10/23/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/fix-coverage-dependencies` --- ### 📝 Commits (1) - [`f4e8865`](https://github.com/morluto/rea/commit/f4e88652cf807ef570cce6d8d88ee1aa06609c58) fix(reconstruction): evaluate transitive surface dependencies ### 📊 Changes **3 files changed** (+116 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/reconstruction-coverage.md` (+7 -0) 📝 `src/domain/reconstructionCoverage.test.ts` (+98 -0) 📝 `src/domain/reconstructionCoverage.ts` (+11 -2) </details> ### 📄 Description ## Summary Reconstruction closure could report complete when a required surface depended on an existing surface with no implementation owner. Evaluate the cycle-safe transitive closure of existing dependency surfaces before checking ownership, contradictions, risks, and package proofs. Missing edges retain their attributed diagnostic; explicit required claim selection is unchanged. ## Contract and boundary impact - Semantic owner: domain reconstruction-coverage evaluator, before shared evaluation context creation. All consumers evaluate the same expanded boundary. - Contribution scope: ordinary correctness fix within the existing readiness boundary; a maintainer decision for a new provider or target execution is not applicable. - CLI/MCP schemas and generated catalogs: unchanged. `summary.required_surfaces` now counts unique transitive existing surfaces; callers may see incomplete instead of complete for previously unchecked dependencies. - Provider/platform, installation, artifact identities, and input persistence: unchanged. Evaluation uses captured coverage data; no target interaction or process launch is added. - Evidence, missing dependencies, and contradictions remain attributed to their owning surface. Original caller boundary data is not mutated. ## Evidence and validation Executed on Node 24.22.1: - `npm run test:local -- src/domain/reconstructionCoverage.test.ts` — 24 tests passed, including two-level missing owners, repeated/cyclic dependencies, missing transitive dependencies, and dependency contradictions. - `npm run typecheck` — passed. - `npx oxfmt` on the three changed files — completed; `git diff --check` passed. - `npx oxlint src/domain/reconstructionCoverage.ts src/domain/reconstructionCoverage.test.ts` — no errors; existing module size/function-size warning categories remain (525 lines; unchanged 114-line reference validator). - `npm run verify:test-discovery` — passed (2,151 test files). The regression trigger is a valid required surface A with dependency B present in `surfaces` but without B ownership: previously only A was evaluated. No real-provider run or full repository gate was performed; the change is provider-independent. No associated issue was filed; this is a directly reviewed evaluator defect. ## Author readiness Human owner: @ropoctl - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. ## Before merge - [ ] Human ownership/readiness and maintainer review are complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:47:47 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7427

No description provided.

Rows
Columns