morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #6925] [CLOSED] fix(prompts): include existing static artifact investigation routes #7451

New issue

Closed

opened 2026-11-01 21:47:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:47:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6925
Author: @AyoubElleuch
Created: 10/23/2026
Status: ❌ Closed

Base: main ← Head: codex/feature-investigation-static-routes

📝 Commits (3)

87a39ff fix(prompts): include existing static artifact investigation routes
e0761c7 fix(prompts): reconcile static routes with current workflow contracts
d24b6ee fix(prompts): preserve workflows in existing family scopes

📊 Changes

6 files changed (+154 additions, -34 deletions)

View changed files

📝 docs/mcp-prompts.md (+8 -6)
📝 src/contracts/promptContracts.ts (+34 -3)
📝 src/contracts/promptToolFamilyScope.ts (+13 -10)
📝 src/server/registerPrompts.ts (+9 -7)
📝 tests/boundary/mcp/guidedWorkflowsMcp.test.ts (+33 -4)
📝 tests/boundary/mcp/promptMcp.test.ts (+57 -4)

📄 Description

Summary

Fixes #6919.

investigate_feature currently directs files and app bundles toward native opening while omitting existing APK code, managed metadata, and Apple resource routes. The shared prompt now presents these optional starting points before native analysis, retaining JavaScript and archive inventory guidance.

Change and scope

Guidance only in src/contracts/promptContracts.ts. Target-free tools receive path=target_path; Apple resource tools use a resource-only session; native and archive tools retain their active-target requirements. APK code inspection is distinguished from archive-member inventory. The prompt preserves format uncertainty and directs callers to advertised tools and host/provider limitations, including the JADX MCP JAR/JDK requirement.

This is a routine clarification within existing capabilities; an advance maintainer scope decision is not applicable. No new detector, provider, execution authority, or automatic workflow is introduced.

Contract and boundary impact

Semantic owner: shared guided prompt contract, consumed by native MCP prompt registration and the recorded runtime prompt catalog.
CLI/MCP schemas and tool inventory: unchanged. Only rendered guidance changes.
Evidence and provenance: existing Observations, Inference, Unknowns, caller-context handling, and optional-step discipline remain.
Target interaction: rendering neither acquires a target nor executes analysis. The suggested tools retain their existing effects.
Package/install impact: none; generated catalogs and build outputs remain uncommitted.

Expected effects:

Documentation or usability only; no target interaction.

Evidence and regression coverage

Source inspection at base 3d4f55652 confirms the three routes were absent from this prompt and already documented in the authored skill. Existing MCP coverage checks rendering, unchanged tool inventory, context preservation, and zero analysis execution.

An executed SDK client against the built production stdio MCP server rendered APK-method, managed-method, Apple-resource, JavaScript, and native questions using nonexistent local paths. All five responses preserved context and included the relevant routes, prerequisites, uncertainty, and Evidence discipline; tool inventory stayed unchanged. This verifies guidance delivery, not model tool selection.

Validation performed

Windows x64, pinned Node.js 24.22.1 and npm 11.16.0:

npm run test:focused -- tests/boundary/mcp/promptMcp.test.ts — 13 passed.
npm run check — passed (typecheck, lint/module boundaries, formatting, unused-code, metadata, architecture guards).
npm run docs:check — passed, including 9 README consistency tests.
Built stdio MCP SDK probe — all five cases passed.
git diff --check — passed.

Compatibility, safety, and release

No schema or API breaking change, migration, or new target effects. Real JADX, managed-provider, Apple-resource, and native analysis were not exercised; this change only renders guidance. Agent-selection accuracy and token/latency/CPU/process-family-memory costs were not measured; no performance improvement is claimed.

Author readiness

Human owner: @AyoubElleuch

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6925 **Author:** [@AyoubElleuch](https://github.com/AyoubElleuch) **Created:** 10/23/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/feature-investigation-static-routes` --- ### 📝 Commits (3) - [`87a39ff`](https://github.com/morluto/rea/commit/87a39ff491c98c8293614f87baba8a83db9a8dc7) fix(prompts): include existing static artifact investigation routes - [`e0761c7`](https://github.com/morluto/rea/commit/e0761c733e363f5623b8d9dc68e8f4f55620c9d9) fix(prompts): reconcile static routes with current workflow contracts - [`d24b6ee`](https://github.com/morluto/rea/commit/d24b6ee4a3754571ed55e0ab41317281934bb09d) fix(prompts): preserve workflows in existing family scopes ### 📊 Changes **6 files changed** (+154 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `docs/mcp-prompts.md` (+8 -6) 📝 `src/contracts/promptContracts.ts` (+34 -3) 📝 `src/contracts/promptToolFamilyScope.ts` (+13 -10) 📝 `src/server/registerPrompts.ts` (+9 -7) 📝 `tests/boundary/mcp/guidedWorkflowsMcp.test.ts` (+33 -4) 📝 `tests/boundary/mcp/promptMcp.test.ts` (+57 -4) </details> ### 📄 Description ## Summary Fixes #6919. `investigate_feature` currently directs files and app bundles toward native opening while omitting existing APK code, managed metadata, and Apple resource routes. The shared prompt now presents these optional starting points before native analysis, retaining JavaScript and archive inventory guidance. ## Change and scope Guidance only in `src/contracts/promptContracts.ts`. Target-free tools receive `path=target_path`; Apple resource tools use a resource-only session; native and archive tools retain their active-target requirements. APK code inspection is distinguished from archive-member inventory. The prompt preserves format uncertainty and directs callers to advertised tools and host/provider limitations, including the JADX MCP JAR/JDK requirement. This is a routine clarification within existing capabilities; an advance maintainer scope decision is not applicable. No new detector, provider, execution authority, or automatic workflow is introduced. ## Contract and boundary impact - Semantic owner: shared guided prompt contract, consumed by native MCP prompt registration and the recorded runtime prompt catalog. - CLI/MCP schemas and tool inventory: unchanged. Only rendered guidance changes. - Evidence and provenance: existing Observations, Inference, Unknowns, caller-context handling, and optional-step discipline remain. - Target interaction: rendering neither acquires a target nor executes analysis. The suggested tools retain their existing effects. - Package/install impact: none; generated catalogs and build outputs remain uncommitted. Expected effects: - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage Source inspection at base `3d4f55652` confirms the three routes were absent from this prompt and already documented in the authored skill. Existing MCP coverage checks rendering, unchanged tool inventory, context preservation, and zero analysis execution. An executed SDK client against the built production stdio MCP server rendered APK-method, managed-method, Apple-resource, JavaScript, and native questions using nonexistent local paths. All five responses preserved context and included the relevant routes, prerequisites, uncertainty, and Evidence discipline; tool inventory stayed unchanged. This verifies guidance delivery, not model tool selection. ## Validation performed Windows x64, pinned Node.js 24.22.1 and npm 11.16.0: - `npm run test:focused -- tests/boundary/mcp/promptMcp.test.ts` — 13 passed. - `npm run check` — passed (typecheck, lint/module boundaries, formatting, unused-code, metadata, architecture guards). - `npm run docs:check` — passed, including 9 README consistency tests. - Built stdio MCP SDK probe — all five cases passed. - `git diff --check` — passed. ## Compatibility, safety, and release No schema or API breaking change, migration, or new target effects. Real JADX, managed-provider, Apple-resource, and native analysis were not exercised; this change only renders guidance. Agent-selection accuracy and token/latency/CPU/process-family-memory costs were not measured; no performance improvement is claimed. ## Author readiness Human owner: @AyoubElleuch - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-11-01 21:47:57 +00:00

bsakaguchi referenced this issue

2026-11-05 01:48:05 +00:00

[PR #7451] [CLOSED] docs(clients): note the XDG config root for Trae #7845

bsakaguchi changed title from ~~[PR #6925] fix(prompts): include existing static artifact investigation routes~~ to [PR #6925] [CLOSED] fix(prompts): include existing static artifact investigation routes

2026-11-05 06:56:04 +00:00

bsakaguchi closed this issue

2026-11-05 06:56:04 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7451

No description provided.

Rows
Columns