[PR #6979] [MERGED] fix(browser): report an out-of-range script_index as a selection fault #7490

New issue

Closed

opened 2026-11-01 21:48:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:48:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/6979
Author: @Adolanium
Created: 10/24/2026
Status: ✅ Merged
Merged: 10/25/2026
Merged by: @morluto

Base: main ← Head: fix/web-script-index-out-of-range

📝 Commits (5)

c428437 fix(browser): report an out-of-range script_index as a selection fault
a8be2bc Merge remote-tracking branch 'upstream/main' into fix/web-script-index-out-of-range
9936c13 test(browser): keep the out-of-range index case in its own block
d8805e5 fix(browser): validate script selection across current artifact contracts
646ad07 chore: incorporate the verified evaluation fixture correction

📊 Changes

2 files changed (+76 additions, -4 deletions)

View changed files

📝 src/browser/assets/LocalWebScriptArtifacts.ts (+21 -4)
📝 tests/boundary/filesystem/webModuleArtifacts.test.ts (+55 -0)

📄 Description

Summary

A script index outside a valid captured-script manifest now reports an input selection fault with its valid bounds. Empty manifests report invalid_value; malformed manifests remain invalid_format on manifest_path.

Fixes #6980. Updated against current main, which also corrects the two stale Windows manifest-path expectations behind the previous failed shard.

Validation

Runtime/package build passed with the pinned toolchain.
24 focused tests passed in webModuleArtifacts.test.ts and webScriptManifestPaths.test.ts, including out-of-range bounds, valid empty manifests, malformed JSON, and path controls.
npm run check:fast -- --concurrency=1 passed.

Local checks used one worker and serial files on macOS arm64. No live browser was launched. Current-head GitHub checks are tracked in the PR checks panel.

Shared CI fixture correction: main ab720b421 retains the Notes trace’s partial static coverage. Its 12 known-answer/report-gate tests, fast checks, and docs verification passed. The feature-specific checks above remain applicable.

Author readiness

Human owner: @Adolanium

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/6979 **Author:** [@Adolanium](https://github.com/Adolanium) **Created:** 10/24/2026 **Status:** ✅ Merged **Merged:** 10/25/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/web-script-index-out-of-range` --- ### 📝 Commits (5) - [`c428437`](https://github.com/morluto/rea/commit/c4284375afc7f595d4c80c8a3c9d8d92c65fccc0) fix(browser): report an out-of-range script_index as a selection fault - [`a8be2bc`](https://github.com/morluto/rea/commit/a8be2bc3e709936df24a5e704357168a2a94c974) Merge remote-tracking branch 'upstream/main' into fix/web-script-index-out-of-range - [`9936c13`](https://github.com/morluto/rea/commit/9936c139c0dd387cac95b33fb4d682486c93ecd1) test(browser): keep the out-of-range index case in its own block - [`d8805e5`](https://github.com/morluto/rea/commit/d8805e574f58569cabcb1224171446b7fb023270) fix(browser): validate script selection across current artifact contracts - [`646ad07`](https://github.com/morluto/rea/commit/646ad07b682b54fa6da795e253c1403f1b7fe219) chore: incorporate the verified evaluation fixture correction ### 📊 Changes **2 files changed** (+76 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/browser/assets/LocalWebScriptArtifacts.ts` (+21 -4) 📝 `tests/boundary/filesystem/webModuleArtifacts.test.ts` (+55 -0) </details> ### 📄 Description ## Summary A script index outside a valid captured-script manifest now reports an input selection fault with its valid bounds. Empty manifests report `invalid_value`; malformed manifests remain `invalid_format` on `manifest_path`. Fixes #6980. Updated against current main, which also corrects the two stale Windows manifest-path expectations behind the previous failed shard. ## Validation - Runtime/package build passed with the pinned toolchain. - 24 focused tests passed in `webModuleArtifacts.test.ts` and `webScriptManifestPaths.test.ts`, including out-of-range bounds, valid empty manifests, malformed JSON, and path controls. - `npm run check:fast -- --concurrency=1` passed. Local checks used one worker and serial files on macOS arm64. No live browser was launched. Current-head GitHub checks are tracked in the PR checks panel. Shared CI fixture correction: main `ab720b421` retains the Notes trace’s partial static coverage. Its 12 known-answer/report-gate tests, fast checks, and docs verification passed. The feature-specific checks above remain applicable. ## Author readiness Human owner: @Adolanium - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:48:13 +00:00