mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Open
opened 2026-11-03 13:38:45 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7566
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/7004
Author: @akshatgg
Created: 10/24/2026
Status: 🔄 Open
Base:
main← Head:fix/doctor-audit-scope-hint📝 Commits (8)
d129a05feat(doctor): report the configured workflow beside an audit-wide resulte7aebf3fix(doctor): judge the configured skill from the configured clients' copies492ebcdfix(doctor): keep partial skills, cleanup failures and Windows quoting in configured scope7baaa6bfix(doctor): keep the package-runner launcher in the suggested command15282fcfix(doctor): pin the suggested release and select Hopper by discovery68d371ddocs(doctor): describe the pinned package-runner launchere785f81fix(doctor): quote PowerShell splatting and array tokens in the suggested commandc91230bfeat(doctor): name the failing checks in configured_scope📊 Changes
4 files changed (+635 additions, -12 deletions)
View changed files
📝
docs/installation.md(+17 -0)📝
src/application/Doctor.test.ts(+371 -1)📝
src/application/Doctor.ts(+129 -11)📝
src/application/DoctorScope.ts(+118 -0)📄 Description
Summary
Refs #6914. Without a scope option,
rea doctorreportshealthy: falsewhenever any detected client or provider is unhealthy, including ones the user never set up (here: IDA, JADX, Kuna, and the Codex, VS Code and Gemini registrations). A working setup then looks broken, and the report does not say which failures matter or how to check only the set-up workflow.Problem and expected behavior
rea doctorwith no--client,--provideror--skillon a host where only some clients and providers are set up.healthy: falseandenvironment_healthy: false, with no pointer to the configured workflow's readiness. The scoped mode that answers this already exists, but the user has to know to use it and which IDs to pass.configured_scope, with the set-up clients, providers and skill, their readiness under the existing explicit-scope rules, and the exactrea doctorcommand that reports that scope.healthy,environment_healthy,scope_checksand the exit status are unchanged.Change and scope
src/application/DoctorScope.ts: newconfiguredDoctorScope, which selects:missingormanual(sostale,unknownandinvalidregistrations stay in, and their failures still count);configured: true, plus Hopper when it is configured or its launcher was discovered (presence, not readiness, so a failing Hopper stays visible);missing.selectConfiguredDoctorScopepicks the clients and providers;configuredDoctorScopebuilds the explicit scope and reusesscopeDoctorChecksforhealthy, so there is no second definition of readiness. Nothing is reported when no client or provider is set up. It reportsargv(the exact unquoted arguments, starting withnpx -y rea-agents@<version>orbunx rea-agents@<version>, pinned to the running release, when doctor was launched that way, otherwiserea) andcommand, the same invocation quoted for PowerShell on Windows and POSIX shells elsewhere, quoting only arguments that need it (on Windows that includes a leading@and any,, which PowerShell treats as splatting and array syntax).src/application/Doctor.ts: when any client is configured,inspectConfiguredScopereads that client set's skill copies (as the suggested--client … --skillscope does) throughinspectSkillIdentity, the helpercollectDoctorIdentitynow shares, and judgesconfigured_scopefrom those facts. With no configured client the suggested scope reads every copy, so the audit's facts are reused. The audit's own checks are unchanged. If doctor's final cleanup fails,configured_scope.healthybecomes false with the top-level fields, as the suggested scope would report.DoctorReport.configured_scope?is emitted only whenscope.mode === "audit-wide".docs/installation.md: explains why an audit-widehealthycan be false for a working setup and whatconfigured_scopecontains.Not included: no change to what
healthymeans or to the exit status; the issue's discussion suggests keeping both summaries, and this keeps the audit result authoritative. No new CLI flag (the existing--client/--provider/--skillscope already covers the "configured only" check; the report now names it).Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
Contract and boundary impact
DoctorScope.ts), consumed byinspectDoctor.configured_scopefield on audit-wide doctor reports; no change for explicit-scope reports or to existing fields and exit status. No MCP tool schema change.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
Tests added or updated:
src/application/Doctor.test.ts→ "doctor configured scope":cursorregistration, missingcodex/vscode, configured Ghidra, discovered Hopper and unconfigured IDA/JADX/Kuna: the audit stayshealthy: false,configured_scopeis{clients: ["cursor"], providers: ["ghidra", "hopper"], skill: true, healthy: true}with the matching command, and running that exact scope also reportshealthy: true(and has noconfigured_scope);configured_scope.healthyfalse and listsghidra-javawith its remediation infailing_checks; a healthy scope hasfailing_checks: [];staleregistration stays in the configured clients and fails it;win32it is quoted for PowerShell and kept unquoted inargv;cursor, missingcodexcopy) keeps--skilland makes the workflow unhealthy;runDoctorOwned) makes bothconfigured_scopeand the suggested scope unhealthy and appears infailing_checks;npx -y rea-agents@<version>inargv/command, andsystemDoctorHostdetectsbunxfrom the environment;win32,@sample.exeanda,b.exeare quoted whiledir/a@b.exestays bare; on Linux@sample.exestays bare;hopper-demo-runtime) stays inprovidersand makes the workflow unhealthy;cursorcopy and a stale copy elsewhere, the audit keeps its failingskill:identitycheck whileconfigured_scope.healthyis true and matches the suggested scope; a stalecursorcopy makes it false (review finding);configured_scopewhen nothing is set up.Base reproduction or other evidence: on the base revision the four positive tests fail (
configured_scopeisundefined); the "nothing set up" control passes on both.User-visible CLI/MCP output (if applicable):
rea doctor --format jsonon a real macOS host (one agent client registered, Hopper installed, IDA/JADX/Kuna and other clients not set up), run from this branch's build:(The registered client's ID is replaced with
<client>here; everything else is verbatim.)Here
configured_scope.healthyis false for real reasons rather than the unconfigured components: the development build expects skill version 46 while the installed copy is 42, and the client registration points at the installed 6.7.0 rather than this checkout. Running the printed command reports exactly those two failures (registration:<client>,skill:identity). The installed 6.7.0 on the same host reports the samehealthy/environment_healthywithoutconfigured_scope.Remaining proof gaps: not run on Linux or Windows hosts; Windows quoting is covered by a unit test only, and
commandtargets PowerShell (cmd.exe callers should useargv). Whether maintainers prefer a different field name or an additional human-readable summary line is open.For evidence-bearing changes:
Validation performed
Node 24.22.1, macOS arm64, after
npm ci. At headc91230b3:npx vitest run src/application/Doctor.test.ts— 91 passed.npx vitest run src/application tests/boundary/cli/doctorHopperDiscovery.test.ts tests/boundary/cli/cliSetup.test.ts(afternpm run build) — 161 files passed; 2521 tests passed, 3 skipped.npm run typecheck— passed.npm run lint— 0 errors; 2657 warnings, identical to main without these changes.npm run format:checkandnpm run docs:check— passed.npm run build— passed.At 78faaaa4 (first commit), additionally:
npx vitest run src/application tests/boundary/cli— 329 of 330 files passed; 3648 tests passed, 8 skipped, 1 failed:tests/boundary/cli/idaRetainedCleanupCli.test.ts, which passes when run alone on this branch and on main without these changes.npm run verify:test-discoveryandnpm run verify:architecture-guardspassed. These were not repeated atc91230b3.GitHub CI on
e7aebf37failed only intests/boundary/process/packedBridgeVerification.test.ts, which also failed on main at the base commit; that is now fixed on main. CI on7baaa6bafailed only intests/process-global/commandFinalizationCancellation.test.ts, which fails identically on current main397aa62fwithout these changes (run locally on a clean checkout; see the PR comments).Compatibility, safety, and release
rea doctoron macOS arm64 (above). Not run on Linux or Windows.Author readiness
Human owner: @akshatgg
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.