[PR #7035] [CLOSED] test(cli): assert retained managed target selection provenance #7593

New issue

Closed

opened 2026-11-03 13:38:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-03 13:38:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7035
Author: @gensokyo-dev
Created: 10/24/2026
Status: ❌ Closed

Base: main ← Head: test/managed-caller-parameters-20261024

📝 Commits (1)

4453d72 test(cli): assert retained managed target selection provenance

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 tests/boundary/cli/managedMemberSummaryCli.test.ts (+6 -2)

📄 Description

Summary

Fix the stale managed-member CLI Evidence assertion that breaks main CI after one-shot analysis began retaining caller-selected target paths (535926ca). The retained parameters must contain both the original input_path and type filters.

Change and scope

Update the existing real CLI/bundle/paging test to assert the complete parameter object. Pass a path containing /./ so the test also detects accidental normalization of the caller's selection. Existing complete/summary equivalence, retained identity, all eight collections, and paging after target removal remain covered. Test deadlines and production behavior are unchanged.

The semantic owner is DirectAnalysis's one-shot CLI Evidence parameters. MCP uses its existing path argument and needs no field alias. This is an ordinary test-contract repair within existing contribution scope; a new maintainer capability decision is not applicable. No schema, provider, package, generated metadata, or release contract changes. The authored inert managed fixture is read by real CLI processes; the test writes and deletes temporary fixtures/bundles and contacts no target service.

Evidence and validation

Main CI run 40117674826 failed the old exact assertion because actual parameters also contain input_path. Local baseline reproduced 1 failed / 15 passed in the complete file.
The updated retained-Evidence case passed through the compiled CLI. A temporary production-boundary mutation that normalizes /./, followed by rebuilding the runtime, fails exactly at the original-path assertion. Mutation restored and runtime rebuilt.
Runtime rebuilt on base 1ca7d387 after restoring the negative-control mutation.
Exact single-worker runs of managedMemberSummaryCli.test.ts, managedMemberSummaryMcp.test.ts, managedArtifactSummaryMcp.test.ts, and managedDirectAnalysis.test.ts: 22 tests passed in four files. Real compiled CLI/bundle paging and MCP handlers ran against the authored managed fixture. Three serial batches: 150.99 s wall, 172.25 s family CPU, 2044.4 MiB maximum sampled family RSS; build excluded. No OOM.
npm run check and git diff --check passed (29.76 s wall / 54.77 s family CPU / 2733.8 MiB sampled family RSS).

This repairs test correctness; no runtime speedup or token reduction is claimed. Measurements use two CPUs and sampled descendant RSS (shared pages may double-count; brief/reparented children may be missed). Local tests have a 3 GiB sampled stop. CI supplies other OS/provider coverage; local fixture runs do not establish real external-provider behavior.

Author readiness

Human owner: @gensokyo-dev

The owner explicitly delegated readiness declarations and agent-managed review. Inspection and execution were performed by Codex; no separate human inspection is claimed.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7035 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/24/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/managed-caller-parameters-20261024` --- ### 📝 Commits (1) - [`4453d72`](https://github.com/morluto/rea/commit/4453d724f76696d38ec0664556fb2b4e492fae16) test(cli): assert retained managed target selection provenance ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/managedMemberSummaryCli.test.ts` (+6 -2) </details> ### 📄 Description ## Summary Fix the stale managed-member CLI Evidence assertion that breaks main CI after one-shot analysis began retaining caller-selected target paths (`535926ca`). The retained parameters must contain both the original `input_path` and type filters. ## Change and scope Update the existing real CLI/bundle/paging test to assert the complete parameter object. Pass a path containing `/./` so the test also detects accidental normalization of the caller's selection. Existing complete/summary equivalence, retained identity, all eight collections, and paging after target removal remain covered. Test deadlines and production behavior are unchanged. The semantic owner is `DirectAnalysis`'s one-shot CLI Evidence parameters. MCP uses its existing `path` argument and needs no field alias. This is an ordinary test-contract repair within existing contribution scope; a new maintainer capability decision is not applicable. No schema, provider, package, generated metadata, or release contract changes. The authored inert managed fixture is read by real CLI processes; the test writes and deletes temporary fixtures/bundles and contacts no target service. ## Evidence and validation - Main CI run [40117674826](https://github.com/morluto/rea/actions/runs/40117674826) failed the old exact assertion because actual parameters also contain `input_path`. Local baseline reproduced **1 failed / 15 passed** in the complete file. - The updated retained-Evidence case passed through the compiled CLI. A temporary production-boundary mutation that normalizes `/./`, followed by rebuilding the runtime, fails exactly at the original-path assertion. Mutation restored and runtime rebuilt. - Runtime rebuilt on base `1ca7d387` after restoring the negative-control mutation. - Exact single-worker runs of `managedMemberSummaryCli.test.ts`, `managedMemberSummaryMcp.test.ts`, `managedArtifactSummaryMcp.test.ts`, and `managedDirectAnalysis.test.ts`: **22 tests passed in four files**. Real compiled CLI/bundle paging and MCP handlers ran against the authored managed fixture. Three serial batches: 150.99 s wall, 172.25 s family CPU, 2044.4 MiB maximum sampled family RSS; build excluded. No OOM. - `npm run check` and `git diff --check` passed (29.76 s wall / 54.77 s family CPU / 2733.8 MiB sampled family RSS). This repairs test correctness; no runtime speedup or token reduction is claimed. Measurements use two CPUs and sampled descendant RSS (shared pages may double-count; brief/reparented children may be missed). Local tests have a 3 GiB sampled stop. CI supplies other OS/provider coverage; local fixture runs do not establish real external-provider behavior. ## Author readiness Human owner: @gensokyo-dev The owner explicitly delegated readiness declarations and agent-managed review. Inspection and execution were performed by Codex; no separate human inspection is claimed. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-03 13:38:59 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7593

No description provided.

Rows
Columns