mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #7043] [MERGED] fix(browser): admit passive capture events against the shared retained budget #7599
Closed
opened 2026-11-03 13:39:01 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7599
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/7043
Author: @DeryFerd
Created: 10/24/2026
Status: ✅ Merged
Merged: 10/24/2026
Merged by: @morluto
Base:
main← Head:fix/cdp-capture-event-budget📝 Commits (1)
fc03d0ffix(browser): admit passive capture events against the shared retained budget📊 Changes
4 files changed (+202 additions, -3 deletions)
View changed files
📝
src/browser/CdpCaptureEventHandlers.ts(+52 -3)📝
src/browser/CdpCaptureEventState.ts(+2 -0)➕
src/browser/CdpCaptureEvents.eventBudget.test.ts(+146 -0)📝
src/browser/CdpCaptureEvents.ts(+2 -0)📄 Description
Summary
Passive page capture now admits each console entry and websocket frame against the shared 8 MiB retained-event budget before retaining it, and counts a refused entry as a dropped event in the capture's completeness report. Console entries and websocket frames were the two retention surfaces in this capture with no aggregate ceiling at all, so a page could grow the inspection's memory without limit until the process died, and the completeness report still said complete.
Every sibling retention surface already enforced the same constant: the observation session's pre-arm buffer and document-request identities, the browser runtime sources, requests, and metadata, the V8 inspector's retained metadata, and this same capture's own script metadata, which has had its own count-and-bytes budget with visible omissions for a while. This change closes the two paths that were left out, using the budget and the reporting vocabulary that already existed.
Problem and expected behavior
Smallest trigger: open a page with
inspect_web_pagewhose script logs a few hundred megabytes of console text, or that sends websocket text frames whose JSON payloads carry hundreds of thousands of distinct keys.Before this change, every
Runtime.consoleAPICalledevent pushed a retained entry with its captured text, and everyNetwork.webSocketFrameSentorReceivedevent pushed a retained frame carrying the payload's inferred JSON shape. Nothing summed what was retained. The console handler already computed aretained_bytesvalue for each entry's captured text, but that number was stored per entry and never compared against anything. The websocket shape summary grows with the payload's own keys, because the shape records every key name it sees, so a wide document made a wide retained shape. Both arrays grew until the process ran out of memory, and because the MCP response budget is enforced after the handler returns, the growth finished before any typed refusal could exist.Expected behavior follows the rest of the browser runtime: retention is admitted against
WEB_RUNTIME_LIMITS.retainedEventBytes, a refused entry is counted as a dropped event of its kind, and the inspection reports a truncated inventory with the dropped count rather than a complete one backed by unbounded memory. An inventory that never approaches the budget is byte-for-byte unchanged.Change and scope
One counter,
retainedEventBytes, now lives on the capture state alongside the existing script-metadata byte counter, resets inbeginAuthorizedFrametogether with the rest of the per-frame state, and is charged by the two handlers that admit events.The console handler measures what the entry actually retains: the entry's type, its source url, its argument-type strings, and the text capture's retained bytes, which the handler was already computing per entry. A frame retains its shape summary rather than the payload, so the websocket handler charges the serialized size of the shape it keeps. A frame carrying a two-megabyte string costs a handful of bytes, because the shape records the type, not the value; a frame carrying a document with half a million keys costs the shape that names them.
Admission mirrors the script-metadata budget in the same file: an entry that does not fit in the remaining budget is not retained, and
completeness.droprecords it under theconsole_eventsorwebsocket_frameskind. That vocabulary already existed in the completeness tracker, carried both kinds, and reported adropped_eventscount with a total, but only the scripts kind had ever used it. No new setting is introduced. The shared 8 MiB constant is reused as-is, so an operator who changes nothing sees the same number reported everywhere the budget appears.Deliberately out of scope: response metadata and agent hints, whose rows are fixed-shape facts already bounded per response, and any per-caller knob for these two kinds. The scenario capture path already exposes caller-selected event budgets for its own events, and adding a second knob system to the passive path would be a new product decision rather than a gap fix.
Contract and boundary impact
src/browser/CdpCaptureEventHandlers.tsowns passive-capture event ingestion; the change runs at admission time, before any entry is retained.src/browser/CdpCaptureEvents.tsandCdpCaptureEventState.tsown the state field and its per-frame reset.console_eventsorwebsocket_framesunderdropped_eventswith a count and mark those sections truncated once the budget is exhausted, where the same capture previously reported them complete. Both fields already existed in the completeness schema and were already produced for late-dropped scripts, so no schema or catalog regeneration is involved.docs/public/product-catalog.json), package, or installation impact: none. No dependency, lockfile, generated catalog, or skill bundle change.Expected effects (check known effects; use documentation-only on its own).
Evidence and regression coverage
src/browser/CdpCaptureEvents.eventBudget.test.ts, three cases. The console case sends megabyte-sized entries until the shared budget is exceeded and asserts that fewer entries than sent are retained, that the retained count is above zero, and that the completeness snapshot reports the exact dropped count forconsole_eventsand the same number in the total. A second console case keeps a small inventory far under the budget and asserts all sixteen entries are retained with zero dropped events, so ordinary captures are untouched. The websocket case retains a small frame, then sends one frame whose shape alone exceeds the budget, and asserts exactly the small frame survives withwebsocket_framesdropped at one.inspect_web_pagecapture whose console traffic exceeds the budget now reports the console section as truncated with adropped_events.console_eventscount, and likewise for websocket frames, instead of returning a complete verdict over an inventory that only ended because the process stopped receiving.For evidence-bearing changes:
Validation performed
npx vitest run src/browser/CdpCaptureEvents.eventBudget.test.ts— 3 passed, 2 of which failed on the base revision for the reasons quoted above.npx vitest runover the neighboring console, websocket, coverage, context-retention, and completeness suites — 26 passed.npx tsc -p .tmp-tsconfig.json --noEmitover the changed set and its consumers, narrowed from./tsconfig.json— exit 0.npx oxlinton the four changed files — 0 errors.npx oxfmt --checkon the four changed files — all matched files use the correct format.npm run verify:module-boundaries— pass.Compatibility, safety, and release
!marker is needed.Author readiness
Human owner: @DeryFerd
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.