mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Open
opened 2026-11-03 13:39:13 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7630
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/7085
Author: @Tapraj-Pathak
Created: 10/25/2026
Status: 🔄 Open
Base:
main← Head:test/public-output-contracts📝 Commits (2)
94015datest(contracts): pin public machine-readable analysis output contracts3dd8721test(contracts): pin Evidence vocabularies against the runtime schema📊 Changes
5 files changed (+685 additions, -3 deletions)
View changed files
📝
docs/testing.md(+38 -0)📝
src/domain/evidence.ts(+9 -3)➕
tests/acceptance/publicOutputContractCli.test.ts(+127 -0)➕
tests/boundary/mcp/publicOutputContractMcp.test.ts(+329 -0)➕
tests/fixtures/publicOutputContract.ts(+182 -0)📄 Description
Summary
Adds the focused contract-test suite requested in #6339: regression tests that
pin the public machine-readable output contracts REA exposes to scripts and
agent integrations, so an unintended change to result fields, documented enum
values, or error representations fails CI instead of integrations.
Fixes #6339
Problem and expected behavior
Internal tests can pass while a public result field, documented enum, or error
representation changes and breaks external consumers. The declared contracts —
the canonical Evidence record, the stable error projection shared by CLI and
MCP, and result-embedded coverage enums — had no dedicated regression
coverage. Expected behavior: representative successful, partial, unsupported,
and failed outputs from more than one analysis category are pinned through
public CLI and MCP workflows, and the suite fails when one of those documented
surfaces drifts.
Change and scope
tests/fixtures/publicOutputContract.ts— shared assertions: the documentedconfidence,authority, and error-category vocabularies; canonicalEvidence record keys, field types, and
analysis_profilepresence; errorprojections validated against both the runtime zod schema
(
src/contracts/errorSchemas.ts) and the committed generateddocs/error-contract.schema.json.tests/boundary/mcp/publicOutputContractMcp.test.ts— seven MCP tests overproduction servers (in-memory transport) across three analysis categories
(byte entropy, native exports, artifact inspection plus its summary view):
success, documented partial delivery, in-result
coverage.status: "unsupported",unsupported_target,invalid_request, advertisedoutput-schema validation (ajv), and a drift test asserting the runtime
error-code set equals the generated document's.
tests/acceptance/publicOutputContractCli.test.ts— the same contractsthrough the compiled CLI (
--json, exit status 0/1).docs/testing.md— new "Public output contract regressions" section namingwhat the suite protects and how intentional contract changes are reviewed
and versioned: change the owning schema first, regenerate the generated
error contract, update the contract fixtures in the same change with an
explanation, and mark breaking changes with
!/BREAKING CHANGE:plus amigration note.
src/domain/evidence.ts— extracts the inline confidence enum asevidenceConfidenceSchema, mirroringevidenceAuthoritySchema, so the contractfixture can compare both full runtime vocabularies (review fix; no behavior
change).
Intentionally not included: new contracts or production behavior changes;
freezing internal implementation details or incidental output fields;
real-provider lanes (the suites use portable fixtures and built-in parsers
only).
Contribution scope: test-only plus documentation within existing boundaries;
no new providers or capabilities involving target execution, injection,
mutation, or protection recovery — no maintainer scope decision required.
Contract and boundary impact
consume the existing owners' facts (
src/contracts/errorSchemas.ts,src/domain/evidence.ts,src/domain/native/nativeExports.ts,src/domain/artifactGraph.ts,src/domain/artifactInspection.ts). Nosuperseded paths removed.
coverage and docs within existing boundaries.
existing documented contracts, including advertised (post-SDK-conversion)
output schemas resolved by operation name.
fixtures are synthetic ELF images and directories built by existing test
helpers.
the suite asserts Evidence identity/provenance fields and coverage enums.
applicable — no provider or target execution; test-owned resources close via
onTestFinished.docs/public/product-catalog.json), package, orinstallation impact: none.
docs/error-contract.schema.jsonis committedand unchanged; the tests read it. No catalog or
skills/outputs touched.Expected effects: the change is tests and documentation; the tests read
locally generated fixture files and exercise REA commands on synthetic local
fixtures, with no analyst-target interaction.
Evidence and regression coverage
shared fixture module (executed; results under Validation).
missing protection. Drift-gate negative probe (executed): temporarily added
an undeclared
contract_mutation_probecode toanalysisErrorProjectionSchema; the drift test failed (exit 1); reverted,and the suite passed again.
existing output.
will exercise the same suites. Real-provider behavior is out of scope (no
provider execution; portable fixtures only). HTTP transport and JSON Lines
framing are not covered by this suite.
Applicable boundary regressions: this is a new contract suite rather than a
parser or inventory fix; the relevant row is "Public success and error
delivery" — exercised through real MCP paths and the compiled CLI, including
typed error projections and retained-fact assertions. Lifecycle regressions:
not applicable (no resource-acquisition or cleanup changes; test resources
close through existing owned fixtures).
For evidence-bearing changes:
confidence/authorityenums and the distinctions between complete negative findings,unsupportedavailability with a reason,version: null, and non-UTF-8 names kept as exact bytes withname_utf8_decodable: false)coverage.status: "unsupported"with a reason; inventorycoverage.scope/status; summarysource_coverage)Validation performed
All commands executed locally on Windows x64, pinned Node 24.22.1 / npm 11.19.1:
node scripts/run-exact-tests.mjs tests/boundary/mcp/publicOutputContractMcp.test.ts— 7/7 passed (run twice; final run on this exact diff).node scripts/run-development-tests.mjs focused tests/acceptance/publicOutputContractCli.test.ts— 3/3 passed (run twice), after theartifacts:skillsbuild.npm run typecheck— pass.npm run lint— 0 errors across 5393 files (pre-existing warning baseline unchanged); module-boundaries check pass.npm run docs:check— pass (6 turbo tasks + readmeConsistency 9/9).oxfmt --checkon the new filesReview-fix validation (commit
3dd8721b0, pushed to this branch):evidenceConfidenceSchema; the new pinned-vocabulary assertion failed with the exact set diff, and passed again after reverting.node scripts/run-exact-tests.mjs tests/boundary/mcp/publicOutputContractMcp.test.ts— 7/7 across three consecutive runs;node scripts/run-development-tests.mjs focused tests/acceptance/publicOutputContractCli.test.ts— 3/3;npm run typecheck— pass; pre-pushnpm run check:fast— pass.Compatibility, safety, and release
execution; portable fixtures and built-in parsers only. The suites are
platform-portable; local execution was Windows.
files under test-owned temporary directories and clean up through the
Vitest lifecycle; no network access and no target processes.
Author readiness
Human owner: @Tapraj-Pathak
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.