[PR #7090] [MERGED] fix(doctor): classify an unreadable skill identity as unknown #7634

Closed
opened 2026-11-03 13:39:15 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7090
Author: @Adolanium
Created: 10/25/2026
Status: ✅ Merged
Merged: 10/27/2026
Merged by: @morluto

Base: main ← Head: fix/doctor-unknown-skill-classification


📝 Commits (1)

  • 8f4270d fix(doctor): classify an unreadable skill identity as unknown

📊 Changes

3 files changed (+39 additions, -2 deletions)

View changed files

📝 src/application/Doctor.test.ts (+30 -0)
📝 src/application/Doctor.ts (+3 -1)
📝 src/application/DoctorScope.ts (+6 -1)

📄 Description

Summary

Fixes #7091.

rea doctor reports a skill copy whose path is unreadable or unresolved with identity state unknown, but classifies its skill:identity check as config_drift, which claims the copy has drifted. Nothing established drift; the copy could not be read. The check is now classified unknown, matching its own state and the registration checks beside it.

Problem and expected behavior

skillIdentityCheck in src/application/Doctor.ts hard-coded classification: "config_drift", and the selectedSkillCheck fallback in src/application/DoctorScope.ts did the same for every non-aligned state. skillIdentityState already returns unknown for unreadable and unresolved issues, docs/installation.md says an unreadable skill identity remains unknown, and registrationCheck already maps state === "unknown" to classification: "unknown".

Expected: classification: "unknown" when the skill identity state is unknown; config_drift stays for stale, missing and unmanaged copies.

Change and scope

  • src/application/Doctor.ts: skillIdentityCheck derives the classification from skillIdentityState.
  • src/application/DoctorScope.ts: the skill:identity fallback maps unknown state to unknown.

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Contribution scope: not applicable. This is a fix inside the existing doctor diagnostics.

Contract and boundary impact

  • Semantic owner and earliest changed stage: skillIdentityCheck and the DoctorScope fallback, which classify the skill identity check.
  • Contribution scope fit and linked maintainer decision: not applicable.
  • CLI and MCP/tool-catalog contract: the skill:identity check's classification for an unreadable or unresolved skill copy changes from config_drift to unknown; ok stays false.
  • Provider, bridge, target-format, or platform compatibility: none.
  • Evidence, artifact, provenance, or reconstruction contract: unknown state is no longer reported as drift.
  • Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable.
  • Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): none.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: src/application/Doctor.test.ts, "classifies an unreadable installed skill as unknown, not drift": a skill identity with one unreadable issue gives identity state unknown and a skill:identity check with ok: false and classification: "unknown". The existing missing-skill test still asserts config_drift.
  • Base reproduction or other evidence: with Doctor.ts from upstream/main 80673b22a and the new test, the test fails.
  • User-visible CLI/MCP output (if applicable): rea doctor --json checks for an unreadable skill copy.
  • Remaining proof gaps: the DoctorScope fallback is changed to match but has no dedicated test; it is used only when the selected checks omit skill:identity.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

On Linux (WSL Ubuntu, Node 24.22.1) at 8f4270d6a (on upstream/main 80673b22a), after npm ci and npm run build:cached:

  • npx tsc -p . --noEmit passed.
  • npx oxfmt --check on the changed files: clean. node scripts/ci/static-check-report.mjs lint: 0 errors.
  • npx vitest run src/application/Doctor src/application/Setup and the doctor CLI tests: 224 passed, in two runs.
  • The negative check above failed the new test.

Compatibility, safety, and release

  • Breaking changes or migration steps: none; consumers matching config_drift for this case see unknown, as for registrations.
  • Real Hopper/Ghidra, browser, or OS coverage: Linux only.
  • Package or release metadata impact: none.
  • Security, privacy, process, or containment review: none.

Author readiness

Human owner: @Adolanium

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7090 **Author:** [@Adolanium](https://github.com/Adolanium) **Created:** 10/25/2026 **Status:** ✅ Merged **Merged:** 10/27/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/doctor-unknown-skill-classification` --- ### 📝 Commits (1) - [`8f4270d`](https://github.com/morluto/rea/commit/8f4270d6acfb78a11531c2fd724eabc5cd40b56c) fix(doctor): classify an unreadable skill identity as unknown ### 📊 Changes **3 files changed** (+39 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/application/Doctor.test.ts` (+30 -0) 📝 `src/application/Doctor.ts` (+3 -1) 📝 `src/application/DoctorScope.ts` (+6 -1) </details> ### 📄 Description ## Summary Fixes #7091. `rea doctor` reports a skill copy whose path is unreadable or unresolved with identity state `unknown`, but classifies its `skill:identity` check as `config_drift`, which claims the copy has drifted. Nothing established drift; the copy could not be read. The check is now classified `unknown`, matching its own state and the registration checks beside it. ## Problem and expected behavior `skillIdentityCheck` in `src/application/Doctor.ts` hard-coded `classification: "config_drift"`, and the `selectedSkillCheck` fallback in `src/application/DoctorScope.ts` did the same for every non-aligned state. `skillIdentityState` already returns `unknown` for `unreadable` and `unresolved` issues, `docs/installation.md` says an unreadable skill identity remains `unknown`, and `registrationCheck` already maps `state === "unknown"` to `classification: "unknown"`. Expected: `classification: "unknown"` when the skill identity state is `unknown`; `config_drift` stays for stale, missing and unmanaged copies. ## Change and scope - `src/application/Doctor.ts`: `skillIdentityCheck` derives the classification from `skillIdentityState`. - `src/application/DoctorScope.ts`: the `skill:identity` fallback maps `unknown` state to `unknown`. Follow the [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope). Unresolved scope, authority, side effects, or required verification block integration. Link the required maintainer scope decision for new providers or capabilities involving target execution, injection, mutation, or protection recovery; ordinary fixes within existing boundaries may state "not applicable". Draft PRs may leave the scope decision pending and the readiness and merge checklists unchecked. Maintainers can help resolve open questions. Contribution scope: not applicable. This is a fix inside the existing doctor diagnostics. ## Contract and boundary impact - Semantic owner and earliest changed stage: `skillIdentityCheck` and the `DoctorScope` fallback, which classify the skill identity check. - Contribution scope fit and linked maintainer decision: not applicable. - CLI and MCP/tool-catalog contract: the `skill:identity` check's `classification` for an unreadable or unresolved skill copy changes from `config_drift` to `unknown`; `ok` stays `false`. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: unknown state is no longer reported as drift. - Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `.agents/skills/reverse-engineer-anything/` and never commit build outputs): none. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [x] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: `src/application/Doctor.test.ts`, "classifies an unreadable installed skill as unknown, not drift": a skill identity with one `unreadable` issue gives identity state `unknown` and a `skill:identity` check with `ok: false` and `classification: "unknown"`. The existing missing-skill test still asserts `config_drift`. - Base reproduction or other evidence: with `Doctor.ts` from upstream/main 80673b22a and the new test, the test fails. - User-visible CLI/MCP output (if applicable): `rea doctor --json` checks for an unreadable skill copy. - Remaining proof gaps: the `DoctorScope` fallback is changed to match but has no dedicated test; it is used only when the selected checks omit `skill:identity`. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed On Linux (WSL Ubuntu, Node 24.22.1) at 8f4270d6a (on upstream/main 80673b22a), after `npm ci` and `npm run build:cached`: - `npx tsc -p . --noEmit` passed. - `npx oxfmt --check` on the changed files: clean. `node scripts/ci/static-check-report.mjs lint`: 0 errors. - `npx vitest run src/application/Doctor src/application/Setup` and the doctor CLI tests: 224 passed, in two runs. - The negative check above failed the new test. ## Compatibility, safety, and release - Breaking changes or migration steps: none; consumers matching `config_drift` for this case see `unknown`, as for registrations. - Real Hopper/Ghidra, browser, or OS coverage: Linux only. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @Adolanium - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge <!-- Draft PRs may leave pending items unchecked. Resolve material scope and authority questions before integration. --> - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-03 13:39:15 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#7634
No description provided.