morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #7097] [MERGED] fix(browser): report non-absolute export paths at their input field #7638

New issue

Closed

opened 2026-11-03 13:39:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-03 13:39:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7097
Author: @saiyam-jain-dev
Created: 10/25/2026
Status: ✅ Merged
Merged: 10/27/2026
Merged by: @morluto

Base: main ← Head: fix/web-script-export-path-issues

📝 Commits (1)

2436891 fix(browser): report non-absolute export paths at their input field

📊 Changes

2 files changed (+70 additions, -12 deletions)

View changed files

📝 src/application/WebScriptExportService.ts (+13 -9)
📝 tests/boundary/filesystem/webScriptExport.test.ts (+57 -3)

📄 Description

Summary

When caller-supplied paths to export_web_scripts (capture_path or output_directory) are relative, WebScriptExportService previously emitted a single generic issue with an empty issue path (path: []) and a combined message "capture_path and output_directory must be absolute filesystem paths on this host." even if only one of them was relative. This PR reports non-absolute paths at their respective field (["capture_path"] and/or ["output_directory"]), matching the established boundary issue reporting pattern across REA.

Problem and expected behavior

Previously, passing a relative capture_path or output_directory returned:

{
  "path": [],
  "reason": "invalid_format",
  "message": "capture_path and output_directory must be absolute filesystem paths on this host."
}

Consumers could not determine from the structured issue which argument violated the absolute path requirement. The expected behavior is that each invalid field is reported with its own issue targeting ["capture_path"] or ["output_directory"].

Change and scope

Updated exportWebScriptsValidated in src/application/WebScriptExportService.ts to inspect capture_path and output_directory individually and return targeted AnalysisInputIssue records for each invalid field.
Added boundary assertions to tests/boundary/filesystem/webScriptExport.test.ts verifying issue paths and reasons when capture_path is relative, output_directory is relative, or both are relative.

Contribution scope fit: ordinary boundary fix within existing boundaries (not applicable).

Contract and boundary impact

Semantic owner and earliest changed stage: src/application/WebScriptExportService.ts input validation.
Contribution scope fit and linked maintainer decision: not applicable.
CLI and MCP/tool-catalog contract: structured AnalysisInputError now identifies capture_path and/or output_directory in issues[].path.
Provider, bridge, target-format, or platform compatibility: platform-independent.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details (if applicable): none.
Generated metadata (docs/public/product-catalog.json), package, or installation impact: none.

Expected effects:

Read existing files or captured data.
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated: tests/boundary/filesystem/webScriptExport.test.ts
Base reproduction or other evidence: previously returned { path: [], reason: "invalid_format" }.
User-visible CLI/MCP output: structured validation errors cite capture_path or output_directory.
Remaining proof gaps: none.

For evidence-bearing changes:

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

npx vitest run tests/boundary/filesystem/webScriptExport.test.ts -t "identifies a missing capture file and rejected host path syntax" — passed (1 passed in 34ms)
npm run check:fast (turbo run typecheck lint) — passed cleanly (2/2 tasks successful in 1m21s)

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable.
Package or release metadata impact: none.
Security, privacy, process, or containment review: none.

Author readiness

Human owner: @saiyam-jain-dev

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7097 **Author:** [@saiyam-jain-dev](https://github.com/saiyam-jain-dev) **Created:** 10/25/2026 **Status:** ✅ Merged **Merged:** 10/27/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/web-script-export-path-issues` --- ### 📝 Commits (1) - [`2436891`](https://github.com/morluto/rea/commit/2436891e4e23e8ee451ea14fb1ab388cfd5dcce8) fix(browser): report non-absolute export paths at their input field ### 📊 Changes **2 files changed** (+70 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/application/WebScriptExportService.ts` (+13 -9) 📝 `tests/boundary/filesystem/webScriptExport.test.ts` (+57 -3) </details> ### 📄 Description ## Summary When caller-supplied paths to `export_web_scripts` (`capture_path` or `output_directory`) are relative, `WebScriptExportService` previously emitted a single generic issue with an empty issue path (`path: []`) and a combined message `"capture_path and output_directory must be absolute filesystem paths on this host."` even if only one of them was relative. This PR reports non-absolute paths at their respective field (`["capture_path"]` and/or `["output_directory"]`), matching the established boundary issue reporting pattern across REA. ## Problem and expected behavior Previously, passing a relative `capture_path` or `output_directory` returned: ```json { "path": [], "reason": "invalid_format", "message": "capture_path and output_directory must be absolute filesystem paths on this host." } ``` Consumers could not determine from the structured issue which argument violated the absolute path requirement. The expected behavior is that each invalid field is reported with its own issue targeting `["capture_path"]` or `["output_directory"]`. ## Change and scope - Updated `exportWebScriptsValidated` in `src/application/WebScriptExportService.ts` to inspect `capture_path` and `output_directory` individually and return targeted `AnalysisInputIssue` records for each invalid field. - Added boundary assertions to `tests/boundary/filesystem/webScriptExport.test.ts` verifying issue paths and reasons when `capture_path` is relative, `output_directory` is relative, or both are relative. Contribution scope fit: ordinary boundary fix within existing boundaries (not applicable). ## Contract and boundary impact - Semantic owner and earliest changed stage: `src/application/WebScriptExportService.ts` input validation. - Contribution scope fit and linked maintainer decision: not applicable. - CLI and MCP/tool-catalog contract: structured `AnalysisInputError` now identifies `capture_path` and/or `output_directory` in `issues[].path`. - Provider, bridge, target-format, or platform compatibility: platform-independent. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details (if applicable): none. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact: none. Expected effects: - [x] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: `tests/boundary/filesystem/webScriptExport.test.ts` - Base reproduction or other evidence: previously returned `{ path: [], reason: "invalid_format" }`. - User-visible CLI/MCP output: structured validation errors cite `capture_path` or `output_directory`. - Remaining proof gaps: none. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npx vitest run tests/boundary/filesystem/webScriptExport.test.ts -t "identifies a missing capture file and rejected host path syntax"` — passed (1 passed in 34ms) - `npm run check:fast` (`turbo run typecheck lint`) — passed cleanly (2/2 tasks successful in 1m21s) ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none. ## Author readiness Human owner: @saiyam-jain-dev - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-03 13:39:18 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7638

No description provided.

Rows
Columns