mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-11-03 13:39:25 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7657
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/7124
Author: @kaoru0822-kitauji
Created: 10/25/2026
Status: ✅ Merged
Merged: 10/25/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:fix/7110-jsonl-shape-refusal📝 Commits (2)
e1437ecfix(cli): report JSON Lines selection refusals as caller errorsf8d3f1ffix(cli): carry JSON Lines refusal facts as structured observations📊 Changes
13 files changed (+516 additions, -95 deletions)
View changed files
📝
docs/cli.md(+8 -3)📝
src/cli/cliResultOutput.ts(+1 -0)📝
src/cli/jsonLines.ts(+208 -60)📝
src/cli/jsonLinesOutput.ts(+5 -0)📝
src/domain/analysisErrorCore.ts(+9 -1)📝
src/domain/analysisErrorPresentation.ts(+4 -1)📝
src/domain/analysisErrorProjection.ts(+1 -0)📝
src/domain/explicitSensitiveFailure.ts(+3 -0)📝
tests/acceptance/jsonLinesCli.test.ts(+94 -0)📝
tests/acceptance/managedCliOutput.test.ts(+13 -2)📝
tests/boundary/cli/javascriptApplicationJsonOutput.test.ts(+12 -3)📝
tests/boundary/cli/jsonLinesOutput.test.ts(+157 -24)📝
tests/boundary/cli/jsonOutput.test.ts(+1 -1)📄 Description
What broke: a
--format jsonlrefusal of a selection that is not a record collection was reported asunreadable_output/execution_failurewith "Runrea doctor", although the analysis succeeded (--format jsonexits 0).Fix: the JSON Lines owner (
src/cli/jsonLines.ts) now refuses withAnalysisInputError→invalid_request/invalid_input, naming the selection and its observed shape, and keeps the--format json/--filter-outputremediation; docs say columnar SQLite rows are not a record collection.Risk: low. The admission rules are unchanged and exit status stays 1. Only the error code, category and message change, so callers matching
unreadable_outputon JSONL refusals have to switch toinvalid_request.Summary
Fixes #7110.
When
--format jsonlis refused, the cause is the caller's output selection, not the analysis. The refusal is now a typed caller error, so agents that branch oncode/categoryno longer treat a successful analysis as failed, and they are no longer pointed atrea doctor.Problem and expected behavior
Trigger (base
bc143125e, built CLI):Before:
After:
Change and scope
src/cli/jsonLines.ts(owner of JSON Lines admission): all refusals (no collection, several collections, reserved$reacollision) are nowAnalysisInputError. The issue path is["filter-output"]when a filter was given and["format"]otherwise. A singleexamineBoundarieswalk over the documented boundaries (result,page,normalized_result,normalized_result.page) now produces both the admitted collections and the refusal facts. It replacescollections/documentCollections, so admission behavior is identical. The messages contain only fixed field names and the caller's own filter keys, never target data.details.issues[].observed, as[{path, shape}]with shape one ofabsent|null|array|object|string|number|boolean. Callers can read the location and shape without parsing the message, and the message is built from these facts.AnalysisInputIssuegains this optionalobservedfield: the error projection outputs it, and the sensitive-value redaction copy redacts it.src/domain/analysisErrorCore.ts/analysisErrorPresentation.ts:AnalysisInputErrortakes an optionalremediationAction, the same optionAnalysisOutputError,AnalysisUnsupportedTargetErrorand others already have. Without it, the generic input-contract advice is unchanged.src/cli/cliResultOutput.ts/jsonLinesOutput.ts: pass the already parsed--filter-outputpaths through, so the refusal can name the selection without parsing it again.docs/cli.md: documents the caller-error classification. It also states that a columnar object such asinspect-sqlite-database --table'snormalized_result.rows({columns, values}) is not a record collection, and narrows thenormalized_result.rowsexample to analysis views.Intentionally not included:
{columns, values}into one object per row. Nothing else in the codebase reads SQLite rows that way, and duplicate column names are allowed (columnshas no uniqueness constraint), so the conversion would be ambiguous. Use--format jsonfor these results.normalized_result.schema.tablesornormalized_result.imports.items. The documented boundary rule is unchanged; these are now refused with a clear caller error.mcp doctorrenders a single document), so MCP is unaffected.Contribution scope: ordinary fix within existing boundaries; maintainer scope decision not applicable.
Contract and boundary impact
Semantic owner and earliest changed stage: the CLI JSON Lines projection (
prepareJsonLines), plus an additive option on theAnalysisInputErrordomain error. The supersededcollections/documentCollectionshelpers were removed.Contribution scope fit and linked maintainer decision: not applicable (bug fix).
CLI and MCP/tool-catalog contract: on the CLI, JSONL refusal records change
code/category/message/detailsto the existinginvalid_requestprojection. Exit status stays 1. MCP: none.Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none; successful JSONL records and metadata are unchanged.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata, package, or installation impact: none (
docs:checkpasses; the error schema already includesinvalid_request).Documentation or usability only; no target interaction.
Evidence and regression coverage
tests/boundary/cli/jsonLinesOutput.test.ts: each refusal asserts the classification (invalid_request/invalid_input), the issuepath/reason, the structuredobservedfacts, and that the remediation equals the owning constantJSON_LINES_SELECTION_REMEDIATION. No explanatory prose is asserted. A mutation check confirmed the tests are sensitive to facts, not wording: rewording the message still passed (44/44), and reporting a wrong shape failed (2 failed). Cases covered:normalized_result.pagecollectionrows, and a$reacollision in both a collection and a top-level array--full-outputboundary paths, and filters that match nothing, a scalar, null, a nested array, a columnar object, several collections, or several non-collection pathsrowsof primitives and arrays, empty top-level arrays (no lines), and empty collections (metadata only)tests/acceptance/jsonLinesCli.test.ts: the real built CLI against a real SQLite database runs the issue's rows (default,--table … --filter-output normalized_result.rows,--filter-output normalized_result.schema.tables), asserting structured facts, with--jsonexiting 0. For both the non-empty and the empty analysis-view requests, it checks that the documented--filter-output normalized_result.rowsexport emits exactly the same rows as the unfiltered export.tests/acceptance/managedCliOutput.test.ts,tests/boundary/cli/javascriptApplicationJsonOutput.test.ts,tests/boundary/cli/jsonOutput.test.ts.bc143125ethroughscripts/rea.mjs(eachunreadable_output, exit 1). That includesinspect-macho /System/Applications/Calculator.app --filter-output 'normalized_result.imports.items[0,2]'. After the change all five returninvalid_request/invalid_inputwith exit 1. Two examples of the new messages:normalized_result.rows is null(no--table)The --filter-output selection normalized_result.imports.items is not a JSON Lines record collection: it is an array outside a record collection boundary.Validation performed
--format jsoncontrol) on the base build and the fixed build: the base gaveunreadable_outputon all 5 rows. The fixed build givesinvalid_requeston all 5 rows, and the--format jsoncontrol exits 0.npm run test:focused -- tests/boundary/cli/jsonLinesOutput.test.ts tests/boundary/cli/jsonOutput.test.ts tests/boundary/cli/filteredArrayOutput.test.ts tests/boundary/cli/cliOutput.test.ts tests/boundary/cli/javascriptApplicationJsonOutput.test.ts tests/acceptance/jsonLinesCli.test.ts tests/acceptance/managedCliOutput.test.ts src/domain/analysisErrorProjection.test.ts: 8 files, 270 tests passed. After the later describe split,jsonLinesOutput.test.tswas rerun: 44 passed.npm run test:focusedon the same 8 files plussrc/domain/explicitSensitiveFailure.test.ts: 9 files, 291 tests passed. The issue repro was rerun on the rebuilt CLI: all 5 rows returninvalid_requestwithobservedfacts, and the--format jsoncontrol exits 0.npm run check:fast: passed.npm run format:check: passed.npm run docs:check: passed.Compatibility, safety, and release
unreadable_outputtoinvalid_request(categoryexecution_failure→invalid_input). This corrects a misclassification; scripts matching the old code should matchinvalid_request. Exit status and record framing are unchanged.--filter-outputkeys, never target values.Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.