mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Open
opened 2026-11-03 13:39:38 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7685
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/7160
Author: @AmmarJamil23
Created: 10/25/2026
Status: 🔄 Open
Base:
main← Head:fix/pe-certificate-authenticode-depth📝 Commits (1)
c5b624ffix(pe): admit Authenticode nesting depth of signed Windows binaries📊 Changes
3 files changed (+79 additions, -4 deletions)
View changed files
📝
src/native/pe/PeCertificateAsn1.ts(+7 -1)📝
src/native/pe/PeCertificateParser.test.ts(+30 -0)📝
src/native/pe/PeCertificates.fixture.ts(+42 -3)📄 Description
Summary
inspect_pe_certificates(CLIinspect-pe-certificates) rejected genuine Authenticode signatures on signed Windows system binaries asinvalid_request/PKCS#7 signedData is malformed: ASN.1 nesting exceeds 32 levels., returning no certificate inventory. In a sweep of 860 binaries from a Windows 11 x64C:\Windows\System32(all.exe, alldrivers\*.sys, every fifth.dll), 133 failed this way, includingbcdedit.exeandaudiodg.exe;Get-AuthenticodeSignaturereports each asValid. With this change all 133 return the outer signature's certificate inventory and signer. Since #7920 (rebased onto here), such signers reportcoverage.status: partialwithUNSIGNED_ATTRIBUTES_LIMITATION, because the nested signature and timestamp contents are not yet inventoried (#7767); this PR only removes the depth refusal that hid the outer inventory.No issue is linked: this was found by the sweep above, and searches found no existing report. #6574 (closed) concerned BER indefinite lengths in the same decoder and is a different defect.
Problem and expected behavior
Smallest trigger: any PE whose embedded PKCS#7 nests more than 32 levels. Windows dual signing produces that routinely. An independent DER walk of the
bcdedit.execertificate table (not REA's decoder) gives depth 34 along this path:[1]1.3.6.1.4.1.311.2.4.1(nested signature) holding a second complete SignedData1.3.6.1.4.1.311.3.3.1(RFC 3161 timestamp) holding a third SignedDatasigningCertificateV2(1.2.840.113549.1.9.16.2.47), issuerSerial, GeneralNames, directoryName, Name, RDN, attributeFiles that pass today measure 26 (no nested signature). Violated invariant (AGENTS.md): limits must follow real format constraints. This cap was inherited from the shared reader's default rather than derived from Authenticode, so it rejected valid input as malformed.
Change and scope
PeCertificateAsn1.tsalready owns PE-specific decoding budgets (ASN1_NODE_BUDGET, with a format-based comment) but passed no depth, so it inherited theAsn1BerReaderdefault of 32. The fix gives that owner an explicitASN1_DEPTH_BUDGET = 64, documented from the Authenticode structure: each embedded SignedData adds eight levels, real dual-signed timestamped files reach 34, and 64 still bounds recursion for hostile input. 64 matches the stack budgets of REA's other recursive decoders (protobuf, source maps, CBOR metadata).Intentionally not changed: the shared reader's default and the APK v1 signature reader, which sets its own justified 32-level cap and tests that exceeding it is malformed; how a depth-cap breach is classified (it remains a malformed-input refusal, now only beyond a format-derived bound); and the separate 64 MiB file-size limit, which two files in the sweep (
MRT.exe,OneDriveSetup.exe) still hit asresource_constraint. No speculative complexity is added.Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
Contract and boundary impact
src/native/pe/PeCertificateAsn1.tsreadAsn1(PE certificate decoding budget). Consumers:PeCertificateParserand theinspect_pe_certificatesCLI/MCP workflow. No superseded path; the sharedAsn1BerReaderis unchanged.invalid_request.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none;npm run docs:checkpassed with no generated changes.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
src/native/pe/PeCertificateParser.test.ts: (1) a dual-signed, timestamped fixture (pkcs7DualSignedTimestampedFixture, new inPeCertificates.fixture.ts) parses to the outer signer with its unsigned attribute OID,coverage.status: partialandUNSIGNED_ATTRIBUTES_LIMITATION(the nested envelopes are not inventoried, per #7920); it reproduces thebcdedit.exeembedding path and its depth of 34, verified with the independent DER walk; (2) a payload one level beyondASN1_DEPTH_BUDGETis still rejected with the nesting message.pkcs7SignedDataFixture'sunsignedAttributesargument (from #7920) now also accepts a complete encoded attribute, and an optional fifthsignedAttributesargument was added; existing callers are unchanged.PeCertificateAsn1.tsstashed, both new tests fail, and the dual-signed case fails with the sameASN.1 nesting exceeds 32 levels.refusal seen on the real binaries. Real files: before, 133 of 860 returnedinvalid_request; after (measured before the rebase onto #7920), those 133 returned the inventory with one signer each, the other 725 were unchanged, and the 2 oversize files keep theirresource_constraint.rea inspect-pe-certificates C:\Windows\System32\bcdedit.exe --jsonreturnedcode: invalid_requestwith detailsPKCS#7 signedData is malformed: ASN.1 nesting exceeds 32 levels.; after (rebased on currentmain), it returns the certificate inventory with signerunsigned_attribute_oids: [1.3.6.1.4.1.311.3.3.1, 1.3.6.1.4.1.311.2.4.1],coverage: {status: partial, examined_entries: 1, certificates: 2}andUNSIGNED_ATTRIBUTES_LIMITATION.For boundary fixes, identify the applicable boundary regressions
and lifecycle regressions
covered by the evidence above, and explain relevant gaps.
Boundary coverage: malformed input (the depth cap is still enforced), capacity (node budget unchanged and tested) and real target identity (system binaries) are exercised. Lifecycle regressions are not applicable: the change touches no process, cancellation or cleanup path.
For evidence-bearing changes:
Validation performed
Windows 11 x64, Node.js 24.22.1 (pinned), locked dependencies, and the published
rea-agents@6.8.0Windows native addon (sha512 verified) for the test runner.main(d3ecf6800):npm run test:focused -- src/native/pe/PeCertificateParser.test.ts tests/acceptance/peCertificatesCli.test.ts— 55/55 passed; with the depth argument removed fromreadAsn1, the two new tests fail (ASN.1 nesting exceeds 32 levels.).npm run check:fast,npm run docs:checkandnpm run build:cachedpassed;bcdedit.exeoutput above re-run on the rebased build.npm run test:focused -- src/native/pe/PeCertificateParser.test.ts— 34/34 passed; withPeCertificateAsn1.tsstashed, 2 failed (the two new tests).npm run test:focused -- tests/acceptance/peCertificatesCli.test.ts src/domain/apkSignature/apkV1SignatureBlock.test.ts— passed.npm run test:focused -- tests/boundary/filesystem/peCertificates.test.ts— 1 failed withEPERMcreating a symlink (Windows without Developer Mode); fails identically with the change stashed.npm run test:focused -- tests/boundary/mcp/peCertificatesMcp.test.ts— 1 test timed out at 30 s; times out identically with the change stashed (slow MCP startup on this host).npm run build:cached, theninspect-pe-certificateson the 860 swept binaries — results above.Get-AuthenticodeSignatureon five failing files — allValid.npm run check:fast— passed.npm run docs:check— passed.Compatibility, safety, and release
Author readiness
Human owner: @AmmarJamil23
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.