morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 07:47:29 +00:00

[PR #7266] [MERGED] docs(desktop): name the get_evidence_bundle tool in the MCP section #7798

New issue

Closed

opened 2026-11-05 01:47:44 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-05 01:47:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7266
Author: @XiaoBinGan
Created: 10/26/2026
Status: ✅ Merged
Merged: 10/26/2026
Merged by: @morluto

Base: main ← Head: docs/get-evidence-bundle-name

📝 Commits (1)

33f7598 docs(desktop): name the get_evidence_bundle tool in the MCP section

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docs/desktop-applications.md (+1 -1)

📄 Description

Summary

docs/desktop-applications.md tells readers that complete Evidence stays reachable through get_evidence. No REA tool has that name; the session family registers get_evidence_bundle. A reader or agent following that sentence would call a tool that does not exist.

Problem and expected behavior

Line 56 of the MCP section:

absence in a partial source. Complete Evidence remains accessible through
`get_evidence` and Evidence bundle export.

The registered name is get_evidence_bundle:

src/contracts/sessionToolContracts.ts — session("get_evidence_bundle", …)
src/contracts/toolEffects.ts — get_evidence_bundle: effects()
src/cliCommandNames.ts — the CLI equivalents are inspect-evidence-bundle, evidence-export and evidence-import

There is no tool, CLI command, prompt or resource named get_evidence, and none has ever existed. Every other page already uses the full name: docs/mcp-contracts.md (four places), docs/frida-instrumentation.md, docs/wasm-artifacts.md (two), docs/javascript-route-inventory.md. This line is the only bare get_evidence in docs/.

Expected: the doc names the tool that exists. Actual: it names a truncated form that cannot be called.

Change and scope

One identifier on one line. get_evidence → get_evidence_bundle. Nothing else changes; the surrounding sentence and the adjacent "Evidence bundle export" reference are unaffected.

Intentionally not included: a broader docs sweep. I checked every backticked snake_case token in docs/*.md for prefixes of real tool names and this was the only one.

Contract and boundary impact

Semantic owner and earliest changed stage: none. Documentation only; no source, contract, or generated catalog changes.
Contribution scope fit and linked maintainer decision: not applicable. Single-identifier documentation correction.
CLI and MCP/tool-catalog contract: the document now names the existing tool. No tool, schema, or catalog is changed.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none; the sentence points at the same capability it always described.
Target selection, authority, upstream behavior, and cleanup details (if applicable): none.
Generated metadata (docs/public/product-catalog.json), package, or installation impact: none. docs:check and the product-catalog/completion-ledger --check runs pass unchanged.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

Read existing files or captured data.
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated: none. This is a documentation-only change with no observable runtime behavior.
Base reproduction or other evidence: the claim was checked against four independent sources, with the running server as the authority.
1. Live tools/list on this checkout (229 tools, REA_MCP_OUTPUT_SCHEMA_PROFILE=off): no tool named get_evidence; get_evidence_bundle is present.
2. Contracts: sessionToolContracts.ts registers get_evidence_bundle; toolEffects.ts keys get_evidence_bundle.
3. History: git log -S'get_evidence:' over src/contracts/toolEffects.ts returns nothing — the short name never existed as a tool key.
4. Sweep: across every backticked snake_case token in docs/*.md, exactly one token is a truncated prefix of a real tool name — this line.
User-visible CLI/MCP output (if applicable): none changed.
Remaining proof gaps: none for the claim being corrected.

For boundary fixes: not applicable. No filesystem, process, provider, or lifecycle boundary is involved.

For evidence-bearing changes: not applicable. The change adds or alters no observed, derived, or inferred claim.

Validation performed

node scripts/rea.mjs mcp with an initialize + tools/list exchange — no "name":"get_evidence" in the response; get_evidence_bundle present
git grep -n 'get_evidence' -- docs/ — the only bare occurrence was this line; all others read get_evidence_bundle
npx oxfmt --check docs/desktop-applications.md — exit 0
npm run docs:check — exit 0, 9 tests passed

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable.
Package or release metadata impact: none.
Security, privacy, process, or containment review: none. Documentation only.

Author readiness

Human owner: @XiaoBinGan

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7266 **Author:** [@XiaoBinGan](https://github.com/XiaoBinGan) **Created:** 10/26/2026 **Status:** ✅ Merged **Merged:** 10/26/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `docs/get-evidence-bundle-name` --- ### 📝 Commits (1) - [`33f7598`](https://github.com/morluto/rea/commit/33f7598b83fa2da9025b2fd8ef35c54311d3d4a2) docs(desktop): name the get_evidence_bundle tool in the MCP section ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/desktop-applications.md` (+1 -1) </details> ### 📄 Description ## Summary `docs/desktop-applications.md` tells readers that complete Evidence stays reachable through `get_evidence`. No REA tool has that name; the session family registers `get_evidence_bundle`. A reader or agent following that sentence would call a tool that does not exist. ## Problem and expected behavior Line 56 of the MCP section: ``` absence in a partial source. Complete Evidence remains accessible through `get_evidence` and Evidence bundle export. ``` The registered name is `get_evidence_bundle`: - `src/contracts/sessionToolContracts.ts` — `session("get_evidence_bundle", …)` - `src/contracts/toolEffects.ts` — `get_evidence_bundle: effects()` - `src/cliCommandNames.ts` — the CLI equivalents are `inspect-evidence-bundle`, `evidence-export` and `evidence-import` There is no tool, CLI command, prompt or resource named `get_evidence`, and none has ever existed. Every other page already uses the full name: `docs/mcp-contracts.md` (four places), `docs/frida-instrumentation.md`, `docs/wasm-artifacts.md` (two), `docs/javascript-route-inventory.md`. This line is the only bare `get_evidence` in `docs/`. Expected: the doc names the tool that exists. Actual: it names a truncated form that cannot be called. ## Change and scope One identifier on one line. `get_evidence` → `get_evidence_bundle`. Nothing else changes; the surrounding sentence and the adjacent "Evidence bundle export" reference are unaffected. Intentionally not included: a broader docs sweep. I checked every backticked `snake_case` token in `docs/*.md` for prefixes of real tool names and this was the only one. ## Contract and boundary impact - Semantic owner and earliest changed stage: none. Documentation only; no source, contract, or generated catalog changes. - Contribution scope fit and linked maintainer decision: not applicable. Single-identifier documentation correction. - CLI and MCP/tool-catalog contract: the document now names the existing tool. No tool, schema, or catalog is changed. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: none; the sentence points at the same capability it always described. - Target selection, authority, upstream behavior, and cleanup details (if applicable): none. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact: none. `docs:check` and the product-catalog/completion-ledger `--check` runs pass unchanged. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: none. This is a documentation-only change with no observable runtime behavior. - Base reproduction or other evidence: the claim was checked against four independent sources, with the running server as the authority. 1. **Live `tools/list`** on this checkout (229 tools, `REA_MCP_OUTPUT_SCHEMA_PROFILE=off`): no tool named `get_evidence`; `get_evidence_bundle` is present. 2. **Contracts**: `sessionToolContracts.ts` registers `get_evidence_bundle`; `toolEffects.ts` keys `get_evidence_bundle`. 3. **History**: `git log -S'get_evidence:'` over `src/contracts/toolEffects.ts` returns nothing — the short name never existed as a tool key. 4. **Sweep**: across every backticked `snake_case` token in `docs/*.md`, exactly one token is a truncated prefix of a real tool name — this line. - User-visible CLI/MCP output (if applicable): none changed. - Remaining proof gaps: none for the claim being corrected. For boundary fixes: not applicable. No filesystem, process, provider, or lifecycle boundary is involved. For evidence-bearing changes: not applicable. The change adds or alters no observed, derived, or inferred claim. ## Validation performed - `node scripts/rea.mjs mcp` with an `initialize` + `tools/list` exchange — no `"name":"get_evidence"` in the response; `get_evidence_bundle` present - `git grep -n 'get_evidence' -- docs/` — the only bare occurrence was this line; all others read `get_evidence_bundle` - `npx oxfmt --check docs/desktop-applications.md` — exit 0 - `npm run docs:check` — exit 0, 9 tests passed ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none. Documentation only. ## Author readiness Human owner: @XiaoBinGan - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-05 01:47:44 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7798

No description provided.

Rows
Columns