morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #7322] [CLOSED] test: repair Linux doctor and artifact coverage fixtures #7817

New issue

Closed

opened 2026-11-05 01:47:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-05 01:47:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7322
Author: @Plastic-time
Created: 10/26/2026
Status: ❌ Closed

Base: main ← Head: codex/fix-linux-boundary-fixtures-20261026

📝 Commits (1)

5aa7509 test: repair Linux doctor and artifact coverage fixtures

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 tests/boundary/cli/ghidraJavaDoctor.test.ts (+3 -2)
📝 tests/boundary/mcp/artifactInspectionCoverageMcp.test.ts (+3 -1)

📄 Description

Summary

Repair two boundary-test fixtures that fail on unchanged upstream 57d0ed45 before reaching their intended assertions. These failures also block #5672, but are independent of its ASAR cancellation change.

Problem and expected behavior

The Ghidra cwd-discovery test clears PATH entirely. On Linux, process-ownership admission then fails with spawn ps ENOENT before doctor can inspect the installation. Prefix the host PATH with an empty component so cwd discovery remains exercised and required host tools remain available.
The traversal-coverage fixture declares main.js as its app executable. Binary admission rejects it as an unsupported format. Declare a minimal Mach-O fixture as the executable, retaining the JavaScript resource and both FIFO coverage cases.

All existing assertions remain: selected installation and unexecuted launchers; complete/unknown inventory traversal; and both retained-evidence and direct summary projections.

Contract and boundary impact

The fixture builders own both corrections. Only two test files change; production admission, process supervision, CLI/MCP schemas, evidence, cleanup, and package metadata are unchanged. This is an ordinary test repair within existing scope; no separate maintainer scope decision is applicable. No generated outputs or verification workflows are included.

Tests create temporary files/FIFOs and launch fixture CLI processes. They do not execute real Ghidra launchers or analyze private targets.

Validation performed

Ubuntu 24.04, pinned Node 24.22.1; baseline and candidate executed sequentially on the same runner:

npm run test:focused -- tests/boundary/cli/ghidraJavaDoctor.test.ts tests/boundary/mcp/artifactInspectionCoverageMcp.test.ts: baseline 3 failed / 4 passed with the two errors above; candidate 7 passed.
npm run check:fast: typecheck and lint passed.
Repository oxfmt --check for both changed files: passed on Linux and Windows.
git diff --check: passed.

Successful same-runner baseline/candidate comparison and static checks. The baseline step requires exit 1 and both expected error messages; candidate tests and static checks must exit 0.

Real Ghidra and macOS execution were not tested. Both affected cases are skipped on Windows; Windows results are not used as proof of this fix. Full upstream CI remains pending.

Author readiness

Human owner: @Plastic-time

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7322 **Author:** [@Plastic-time](https://github.com/Plastic-time) **Created:** 10/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/fix-linux-boundary-fixtures-20261026` --- ### 📝 Commits (1) - [`5aa7509`](https://github.com/morluto/rea/commit/5aa7509e1cf852305a3d4da5a1594682b16d3d10) test: repair Linux doctor and artifact coverage fixtures ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/ghidraJavaDoctor.test.ts` (+3 -2) 📝 `tests/boundary/mcp/artifactInspectionCoverageMcp.test.ts` (+3 -1) </details> ### 📄 Description ## Summary Repair two boundary-test fixtures that fail on unchanged upstream `57d0ed45` before reaching their intended assertions. These failures also block #5672, but are independent of its ASAR cancellation change. ## Problem and expected behavior - The Ghidra cwd-discovery test clears PATH entirely. On Linux, process-ownership admission then fails with `spawn ps ENOENT` before doctor can inspect the installation. Prefix the host PATH with an empty component so cwd discovery remains exercised and required host tools remain available. - The traversal-coverage fixture declares `main.js` as its app executable. Binary admission rejects it as an unsupported format. Declare a minimal Mach-O fixture as the executable, retaining the JavaScript resource and both FIFO coverage cases. All existing assertions remain: selected installation and unexecuted launchers; complete/unknown inventory traversal; and both retained-evidence and direct summary projections. ## Contract and boundary impact The fixture builders own both corrections. Only two test files change; production admission, process supervision, CLI/MCP schemas, evidence, cleanup, and package metadata are unchanged. This is an ordinary test repair within existing scope; no separate maintainer scope decision is applicable. No generated outputs or verification workflows are included. Tests create temporary files/FIFOs and launch fixture CLI processes. They do not execute real Ghidra launchers or analyze private targets. ## Validation performed Ubuntu 24.04, pinned Node 24.22.1; baseline and candidate executed sequentially on the same runner: - `npm run test:focused -- tests/boundary/cli/ghidraJavaDoctor.test.ts tests/boundary/mcp/artifactInspectionCoverageMcp.test.ts`: baseline **3 failed / 4 passed** with the two errors above; candidate **7 passed**. - `npm run check:fast`: typecheck and lint passed. - Repository `oxfmt --check` for both changed files: passed on Linux and Windows. - `git diff --check`: passed. [Successful same-runner baseline/candidate comparison and static checks](https://github.com/Plastic-time/rea/actions/runs/40419494379/job/121910074164). The baseline step requires exit 1 and both expected error messages; candidate tests and static checks must exit 0. Real Ghidra and macOS execution were not tested. Both affected cases are skipped on Windows; Windows results are not used as proof of this fix. Full upstream CI remains pending. ## Author readiness Human owner: @Plastic-time - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-05 01:47:54 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7817

No description provided.

Rows
Columns