morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 07:47:29 +00:00

[PR #7335] [CLOSED] test: bind extraction close fixtures to their ZIP digest #7820

New issue

Closed

opened 2026-11-05 01:47:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-05 01:47:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7335
Author: @Plastic-time
Created: 10/26/2026
Status: ❌ Closed

Base: main ← Head: codex/fix-extraction-close-fixture-20261026

📝 Commits (1)

626d025 test: bind extraction close fixtures to their ZIP digest

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 tests/boundary/filesystem/safeOutputTreeCloseFailures.test.ts (+3 -2)

📄 Description

Summary

The two safeOutputTreeCloseFailures extraction cases pass an all-zero target digest for a real ZIP. Admitted-source validation rejects the fixture before either injected commit-close failure is reached.

Hash the same ZIP bytes written to disk when constructing the test client. Preserve the assertions for:

A transient close failure: cleanup retries succeed and committed output survives.
A persistent close failure: incomplete cleanup and the partial extraction are retained; a later client close succeeds and output survives.

Scope

One test file changes. The fixture owns the correction; production digest validation, extraction, cleanup ownership, evidence, CLI/MCP contracts, and package metadata are unchanged. Tests use a generated ZIP and temporary output. This is an ordinary test repair within existing scope; a separate maintainer scope decision is not applicable.

Validation

Same-runner Linux baseline, independent fixes, and combined verification: Ubuntu 24.04, Node 24.22.1, unchanged baseline 046c4ce3, this candidate 626d0250.

npm run test:focused -- tests/composition/analysis-sessions/providerBinding.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/filesystem/safeOutputTreeCloseFailures.test.ts: baseline 48 passed / 3 failed; this fix alone 50 passed / 1 failed. All 6 close-failure tests pass.
The remaining failure is the independently reproduced provider-routing fixture addressed by #7336. Applying both independent fixes gives 51 passed.
npm run check:fast, repository oxfmt --check, and git diff --check: passed.

Windows/macOS and real external providers were not run. Full upstream CI is separate from this focused comparison.

Author readiness

Human owner: @Plastic-time

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7335 **Author:** [@Plastic-time](https://github.com/Plastic-time) **Created:** 10/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/fix-extraction-close-fixture-20261026` --- ### 📝 Commits (1) - [`626d025`](https://github.com/morluto/rea/commit/626d0250dbfe07fc55fe17686b0bc437c510b32b) test: bind extraction close fixtures to their ZIP digest ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/filesystem/safeOutputTreeCloseFailures.test.ts` (+3 -2) </details> ### 📄 Description ## Summary The two `safeOutputTreeCloseFailures` extraction cases pass an all-zero target digest for a real ZIP. Admitted-source validation rejects the fixture before either injected commit-close failure is reached. Hash the same ZIP bytes written to disk when constructing the test client. Preserve the assertions for: - A transient close failure: cleanup retries succeed and committed output survives. - A persistent close failure: incomplete cleanup and the partial extraction are retained; a later client close succeeds and output survives. ## Scope One test file changes. The fixture owns the correction; production digest validation, extraction, cleanup ownership, evidence, CLI/MCP contracts, and package metadata are unchanged. Tests use a generated ZIP and temporary output. This is an ordinary test repair within existing scope; a separate maintainer scope decision is not applicable. ## Validation [Same-runner Linux baseline, independent fixes, and combined verification](https://github.com/Plastic-time/rea/actions/runs/40422719542/job/121920818011): Ubuntu 24.04, Node 24.22.1, unchanged baseline `046c4ce3`, this candidate `626d0250`. - `npm run test:focused -- tests/composition/analysis-sessions/providerBinding.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/filesystem/safeOutputTreeCloseFailures.test.ts`: baseline 48 passed / 3 failed; this fix alone 50 passed / 1 failed. All 6 close-failure tests pass. - The remaining failure is the independently reproduced provider-routing fixture addressed by #7336. Applying both independent fixes gives 51 passed. - `npm run check:fast`, repository `oxfmt --check`, and `git diff --check`: passed. Windows/macOS and real external providers were not run. Full upstream CI is separate from this focused comparison. ## Author readiness Human owner: @Plastic-time - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-05 01:47:54 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7820

No description provided.

Rows
Columns