[PR #7336] [CLOSED] test: exercise admitted bundle identity in provider routing #7821

New issue

Closed

opened 2026-11-05 01:47:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-05 01:47:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7336
Author: @Plastic-time
Created: 10/26/2026
Status: ❌ Closed

Base: main ← Head: codex/fix-provider-bundle-fixture-20261026

📝 Commits (2)

00aa17f test: use an admitted app bundle for provider routing
8658353 test: keep bundle routing coverage outside oversized group

📊 Changes

1 file changed (+42 additions, -24 deletions)

View changed files

📝 tests/composition/analysis-sessions/providerBinding.test.ts (+42 -24)

📄 Description

Summary

The bundle-root routing test opens a plain .hop file while its auxiliary provider reports a different directory digest. After admitted-subject validation was tightened, that fixture is correctly rejected before it can exercise bundle-root preservation.

Create a minimal app bundle with an Info.plist and inert Mach-O executable. Assert the selected executable, bundle root, and plist identity, then retain the existing directory-subject assertions. Close the session through the test cleanup hook. Move this case outside the existing group to keep that group's callback within the repository lint limit.

Scope

One test file changes. The fixture owns the correction; production subject validation, provider routing, evidence, CLI/MCP contracts, and package metadata are unchanged. Tests create temporary fixture files and use simulated providers; they do not execute the fixture binary. This is an ordinary test repair; a separate maintainer scope decision is not applicable.

Validation

Same-runner Linux baseline, independent fixes, and combined verification: Ubuntu 24.04, Node 24.22.1, unchanged baseline 046c4ce3, this candidate 8658353b.

npm run test:focused -- tests/composition/analysis-sessions/providerBinding.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/filesystem/safeOutputTreeCloseFailures.test.ts: baseline 48 passed / 3 failed; this fix alone 49 passed / 2 failed. All 5 provider-binding tests pass.
The remaining two failures are the independent extraction-close fixtures addressed by #7335. Applying both fixes gives 51 passed.
npm run check:fast, repository oxfmt --check, and git diff --check: passed.

Windows/macOS and real external providers were not run. Full upstream CI is separate from this focused comparison.

Author readiness

Human owner: @Plastic-time

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7336 **Author:** [@Plastic-time](https://github.com/Plastic-time) **Created:** 10/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/fix-provider-bundle-fixture-20261026` --- ### 📝 Commits (2) - [`00aa17f`](https://github.com/morluto/rea/commit/00aa17f12a1f9db0205fe82104d14e93bec63bdd) test: use an admitted app bundle for provider routing - [`8658353`](https://github.com/morluto/rea/commit/8658353b0d0bce41c9f2501e048622b98775b641) test: keep bundle routing coverage outside oversized group ### 📊 Changes **1 file changed** (+42 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `tests/composition/analysis-sessions/providerBinding.test.ts` (+42 -24) </details> ### 📄 Description ## Summary The bundle-root routing test opens a plain `.hop` file while its auxiliary provider reports a different directory digest. After admitted-subject validation was tightened, that fixture is correctly rejected before it can exercise bundle-root preservation. Create a minimal app bundle with an `Info.plist` and inert Mach-O executable. Assert the selected executable, bundle root, and plist identity, then retain the existing directory-subject assertions. Close the session through the test cleanup hook. Move this case outside the existing group to keep that group's callback within the repository lint limit. ## Scope One test file changes. The fixture owns the correction; production subject validation, provider routing, evidence, CLI/MCP contracts, and package metadata are unchanged. Tests create temporary fixture files and use simulated providers; they do not execute the fixture binary. This is an ordinary test repair; a separate maintainer scope decision is not applicable. ## Validation [Same-runner Linux baseline, independent fixes, and combined verification](https://github.com/Plastic-time/rea/actions/runs/40422719542/job/121920818011): Ubuntu 24.04, Node 24.22.1, unchanged baseline `046c4ce3`, this candidate `8658353b`. - `npm run test:focused -- tests/composition/analysis-sessions/providerBinding.test.ts src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts tests/boundary/filesystem/safeOutputTreeCloseFailures.test.ts`: baseline 48 passed / 3 failed; this fix alone 49 passed / 2 failed. All 5 provider-binding tests pass. - The remaining two failures are the independent extraction-close fixtures addressed by #7335. Applying both fixes gives 51 passed. - `npm run check:fast`, repository `oxfmt --check`, and `git diff --check`: passed. Windows/macOS and real external providers were not run. Full upstream CI is separate from this focused comparison. ## Author readiness Human owner: @Plastic-time - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-05 01:47:54 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7821

No description provided.

Rows
Columns