morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #7462] [MERGED] fix(docs): preserve verification reports after experiment archival #7851

New issue

Closed

opened 2026-11-05 01:48:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-05 01:48:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/7462
Author: @gensokyo-dev
Created: 10/27/2026
Status: ✅ Merged
Merged: 10/27/2026
Merged by: @gensokyo-dev

Base: main ← Head: refactor/7458-analysis-verification-homes

📝 Commits (2)

97244c0 fix(docs): preserve verification reports after experiment archival
258efe1 fix(docs): link retained receipt source from rendered report

📊 Changes

7 files changed (+44 additions, -11 deletions)

View changed files

📝 docs/testing.md (+3 -2)
📝 docs/verification/analysis-efficiency/mcp-integer-allocation.json (+0 -0)
📝 docs/verification/analysis-efficiency/mcp-integer-allocation.md (+11 -4)
📝 tests/conformance/readmeConsistency.test.ts (+1 -1)
➕ tests/support/analysis-efficiency/README.md (+23 -0)
📝 tests/support/analysis-efficiency/mcp-integer-report.mjs (+6 -2)
📝 turbo.json (+0 -2)

📄 Description

Summary

Fixes #7458. After the experiment archive in 365fb03e7, the retained allocation study still lived in test support, linked to a removed local study, and documented a removed report-generation command.

Move the report and byte-identical receipt JSON to docs/verification/analysis-efficiency/. Retarget its existing producer and conformance consumer, distinguish current regeneration from historical cohort reproduction, and document the retained test helpers. Remove obsolete experiment lint-input globs; test-support JavaScript remains covered by the existing tests/** input.

No production analysis, CLI/MCP contract, cache, default, or provider-authority changes. Historical measurements retain their original scope and identities. Receipt SHA-256 remains 76b440c4b0c4d282c241c42c5ca9c8371223067eb985e0f2aae6437c86ca9378.

Validation

Baseline and candidate: 7 focused files / 141 tests passed, including stale-report and missing-marker rejection, comparison/oracle semantics, and Electron once behavior.
npm run test:python: 42 bridge checks and 93 retained-support checks passed.
Full typecheck passed with --checkers 1 --maxMemory 2G; changed-file single-thread lint, module boundaries (3,242 source files), and discovery (2,663 tests, exactly once) passed.
Documentation checks, the VitePress documentation build, and the 9 report/README conformance tests passed. The final report conformance cases and rendered-page receipt link were checked again after the receipt-link fix on the submitted source. Report generation/check and local link checks passed; historical JSON was verified byte-for-byte.
Turbo dry-run confirms retained test-support JavaScript remains a lint cache input.
Real /usr/bin/bash: CLI and production SDK stdio MCP byte-entropy facts matched an independent Python histogram/SHA-256 oracle. Complete MCP Evidence export matched the original record and cleanup succeeded. Targets were not executed. Single-CPU observations: CLI 3.673 s wall / 3.462 s family CPU / 184.5 MiB family peak; MCP task 8.215 s / 7.961 s / 474.8 MiB, including discovery, binding checks and export. These are smoke observations, not a speedup claim; model token usage, controlled cold/warm comparisons, and external engines were not measured.

Focused candidate checks peaked at 886 MiB. Full local lint exceeded the 3 GiB early-stop guard, including with one lint thread; it was stopped before the 4 GiB hard cap without OOM. The combined check:fast attempt is also recorded as interrupted, not passing. Full submitted-head lint passed in CI. Focused/Python/type checks above ran before rebasing onto 0676ad254; submitted-head CI remains required.

CI attribution

The submitted-head CI run completed. Static checks (including full lint), documentation, and package/native builds passed. Shard 8 failed; the other 7 built-test shards were cancelled by the matrix and are not counted as passed. Their full coverage remains unverified in this run. Unselected lanes are not claimed as executed.

Failing job	Attribution evidence
Source tests: 17 failures	A clean detached worktree at the exact CI base `0676ad254c206871e0f4b120ba300cbbf9383b62` reproduces the identical 17 failure names across Apple inventory/provider binding and Windows native-loader tests; 49 selected tests pass. Control peak 622.6 MiB, no resource abort.
Windows capability lane: 15 failures	The existing main Windows job has exactly the same 15 failure names and 12 grouped error headlines.
Built shard 8: 14 failures	The existing main shard-8 job has exactly the same 14 failure names and 12 grouped error headlines.
Seven cancelled built-test shards	Cancelled in the same matrix after shard 8 failed; not counted as executed successfully or as equivalent full-suite coverage.
Portable / required aggregates	Portable contains exactly the already-attributed 31 source/shard failure names; the required gate propagates the unsuccessful/cancelled jobs.

The historical main CI run is at e99b6c2c3; the intervening base changes affect GPU code-object views/tests and client documentation, not the failing paths. None of the failing implementation or test paths is changed by this PR. No unrelated fixture or implementation repair is included.

Greptile reviewed all 7 changed files with 0 comments. Codex review could not run because the repository review quota is exhausted; it is not counted as passed. The requester explicitly authorized bypassing established main failures after the other checks finish.

Author readiness

Human owner: @gensokyo-dev

The requester explicitly directed entry of these declarations and authorized ready-for-review submission and merge. Technical diff review and validation were performed by Codex; no independently observed human review is claimed.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/7462 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/27/2026 **Status:** ✅ Merged **Merged:** 10/27/2026 **Merged by:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Base:** `main` ← **Head:** `refactor/7458-analysis-verification-homes` --- ### 📝 Commits (2) - [`97244c0`](https://github.com/morluto/rea/commit/97244c0dd111a6cacfde79e4781c0985e1641da8) fix(docs): preserve verification reports after experiment archival - [`258efe1`](https://github.com/morluto/rea/commit/258efe1e8d0fb56ce815c69f9402e4f25981a2cb) fix(docs): link retained receipt source from rendered report ### 📊 Changes **7 files changed** (+44 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `docs/testing.md` (+3 -2) 📝 `docs/verification/analysis-efficiency/mcp-integer-allocation.json` (+0 -0) 📝 `docs/verification/analysis-efficiency/mcp-integer-allocation.md` (+11 -4) 📝 `tests/conformance/readmeConsistency.test.ts` (+1 -1) ➕ `tests/support/analysis-efficiency/README.md` (+23 -0) 📝 `tests/support/analysis-efficiency/mcp-integer-report.mjs` (+6 -2) 📝 `turbo.json` (+0 -2) </details> ### 📄 Description ## Summary Fixes #7458. After the experiment archive in `365fb03e7`, the retained allocation study still lived in test support, linked to a removed local study, and documented a removed report-generation command. Move the report and byte-identical receipt JSON to `docs/verification/analysis-efficiency/`. Retarget its existing producer and conformance consumer, distinguish current regeneration from historical cohort reproduction, and document the retained test helpers. Remove obsolete experiment lint-input globs; test-support JavaScript remains covered by the existing `tests/**` input. No production analysis, CLI/MCP contract, cache, default, or provider-authority changes. Historical measurements retain their original scope and identities. Receipt SHA-256 remains `76b440c4b0c4d282c241c42c5ca9c8371223067eb985e0f2aae6437c86ca9378`. ## Validation - Baseline and candidate: 7 focused files / 141 tests passed, including stale-report and missing-marker rejection, comparison/oracle semantics, and Electron once behavior. - `npm run test:python`: 42 bridge checks and 93 retained-support checks passed. - Full typecheck passed with `--checkers 1 --maxMemory 2G`; changed-file single-thread lint, module boundaries (3,242 source files), and discovery (2,663 tests, exactly once) passed. - Documentation checks, the VitePress documentation build, and the 9 report/README conformance tests passed. The final report conformance cases and rendered-page receipt link were checked again after the receipt-link fix on the submitted source. Report generation/check and local link checks passed; historical JSON was verified byte-for-byte. - Turbo dry-run confirms retained test-support JavaScript remains a lint cache input. - Real `/usr/bin/bash`: CLI and production SDK stdio MCP byte-entropy facts matched an independent Python histogram/SHA-256 oracle. Complete MCP Evidence export matched the original record and cleanup succeeded. Targets were not executed. Single-CPU observations: CLI 3.673 s wall / 3.462 s family CPU / 184.5 MiB family peak; MCP task 8.215 s / 7.961 s / 474.8 MiB, including discovery, binding checks and export. These are smoke observations, not a speedup claim; model token usage, controlled cold/warm comparisons, and external engines were not measured. Focused candidate checks peaked at 886 MiB. Full local lint exceeded the 3 GiB early-stop guard, including with one lint thread; it was stopped before the 4 GiB hard cap without OOM. The combined `check:fast` attempt is also recorded as interrupted, not passing. Full submitted-head lint passed in CI. Focused/Python/type checks above ran before rebasing onto `0676ad254`; submitted-head CI remains required. ## CI attribution The [submitted-head CI run](https://github.com/morluto/rea/actions/runs/40462475909) completed. Static checks (including full lint), documentation, and package/native builds passed. Shard 8 failed; the other 7 built-test shards were cancelled by the matrix and are **not counted as passed**. Their full coverage remains unverified in this run. Unselected lanes are not claimed as executed. | Failing job | Attribution evidence | | --- | --- | | Source tests: 17 failures | A clean detached worktree at the exact CI base `0676ad254c206871e0f4b120ba300cbbf9383b62` reproduces the identical 17 failure names across Apple inventory/provider binding and Windows native-loader tests; 49 selected tests pass. Control peak 622.6 MiB, no resource abort. | | Windows capability lane: 15 failures | The [existing main Windows job](https://github.com/morluto/rea/actions/runs/40460039214/job/122045604125) has exactly the same 15 failure names and 12 grouped error headlines. | | Built shard 8: 14 failures | The [existing main shard-8 job](https://github.com/morluto/rea/actions/runs/40460039214/job/122045167224) has exactly the same 14 failure names and 12 grouped error headlines. | | Seven cancelled built-test shards | Cancelled in the same matrix after shard 8 failed; not counted as executed successfully or as equivalent full-suite coverage. | | Portable / required aggregates | Portable contains exactly the already-attributed 31 source/shard failure names; the required gate propagates the unsuccessful/cancelled jobs. | The historical main CI run is at `e99b6c2c3`; the intervening base changes affect GPU code-object views/tests and client documentation, not the failing paths. None of the failing implementation or test paths is changed by this PR. No unrelated fixture or implementation repair is included. Greptile reviewed all 7 changed files with 0 comments. Codex review could not run because the repository review quota is exhausted; it is not counted as passed. The requester explicitly authorized bypassing established main failures after the other checks finish. ## Author readiness Human owner: @gensokyo-dev The requester explicitly directed entry of these declarations and authorized ready-for-review submission and merge. Technical diff review and validation were performed by Codex; no independently observed human review is claimed. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-05 01:48:07 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#7851

No description provided.

Rows
Columns