[GH-ISSUE #152] UnknownRegistry keeps revision history map without read-path usage #99

New issue

Closed

opened 2026-10-15 18:21:06 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-15 18:21:06 +00:00

Owner

Originally created by @morluto on GitHub (Jul 14, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/152

src/application/UnknownRegistry.ts tracks every revision in #revisions, but there is no read/query API that exposes historical revisions.

Observed:

#revisions only used for size checks and write operations.
History retrieval methods only expose current heads via #heads (listUnknowns, get, has, verifyUnknownResolution).

Evidence:

src/application/UnknownRegistry.ts:41 declares #revisions.
src/application/UnknownRegistry.ts:130-132 only clears it.
src/application/UnknownRegistry.ts:146-151 only writes to it.

Potential risk:

Revision history is collected but not consumed, making this state dead and increasing memory usage because every update keeps growing map entries.

Suggested cleanup:

Either expose revision history for audit/inspection, or remove #revisions and enforce limits on current heads only.

Originally created by @morluto on GitHub (Jul 14, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/152 `src/application/UnknownRegistry.ts` tracks every revision in `#revisions`, but there is no read/query API that exposes historical revisions. Observed: - `#revisions` only used for size checks and write operations. - History retrieval methods only expose current heads via `#heads` (`listUnknowns`, `get`, `has`, `verifyUnknownResolution`). Evidence: - `src/application/UnknownRegistry.ts:41` declares `#revisions`. - `src/application/UnknownRegistry.ts:130-132` only clears it. - `src/application/UnknownRegistry.ts:146-151` only writes to it. Potential risk: - Revision history is collected but not consumed, making this state dead and increasing memory usage because every update keeps growing map entries. Suggested cleanup: - Either expose revision history for audit/inspection, or remove `#revisions` and enforce limits on current heads only.

bsakaguchi

2026-10-15 18:21:06 +00:00

closed this issue
added the
P3: low

triage

area: domain

enhancement
labels

bsakaguchi commented

2026-10-15 18:21:08 +00:00

Author

Owner

@morluto commented on GitHub (Jul 17, 2026):

Superseded by the EvidenceLedger implementation. The standalone UnknownRegistry and its unused revision-history map no longer exist; EvidenceLedger retains revisions for bundle integrity and current-head reconstruction.

@morluto commented on GitHub (Jul 17, 2026): Superseded by the EvidenceLedger implementation. The standalone UnknownRegistry and its unused revision-history map no longer exist; EvidenceLedger retains revisions for bundle integrity and current-head reconstruction.

bsakaguchi referenced this issue

2026-10-15 18:21:45 +00:00

[GH-ISSUE #267] Add approval-gated managed-runtime characterization #156

bsakaguchi referenced this issue

2026-10-15 18:21:47 +00:00

[GH-ISSUE #268] Build an evidence-backed reconstruction workspace and coverage closure workflow #157

bsakaguchi referenced this issue

2026-10-15 18:24:29 +00:00

[GH-ISSUE #1050] [Feature] Add caller-selected views for large analysis results over MCP #384

bsakaguchi referenced this issue

2026-10-16 21:11:45 +00:00

[PR #125] [MERGED] feat(mcp): expose progress, resources, and availability #1848