[PR #1] [MERGED] Minor fixes #15

New issue

Closed

opened 2026-10-31 21:01:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-10-31 21:01:43 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/muerrilla/sd-webui-detail-daemon/pull/1
Author: @w-e-w
Created: 5/14/2024
Status: ✅ Merged
Merged: 5/14/2024
Merged by: @muerrilla

Base: main ← Head: minor-fixes

---

📝 Commits (6)

• f90c0b8 git ignore pycache
• 3bb4389 remove unnecessary install script
• e85e0ab remove unused Imports
• fbb3f4e switch to InputAccordion
• 0fa6321 use class for css
• ae7dcf7 compact infotext

📊 Changes

4 files changed (+49 additions, -81 deletions)

View changed files

➕ .gitignore (+1 -0)
➖ install.py (+0 -9)
📝 scripts/detail_daemon.py (+41 -51)
📝 style.css (+7 -21)

📄 Description

• https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/pull/315#issuecomment-2109846694

---

unnecessary

• remove unused Imports

• remove unnecessary install script
  numpy matplotlib are sub dependencies of web UI
  so there's no point of installing them yourself
  numpy is it dependency of losts of packages and matplotlib is a dependency of gradio

---

UI fixes

there are ways of making your versions work if you prefer your version but this way is simpler

• switch to InputAccordion
  using the webui custom gradio component InputAccordion an Accordion with checkbox
  as opposed to using the custom JavaScript activation color change you've created yourself
  
  circumvents the issue where you have multiple elements of the same ID across different tabs causeing togging the img2img enable will chenge the color of the txt2img accordion

• use class for css
  use class to specify these styles as opposed to using ID, it's also circumvents the issue where you have multiple elements of the same ID across different tabs

---

if for some reason in the future or in other extensions you do need elem_id then use self.elem_id('XXX') to create the id

---

video

before video

https://github.com/muerrilla/sd-webui-detail-daemon/assets/40751091/02fda1bc-de8f-4e90-b0e8-a8510b13f87b

after video

https://github.com/muerrilla/sd-webui-detail-daemon/assets/40751091/87aa5caf-64d4-45c6-919c-04805b0fe71b

---

optional change

remove this if you don't like it

• compact infotext
  theres is no issue with the current implementation but I feel like it's taking up lots of space
  I feel it makes sence to compact all of the info into one key removing the need of adding so many DD_xxxxxx
  note: has backwards compatibility with old format

before PR

DD_enabled: True, DD_amount: 0.5, DD_start: 0, DD_end: 1, DD_bias: 0.5, DD_exponent: 1, DD_start_offset: 0, DD_end_offset: 0, DD_fade: 0, DD_smooth: True

after PR

Detail Daemon: "amount:0.5,st:0,ed:1,bias:0.5,exp:1,st_offset:0,ed_offset:0,fade:0,smooth:1"

if you don't like my abbreviations change it

---

I think every commit in this PR is Cherry Pickable if you don't like a certain change

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/muerrilla/sd-webui-detail-daemon/pull/1 **Author:** [@w-e-w](https://github.com/w-e-w) **Created:** 5/14/2024 **Status:** ✅ Merged **Merged:** 5/14/2024 **Merged by:** [@muerrilla](https://github.com/muerrilla) **Base:** `main` ← **Head:** `minor-fixes` --- ### 📝 Commits (6) - [`f90c0b8`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/f90c0b875be5fff80108b9b73931f71f0172e8e0) git ignore __pycache__ - [`3bb4389`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/3bb43896426f282742e951b28aac9bf5da0e725b) remove unnecessary install script - [`e85e0ab`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/e85e0ab49d5f3e6d6be7edfca447036f4d0a0504) remove unused Imports - [`fbb3f4e`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/fbb3f4e74991e82cbf4cefdcf95b7160851016c0) switch to InputAccordion - [`0fa6321`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/0fa632198ee84380ef29f3112f90f3cf9de28ab4) use class for css - [`ae7dcf7`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/ae7dcf78615d1b49951de4a4323cba220a5cbee0) compact infotext ### 📊 Changes **4 files changed** (+49 additions, -81 deletions) <details> <summary>View changed files</summary> ➕ `.gitignore` (+1 -0) ➖ `install.py` (+0 -9) 📝 `scripts/detail_daemon.py` (+41 -51) 📝 `style.css` (+7 -21) </details> ### 📄 Description - https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/pull/315#issuecomment-2109846694 --- unnecessary - [remove unused Imports](https://github.com/muerrilla/sd-webui-detail-daemon/commit/e85e0ab49d5f3e6d6be7edfca447036f4d0a0504) - [remove unnecessary install script](https://github.com/muerrilla/sd-webui-detail-daemon/commit/3bb43896426f282742e951b28aac9bf5da0e725b) `numpy` `matplotlib` are sub dependencies of web UI so there's no point of installing them yourself `numpy` is it dependency of losts of packages and `matplotlib` is a dependency of `gradio` --- UI fixes > there are ways of making your versions work if you prefer your version but this way is simpler - [switch to InputAccordion](https://github.com/muerrilla/sd-webui-detail-daemon/commit/fbb3f4e74991e82cbf4cefdcf95b7160851016c0) using the webui custom gradio component InputAccordion an `Accordion with checkbox` as opposed to using the custom JavaScript activation color change you've created yourself  circumvents the issue where you have multiple elements of the same ID across different tabs causeing togging the `img2img enable` will chenge the color of the `txt2img accordion` - [use class for css](https://github.com/muerrilla/sd-webui-detail-daemon/commit/0fa632198ee84380ef29f3112f90f3cf9de28ab4) use class to specify these styles as opposed to using ID, it's also circumvents the issue where you have multiple elements of the same ID across different tabs --- if for some reason in the future or in other extensions you do need `elem_id` then use [`self.elem_id('XXX')`](https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/1c0a0c4c26f78c32095ebc7f8af82f5c04fca8c0/modules/scripts.py#L327-L335) to create the id --- video <details><summary>before video</summary> <p> https://github.com/muerrilla/sd-webui-detail-daemon/assets/40751091/02fda1bc-de8f-4e90-b0e8-a8510b13f87b </p> </details> <details><summary>after video</summary> <p> https://github.com/muerrilla/sd-webui-detail-daemon/assets/40751091/87aa5caf-64d4-45c6-919c-04805b0fe71b </p> </details> --- optional change > remove this if you don't like it - [compact infotext](https://github.com/muerrilla/sd-webui-detail-daemon/commit/ae7dcf78615d1b49951de4a4323cba220a5cbee0) theres is no issue with the current implementation but I feel like it's taking up lots of space I feel it makes sence to compact all of the info into one key removing the need of adding so many `DD_xxxxxx` note: has [backwards compatibility](https://github.com/muerrilla/sd-webui-detail-daemon/pull/1/commits/ae7dcf78615d1b49951de4a4323cba220a5cbee0#diff-1f32eb4a244add98757d2b939c6a3cb06a55aae1c4cb5b624d5ff60c581e311eR71) with old format before PR ``` DD_enabled: True, DD_amount: 0.5, DD_start: 0, DD_end: 1, DD_bias: 0.5, DD_exponent: 1, DD_start_offset: 0, DD_end_offset: 0, DD_fade: 0, DD_smooth: True ``` after PR ``` Detail Daemon: "amount:0.5,st:0,ed:1,bias:0.5,exp:1,st_offset:0,ed_offset:0,fade:0,smooth:1" ``` > if you don't like my abbreviations change it --- I think every commit in this PR is `Cherry Pickable` if you don't like a certain change --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-10-31 21:01:43 +00:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

No results found.

Labels

Clear labels   

pull-request

Mirrored from GitHub Pull Request

No labels

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

muerrilla/sd-webui-detail-daemon#15

No description provided.