muerrilla/sd-webui-detail-daemon
1
0
Fork 0
mirror of https://github.com/muerrilla/sd-webui-detail-daemon.git synced 2026-11-05 01:37:56 +00:00
Code Issues 4 Projects Packages Wiki Activity

[PR #2] [MERGED] fix don't remove all call back #16

New issue
Closed
opened 2026-10-31 21:01:43 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-31 21:01:43 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/muerrilla/sd-webui-detail-daemon/pull/2
Author: @w-e-w
Created: 5/15/2024
Status: ✅ Merged
Merged: 5/15/2024
Merged by: @muerrilla

Base: main ← Head: fix-don't-remove-all-call-back

📝 Commits (1)

  • 9d0be13 fix don't remove all call back

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 scripts/detail_daemon.py (+3 -3)

📄 Description

remove_current_script_callbacks() removes all callbackks from this script
remove_callbacks_for_function(XXX) only removes XXX

remove_current_script_callbacks() was fine before since there's only one call back
but I added another callback that shouldn't be removed using remove_current_script_callbacks() will cause thinks to break

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/muerrilla/sd-webui-detail-daemon/pull/2 **Author:** [@w-e-w](https://github.com/w-e-w) **Created:** 5/15/2024 **Status:** ✅ Merged **Merged:** 5/15/2024 **Merged by:** [@muerrilla](https://github.com/muerrilla) **Base:** `main` ← **Head:** `fix-don't-remove-all-call-back` --- ### 📝 Commits (1) - [`9d0be13`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/9d0be13cfee7499c76eed721345726566b1d6f4e) fix don't remove all call back ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `scripts/detail_daemon.py` (+3 -3) </details> ### 📄 Description - fix that https://github.com/muerrilla/sd-webui-detail-daemon/pull/1#issuecomment-2112151915 `remove_current_script_callbacks()` removes all callbackks from this script `remove_callbacks_for_function(XXX)` only removes `XXX` `remove_current_script_callbacks()` was fine before since there's only one call back but I added another callback that shouldn't be removed using `remove_current_script_callbacks()` will cause thinks to break --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 21:01:43 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
muerrilla/sd-webui-detail-daemon#16
No description provided.