[PR #4] [MERGED] fix disable during hires fix #17

New issue

Closed

opened 2026-10-31 21:01:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 21:01:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/muerrilla/sd-webui-detail-daemon/pull/4
Author: @w-e-w
Created: 7/1/2024
Status: ✅ Merged
Merged: 7/1/2024
Merged by: @muerrilla

Base: main ← Head: main

📝 Commits (3)

da12d2e fix disable during hires fix
7042530 formatting
f1a3c5e PEP 8: E722 do not use bare 'except'

📊 Changes

1 file changed (+21 additions, -15 deletions)

View changed files

📝 scripts/detail_daemon.py (+21 -15)

📄 Description

process it's only executed ONCE per entire job
one job can have multiple batch counts

self.is_hires = False is in process
when hires fix is enable
self.is_hires = True will be set in before_hr
if the job end hear then it's fine
but this is not the end when batch count > 1

the next batch will not run batch counts
since self.is_hires nevert reseted to back to False for 2nd batch and onwards extension will be disabled

fix is simple
moveing self.is_hires = False to before_process_batch should solve the issue

additional changes apply some formatting

and importantly PEP 8: E722 do not use bare 'except'

bare 'except' can also catch keyboard interrupt

most extension that requires knowing whether or not it's hires pass would would just access the p.is_hr_pass attribute and not needing the extra logic, but unfortunately you are working with denoiser_callback without easy access to p
I think current way is thg is the easiest method

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/muerrilla/sd-webui-detail-daemon/pull/4 **Author:** [@w-e-w](https://github.com/w-e-w) **Created:** 7/1/2024 **Status:** ✅ Merged **Merged:** 7/1/2024 **Merged by:** [@muerrilla](https://github.com/muerrilla) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`da12d2e`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/da12d2edc532b2e1ea835ea7e1ea473fd88078e0) fix disable during hires fix - [`7042530`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/704253022fdf1760211b8931774d586dba27752c) formatting - [`f1a3c5e`](https://github.com/muerrilla/sd-webui-detail-daemon/commit/f1a3c5ed8f2ccdc1a60672f214d12dc0a6a30179) PEP 8: E722 do not use bare 'except' ### 📊 Changes **1 file changed** (+21 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `scripts/detail_daemon.py` (+21 -15) </details> ### 📄 Description `process` it's only executed ONCE per entire job one job can have multiple `batch counts` `self.is_hires = False` is in `process` when hires fix is enable `self.is_hires = True` will be set in `before_hr` if the job end hear then it's fine but this is not the end when `batch count > 1` the next batch will not run `batch counts` since `self.is_hires` nevert reseted to back to `False` for 2nd batch and onwards extension will be disabled fix is simple moveing `self.is_hires = False` to `before_process_batch` should solve the issue --- additional changes apply some formatting and importantly PEP 8: E722 do not use bare 'except' > bare 'except' can also catch keyboard interrupt --- most extension that requires knowing whether or not it's hires pass would would just access the `p.is_hr_pass` attribute and not needing the extra logic, but unfortunately you are working with `denoiser_callback` without easy access to `p` I think current way is thg is the easiest method --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 21:01:43 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

muerrilla/sd-webui-detail-daemon#17

No description provided.

Rows
Columns