[PR #218] fix: allow OAuth popups to open inside Electron webview #230

New issue

Open

opened 2026-10-18 14:07:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-18 14:07:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/desktop/pull/218
Author: @pascal-sidlee
Created: 5/26/2026
Status: 🔄 Open

Base: main ← Head: fix/oauth-popup-blocked-in-webview

📝 Commits (1)

169b98b fix: allow OAuth popups to open inside Electron webview

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 src/main/index.ts (+13 -0)

📄 Description

Description

OAuth popups (Google Drive, Google Sign-In, etc.) are blocked when triggered
from a webview because setWindowOpenHandler returns { action: 'deny' } for
all popups. The popup opens in the system browser instead, which breaks the
OAuth handshake, the opener page can't receive the postMessage callback from
an external browser window.

Fix: whitelist known OAuth provider hosts so their popups open as child windows
inside Electron, where the callback can complete normally. All other popups
continue to open in the system browser.

Closes #175

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/desktop/pull/218 **Author:** [@pascal-sidlee](https://github.com/pascal-sidlee) **Created:** 5/26/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/oauth-popup-blocked-in-webview` --- ### 📝 Commits (1) - [`169b98b`](https://github.com/open-webui/desktop/commit/169b98b218e6267db6c1023aef328802bb6486af) fix: allow OAuth popups to open inside Electron webview ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/main/index.ts` (+13 -0) </details> ### 📄 Description ## Description OAuth popups (Google Drive, Google Sign-In, etc.) are blocked when triggered from a webview because `setWindowOpenHandler` returns `{ action: 'deny' }` for all popups. The popup opens in the system browser instead, which breaks the OAuth handshake, the opener page can't receive the postMessage callback from an external browser window. Fix: whitelist known OAuth provider hosts so their popups open as child windows inside Electron, where the callback can complete normally. All other popups continue to open in the system browser. ## Related Issues Closes #175 ## Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/desktop/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-18 14:07:10 +00:00

No labels

help wanted

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

open-webui/desktop#230

No description provided.

Rows
Columns