[PR #187] [CLOSED] Fix: Error when get single response #201

New issue

Closed

opened 2026-10-18 21:12:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-18 21:12:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/mcpo/pull/187
Author: @tpdns90321
Created: 7/1/2025
Status: ❌ Closed

Base: dev ← Head: fix/singleResponse

📝 Commits (5)

101c513 Gracefully shutdown uvicorn.Server on task cancellation in run()
663f731 Merge pull request #162 from 021gink/graceful-uvicorn-shutdown
4758d30 Merge pull request #140 from open-webui/dev
c6d7ca2 Fix: Error when get single response
3ee2712 Test entire final response wrapped dictionary

📊 Changes

2 files changed (+9 additions, -3 deletions)

View changed files

📝 src/mcpo/main.py (+7 -1)
📝 src/mcpo/utils/main.py (+2 -2)

📄 Description

I don't know why MCPO or FastAPI need dictionary that contain "result" member, only for single response.
But, it is now working.

#186

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

[Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)]

Added

[List any new features, functionalities, or additions]

Changed

[List any changes, updates, refactorings, or optimizations]

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

[List any fixes, corrections, or bug fixes]

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/mcpo/pull/187 **Author:** [@tpdns90321](https://github.com/tpdns90321) **Created:** 7/1/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/singleResponse` --- ### 📝 Commits (5) - [`101c513`](https://github.com/open-webui/mcpo/commit/101c513aebf2744225a17d51deef27f2a2d98ea4) Gracefully shutdown uvicorn.Server on task cancellation in run() - [`663f731`](https://github.com/open-webui/mcpo/commit/663f7312bb98ec17f3af4b6ec573a179da82b111) Merge pull request #162 from 021gink/graceful-uvicorn-shutdown - [`4758d30`](https://github.com/open-webui/mcpo/commit/4758d30f6cb921658c10cb9675320a598b31addb) Merge pull request #140 from open-webui/dev - [`c6d7ca2`](https://github.com/open-webui/mcpo/commit/c6d7ca24749eae81c78006270fc94efd02bf6320) Fix: Error when get single response - [`3ee2712`](https://github.com/open-webui/mcpo/commit/3ee2712441ae6c7e2715ed28ce52c3b82e21890a) Test entire final response wrapped dictionary ### 📊 Changes **2 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/mcpo/main.py` (+7 -1) 📝 `src/mcpo/utils/main.py` (+2 -2) </details> ### 📄 Description 1. I don't know why MCPO or FastAPI need dictionary that contain "result" member, only for single response. 2. But, it is now working. #186 # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - [Concisely describe the changes made in this pull request, including any relevant motivation and impact (e.g., fixing a bug, adding a feature, or improving performance)] ### Added - [List any new features, functionalities, or additions] ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - [List any fixes, corrections, or bug fixes] ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-18 21:12:38 +00:00