[PR #253] [MERGED] fix: Initialize and track lifespans for sub-apps made during hot reload #225

New issue

Closed

opened 2026-10-18 21:12:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-18 21:12:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/mcpo/pull/253
Author: @iann0036
Created: 9/23/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @tjbck

Base: dev ← Head: fix-subapp-lifespan

📝 Commits (1)

d88a23c fix: Initialize and track lifespans for sub-apps made during hot reload

📊 Changes

1 file changed (+33 additions, -9 deletions)

View changed files

📝 src/mcpo/main.py (+33 -9)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[~] Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

When using hot reload functionality, tooling fails to populate as the lifespan handler is not entered.

Added

None

Changed

None

Deprecated

None

Removed

None

Fixed

Fixed lifespan execution when hot reloading adding servers

Security

None

Breaking Changes

None

Additional Information

To replicate the bug, I used SSE MCP servers and modified a header. When hot reloading, the functionality is to remove and re-add, however the lifespan() function does not fire at this time for the sub-app (only on initial load).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/mcpo/pull/253 **Author:** [@iann0036](https://github.com/iann0036) **Created:** 9/23/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-subapp-lifespan` --- ### 📝 Commits (1) - [`d88a23c`](https://github.com/open-webui/mcpo/commit/d88a23c804ef5771edbd29a41c92779a62456b1d) fix: Initialize and track lifespans for sub-apps made during hot reload ### 📊 Changes **1 file changed** (+33 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/mcpo/main.py` (+33 -9) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [~] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - When using hot reload functionality, tooling fails to populate as the lifespan handler is not entered. ### Added - None ### Changed - None ### Deprecated - None ### Removed - None ### Fixed - Fixed lifespan execution when hot reloading adding servers ### Security - None ### Breaking Changes - None --- ### Additional Information - To replicate the bug, I used SSE MCP servers and modified a header. When hot reloading, the functionality is to remove and re-add, however the lifespan() function does not fire at this time for the sub-app (only on initial load). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-18 21:12:50 +00:00