open-webui/oikb
1
0
Fork 0
mirror of https://github.com/open-webui/oikb.git synced 2026-11-05 01:27:25 +00:00
Code Issues 72 Projects Packages Wiki Activity

[PR #140] [MERGED] fix: handle Nextcloud DAV path encoding #131

New issue
Closed
opened 2026-10-18 21:14:36 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-18 21:14:36 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/open-webui/oikb/pull/140
Author: @glonor
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @tjbck

Base: main ← Head: fix/nextcloud-dav-path-encoding

📝 Commits (1)

  • e295e4c fix: handle Nextcloud DAV path encoding

📊 Changes

2 files changed (+89 additions, -4 deletions)

View changed files

📝 src/oikb/connectors/nextcloud.py (+4 -4)
➕ tests/test_nextcloud.py (+85 -0)

📄 Description

Fixes #74.

Nextcloud can return WebDAV hrefs containing user@example.com, while OIKB builds the DAV root using user%40example.com. This mismatch discards valid entries and reports an empty source.

Decode both paths once before matching and check the root boundary. This preserves distinct filenames containing spaces and literal %20.

Adds regression tests.

Testing

  • New regression tests pass.
  • Live-tested against Nextcloud 31.0.4.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/oikb/pull/140 **Author:** [@glonor](https://github.com/glonor) **Created:** 10/9/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `main` ← **Head:** `fix/nextcloud-dav-path-encoding` --- ### 📝 Commits (1) - [`e295e4c`](https://github.com/open-webui/oikb/commit/e295e4c3020e2a4f9634b93b26d23d7648dc3e98) fix: handle Nextcloud DAV path encoding ### 📊 Changes **2 files changed** (+89 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/oikb/connectors/nextcloud.py` (+4 -4) ➕ `tests/test_nextcloud.py` (+85 -0) </details> ### 📄 Description Fixes #74. Nextcloud can return WebDAV hrefs containing `user@example.com`, while OIKB builds the DAV root using `user%40example.com`. This mismatch discards valid entries and reports an empty source. Decode both paths once before matching and check the root boundary. This preserves distinct filenames containing spaces and literal `%20`. Adds regression tests. ## Testing - New regression tests pass. - Live-tested against Nextcloud 31.0.4. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-18 21:14:36 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release
v0.6.0
v0.5.0
v0.4.0
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.3
v0.1.2
v0.1.1
v0.1.0
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
open-webui/oikb#131
No description provided.