[PR #28] [CLOSED] adding ROS and jabas customisations #113

New issue

Closed

opened 2026-10-18 21:10:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-18 21:10:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-terminal/pull/28
Author: @marc-hanheide
Created: 3/7/2026
Status: ❌ Closed

Base: main ← Head: jabas_version

📝 Commits (1)

54f1992 fix: comment out ARM64 platform in Docker workflow and update Dockerfile to include additional dependencies

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 .github/workflows/docker.yml (+1 -1)
📝 Dockerfile (+10 -1)

📄 Description

This pull request updates the Docker setup to use a ROS-based image instead of the standard Python image, and adjusts the workflow and dependencies accordingly. The main changes focus on transitioning to ROS, updating the base image and installed packages, and modifying the GitHub Actions workflow to reflect these changes.

Docker image and dependencies update:

Changed the base image in Dockerfile from python:3.12 to ros:${ROS_DISTRO} (with ROS_DISTRO defaulting to humble), and set the shell to use /bin/bash for compatibility with ROS.
Added installation of python3-pip, python3-venv, and ros-${ROS_DISTRO}-ros-base to the list of packages in the Docker build process.

Workflow adjustments:

Commented out the linux/arm64 platform in the .github/workflows/docker.yml matrix, likely due to compatibility issues with the new ROS-based image.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-terminal/pull/28 **Author:** [@marc-hanheide](https://github.com/marc-hanheide) **Created:** 3/7/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `jabas_version` --- ### 📝 Commits (1) - [`54f1992`](https://github.com/open-webui/open-terminal/commit/54f1992c522ce303a7c35a0541c4d1f36ed3d795) fix: comment out ARM64 platform in Docker workflow and update Dockerfile to include additional dependencies ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker.yml` (+1 -1) 📝 `Dockerfile` (+10 -1) </details> ### 📄 Description This pull request updates the Docker setup to use a ROS-based image instead of the standard Python image, and adjusts the workflow and dependencies accordingly. The main changes focus on transitioning to ROS, updating the base image and installed packages, and modifying the GitHub Actions workflow to reflect these changes. **Docker image and dependencies update:** * Changed the base image in `Dockerfile` from `python:3.12` to `ros:${ROS_DISTRO}` (with `ROS_DISTRO` defaulting to `humble`), and set the shell to use `/bin/bash` for compatibility with ROS. * Added installation of `python3-pip`, `python3-venv`, and `ros-${ROS_DISTRO}-ros-base` to the list of packages in the Docker build process. **Workflow adjustments:** * Commented out the `linux/arm64` platform in the `.github/workflows/docker.yml` matrix, likely due to compatibility issues with the new ROS-based image. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-18 21:10:55 +00:00