[PR #156] [CLOSED] fix: support Windows filesystem paths #142

New issue

Closed

opened 2026-10-18 21:11:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-18 21:11:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-terminal/pull/156
Author: @mikemikimike
Created: 8/18/2026
Status: ❌ Closed

Base: main ← Head: fix/windows-compatibility-issue-154

📝 Commits (2)

4b814cd fix: support Windows filesystem paths
c838df3 Merge branch 'main' into fix/windows-compatibility-issue-154

📊 Changes

3 files changed (+33 additions, -2 deletions)

View changed files

📝 open_terminal/main.py (+3 -1)
📝 open_terminal/utils/fs.py (+1 -1)
➕ tests/test_windows_compatibility.py (+29 -0)

📄 Description

Summary

Fixes #154.

Preserve Windows drive-letter paths in /files/serve/{path} instead of prepending / to C:/... paths.
Fall back to os.access(path, os.W_OK) when effective_ids=True is unsupported on Windows.
Add regression tests for both compatibility bugs.

Compatibility

This preserves the existing leading-slash behavior for POSIX and relative paths. On Windows, drive-letter paths are passed through unchanged. No API changes are introduced.

Verification

pytest -q tests/test_windows_compatibility.py — 2 passed (one existing pytest deprecation warning)
python -m compileall -q open_terminal — passed
git diff --check — passed

The full test suite was not run because the repository currently has no existing test suite beyond the focused regression coverage added here. Docker image builds were not run because this change is limited to Python unit behavior and does not alter image configuration.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-terminal/pull/156 **Author:** [@mikemikimike](https://github.com/mikemikimike) **Created:** 8/18/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/windows-compatibility-issue-154` --- ### 📝 Commits (2) - [`4b814cd`](https://github.com/open-webui/open-terminal/commit/4b814cd89d3cf74501e551527089fe466d07acba) fix: support Windows filesystem paths - [`c838df3`](https://github.com/open-webui/open-terminal/commit/c838df34d8f8d1f15eb6b62a849772aa67fe7232) Merge branch 'main' into fix/windows-compatibility-issue-154 ### 📊 Changes **3 files changed** (+33 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `open_terminal/main.py` (+3 -1) 📝 `open_terminal/utils/fs.py` (+1 -1) ➕ `tests/test_windows_compatibility.py` (+29 -0) </details> ### 📄 Description ## Summary Fixes #154. - Preserve Windows drive-letter paths in `/files/serve/{path}` instead of prepending `/` to `C:/...` paths. - Fall back to `os.access(path, os.W_OK)` when `effective_ids=True` is unsupported on Windows. - Add regression tests for both compatibility bugs. ## Compatibility This preserves the existing leading-slash behavior for POSIX and relative paths. On Windows, drive-letter paths are passed through unchanged. No API changes are introduced. ## Verification - `pytest -q tests/test_windows_compatibility.py` — 2 passed (one existing pytest deprecation warning) - `python -m compileall -q open_terminal` — passed - `git diff --check` — passed The full test suite was not run because the repository currently has no existing test suite beyond the focused regression coverage added here. Docker image builds were not run because this change is limited to Python unit behavior and does not alter image configuration. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-18 21:11:11 +00:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

open-webui/open-terminal#142

No description provided.

Rows
Columns