[PR #164] Fix multiuser root account collision #146

Open
opened 2026-10-18 21:11:12 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-terminal/pull/164
Author: @maurerle
Created: 8/26/2026
Status: 🔄 Open

Base: main ← Head: fix-multiuser-root-account-collision


📝 Commits (3)

  • ef49cab fix: prevent multi-user X-User-Id from resolving to a system account
  • c577b3e fix: also reject the server's own account in the collision check
  • 732e970 fix: prevent username truncation collisions and validate fallback

📊 Changes

1 file changed (+59 additions, -14 deletions)

View changed files

📝 open_terminal/utils/user_isolation.py (+59 -14)

📄 Description

This fixes account provisioning of existing usernames.
This is possible if the API is accessible to others as well which can provide arbitrary X-user-ID values.

Instead of this PR, this can be sanitized using OPEN_TERMINAL_USER_PREFIX.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-terminal/pull/164 **Author:** [@maurerle](https://github.com/maurerle) **Created:** 8/26/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-multiuser-root-account-collision` --- ### 📝 Commits (3) - [`ef49cab`](https://github.com/open-webui/open-terminal/commit/ef49cabd9e15d70b0b5641219d63931bac1c0817) fix: prevent multi-user X-User-Id from resolving to a system account - [`c577b3e`](https://github.com/open-webui/open-terminal/commit/c577b3ebef841c7bf3ccc9e1b35936736c3eff79) fix: also reject the server's own account in the collision check - [`732e970`](https://github.com/open-webui/open-terminal/commit/732e9705e66ff6ac82a64170606fe1a045e25c11) fix: prevent username truncation collisions and validate fallback ### 📊 Changes **1 file changed** (+59 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `open_terminal/utils/user_isolation.py` (+59 -14) </details> ### 📄 Description This fixes account provisioning of existing usernames. This is possible if the API is accessible to others as well which can provide arbitrary `X-user-ID` values. Instead of this PR, this can be sanitized using `OPEN_TERMINAL_USER_PREFIX`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
bug
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
open-webui/open-terminal#146
No description provided.