open-webui/terminals
1
0
Fork 0
mirror of https://github.com/open-webui/terminals.git synced 2026-11-05 01:37:21 +00:00
Code Issues 14 Projects Packages Wiki Activity

[GH-ISSUE #64] Named-policy route ignores TERMINALS_KUBERNETES_IMAGE: merge_policy_defaults injects TERMINALS_IMAGE (default :latest) into every policy spec #35

New issue
Open
opened 2026-10-18 21:13:37 +00:00 by bsakaguchi · 1 comment
bsakaguchi commented 2026-10-18 21:13:37 +00:00
Owner
Copy link

Originally created by @wa91h on GitHub (Sep 17, 2026).
Original GitHub issue: https://github.com/open-webui/terminals/issues/64

Version: terminals 0.2.4 (unchanged on main) · backend kubernetes-operator · installed via the terminals Helm chart 0.7.0, which sets only TERMINALS_KUBERNETES_IMAGE

What happens

terminals/utils/policy_specs.py:

def merge_policy_defaults(policy_data: dict) -> dict:
    defaults = {}
    if settings.image:               # default "ghcr.io/open-webui/open-terminal:latest" — always truthy
        defaults["image"] = settings.image
    return {**defaults, **{k: v for k, v in policy_data.items() if v is not None}}

and backends/kubernetes_operator.py:

image = s.get("image", settings.effective_kubernetes_image)

effective_kubernetes_image (kubernetes_image or image) is only consulted when the spec has no image — but for any request through /p/<policy> the spec always has one, because the merge put settings.image there. So:

  • plain route → TERMINALS_KUBERNETES_IMAGE (pinned by the chart) ✔
  • /p/<policy> route, policy without image → TERMINALS_IMAGE → open-terminal:latest ✘

The Helm chart never sets TERMINALS_IMAGE, so every chart user who adopts a policy (the only way to get persistence) silently runs an unpinned image. Observed: first policy-provisioned pod pulled open-terminal:latest while terminalImage was pinned to 0.12.5.

Expected

merge_policy_defaults (or _create_terminal_cr) should default to settings.effective_kubernetes_image on the kubernetes backends, i.e. kubernetes_image must win over image when the policy itself does not set one. A policy-set image should of course still override both.

Workaround

Set TERMINALS_IMAGE to the same value as TERMINALS_KUBERNETES_IMAGE (chart: orchestrator.extraEnvVars).

Originally created by @wa91h on GitHub (Sep 17, 2026). Original GitHub issue: https://github.com/open-webui/terminals/issues/64 **Version:** `terminals` 0.2.4 (unchanged on `main`) · backend `kubernetes-operator` · installed via the `terminals` Helm chart 0.7.0, which sets only `TERMINALS_KUBERNETES_IMAGE` ## What happens `terminals/utils/policy_specs.py`: ```py def merge_policy_defaults(policy_data: dict) -> dict: defaults = {} if settings.image: # default "ghcr.io/open-webui/open-terminal:latest" — always truthy defaults["image"] = settings.image return {**defaults, **{k: v for k, v in policy_data.items() if v is not None}} ``` and `backends/kubernetes_operator.py`: ```py image = s.get("image", settings.effective_kubernetes_image) ``` `effective_kubernetes_image` (`kubernetes_image or image`) is only consulted when the spec has no `image` — but for any request through `/p/<policy>` the spec always has one, because the merge put `settings.image` there. So: - plain route → `TERMINALS_KUBERNETES_IMAGE` (pinned by the chart) ✔ - `/p/<policy>` route, policy without `image` → `TERMINALS_IMAGE` → **`open-terminal:latest`** ✘ The Helm chart never sets `TERMINALS_IMAGE`, so every chart user who adopts a policy (the only way to get persistence) silently runs an unpinned image. Observed: first policy-provisioned pod pulled `open-terminal:latest` while `terminalImage` was pinned to `0.12.5`. ## Expected `merge_policy_defaults` (or `_create_terminal_cr`) should default to `settings.effective_kubernetes_image` on the kubernetes backends, i.e. `kubernetes_image` must win over `image` when the policy itself does not set one. A policy-set `image` should of course still override both. ## Workaround Set `TERMINALS_IMAGE` to the same value as `TERMINALS_KUBERNETES_IMAGE` (chart: `orchestrator.extraEnvVars`).
bsakaguchi commented 2026-10-18 21:13:38 +00:00
Author
Owner
Copy link

@owui-terminator[bot] commented on GitHub (Sep 17, 2026):

⚠️ Missing Issue Title Prefix

@wa91h, your issue title is missing a categorising prefix (e.g. bug:, feat:, docs:).

Please update the title to lead with one of:

  • bug: bug report or error
  • feat: feature request or enhancement
  • docs: documentation issue
  • question: usage question
  • help: support request

Example: bug: Login fails when the password contains special characters

<!-- gh-comment-id:5722871736 --> @owui-terminator[bot] commented on GitHub (Sep 17, 2026): # ⚠️ Missing Issue Title Prefix @wa91h, your issue title is missing a categorising prefix (e.g. `bug:`, `feat:`, `docs:`). Please update the title to lead with one of: - **bug**: bug report or error - **feat**: feature request or enhancement - **docs**: documentation issue - **question**: usage question - **help**: support request Example: `bug: Login fails when the password contains special characters`
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.0
v0.0.8
v0.0.7
v0.0.6
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
open-webui/terminals#35
No description provided.