[PR #68] [CLOSED] fix: terminal window shows [Connection closed] in chats with Open Terminal 0.12.4 and newer #67

New issue

Closed

opened 2026-10-18 21:13:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-18 21:13:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/terminals/pull/68
Author: @Classic298
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: fix/ws-session-id

📝 Commits (1)

9d20da9 fix: terminal window shows [Connection closed] in chats with Open Terminal 0.12.4 and newer

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 terminals/routers/proxy.py (+2 -1)

📄 Description

Description

Since Open Terminal 0.12.4, a terminal session only accepts a live connection that carries the same chat id it was created with. Terminals sent the chat id when creating the session but not when opening the live terminal connection, so in any saved chat the terminal window showed "[Connection closed]" right after opening. Unsaved chats have no chat id yet and were not affected. Terminals now sends the chat id on the live connection too.

Tested end to end with Open WebUI dev, Terminals on the Docker backend and Open Terminal 0.14.0: a saved chat showed "[Connection closed]" before and runs commands after, unsaved chats and the file panel work as before.

cc @tjbck

Fixes open-webui/open-terminal#169

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/terminals/pull/68 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/ws-session-id` --- ### 📝 Commits (1) - [`9d20da9`](https://github.com/open-webui/terminals/commit/9d20da9879224f06594e88fe96fcd26cd436c9ca) fix: terminal window shows [Connection closed] in chats with Open Terminal 0.12.4 and newer ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `terminals/routers/proxy.py` (+2 -1) </details> ### 📄 Description ## Description Since Open Terminal 0.12.4, a terminal session only accepts a live connection that carries the same chat id it was created with. Terminals sent the chat id when creating the session but not when opening the live terminal connection, so in any saved chat the terminal window showed "[Connection closed]" right after opening. Unsaved chats have no chat id yet and were not affected. Terminals now sends the chat id on the live connection too. Tested end to end with Open WebUI dev, Terminals on the Docker backend and Open Terminal 0.14.0: a saved chat showed "[Connection closed]" before and runs commands after, unsaved chats and the file panel work as before. cc @tjbck ## Related Issues Fixes open-webui/open-terminal#169 --- ## Contributor License Agreement  - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](./CLA.md), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-18 21:13:57 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

open-webui/terminals#67

No description provided.

Rows
Columns