mirror of
https://github.com/openai/CLIP.git
synced 2026-11-05 01:37:26 +00:00
[GH-ISSUE #396] Attempt to load from an already-used file pointer in clip/clip.py #337
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
openai/CLIP#337
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mrd on GitHub (Oct 14, 2023).
Original GitHub issue: https://github.com/openai/CLIP/issues/396
github.com/openai/CLIP@a1d071733d/clip/clip.py (L136)Went through this code path when attempting to load my own saved checkpoint, and kept getting an EOF error until I inserted a rewind,
opened_file.seek(0)before thetorch.load(linked above).This is because the
try...exceptblock has a (different)loadin thetrypart, so if it falls back to the exception handler the file-handle is not necessarily at the beginning of the file, and therefore it is not valid to try to load from the file-handle again as-is. It is possible that it would be better to separate the exception handling for file errors from the exception handling for 'jit loading problems', or maybe even better not to try to load with the jit module when the jit option is False, but I'll leave that to you to decide.Note that I have since switched to loading the ViT-B32 model and then replacing the state_dict, so I don't trigger this bug in my own code anymore.