[PR #176] [MERGED] use pkg_resources for PyTorch version comparison #467

Closed
opened 2026-10-31 21:15:18 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/openai/CLIP/pull/176
Author: @jiahuei
Created: 11/9/2021
Status: ✅ Merged
Merged: 11/9/2021
Merged by: @jongwook

Base: main ← Head: pytorch-version-patch


📝 Commits (1)

  • 8dcf65d use pkg_resources for PyTorch version comparison

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 clip/clip.py (+2 -1)

📄 Description

Use pkg_resources from setuptools to parse version strings, it is required by Pytorch >= 0.4.1 anyway.
Compatible with TorchVersion.

Examples: 1.9.0a0+2ecb2c7 1.10.0.dev20210803+cu111 1.10.0+cu111


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openai/CLIP/pull/176 **Author:** [@jiahuei](https://github.com/jiahuei) **Created:** 11/9/2021 **Status:** ✅ Merged **Merged:** 11/9/2021 **Merged by:** [@jongwook](https://github.com/jongwook) **Base:** `main` ← **Head:** `pytorch-version-patch` --- ### 📝 Commits (1) - [`8dcf65d`](https://github.com/openai/CLIP/commit/8dcf65d1b8d99a40d3210c72a94771533d89e808) use `pkg_resources` for PyTorch version comparison ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `clip/clip.py` (+2 -1) </details> ### 📄 Description Use `pkg_resources` from `setuptools` to parse version strings, it is required by Pytorch >= 0.4.1 anyway. Compatible with `TorchVersion`. Examples: `1.9.0a0+2ecb2c7` `1.10.0.dev20210803+cu111` `1.10.0+cu111` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 21:15:18 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
openai/CLIP#467
No description provided.